Re: Review Request 73405: ATLAS-4302: Migrated Data: Process Entity Name not set to QualifiedName

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73405/#review223104
---


Ship it!




Ship It!

- Nikhil Bonte


On June 4, 2021, 10:18 a.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73405/
> ---
> 
> (Updated June 4, 2021, 10:18 a.m.)
> 
> 
> Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-4302
> https://issues.apache.org/jira/browse/ATLAS-4302
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> Java patch is optionally run when 
> ```atlas.process.name.update.patch
> 
> is set to true.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java e31afa89a 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
>  fae28c440 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/ProcessNamePatch.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73405/diff/2/
> 
> 
> Testing
> ---
> 
> **Functional test**
> - Validated with medium data set (5M entities).
> 
> **Volume test**
> - Validated improvement for a lineage entity with 1200 inputs and 1700 
> outputs. With this change, the _AtlasEntityHeader_ payload size reduces by 
> 90%.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 73405: ATLAS-4302: Migrated Data: Process Entity Name not set to QualifiedName

[Ashutosh Mestry via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73405/
---

(Updated June 4, 2021, 4:48 a.m.)


Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.


Changes
---

Updates include: Addressed review comments.


Bugs: ATLAS-4302
https://issues.apache.org/jira/browse/ATLAS-4302


Repository: atlas


Description
---

**Approach**
Java patch is optionally run when 
```atlas.process.name.update.patch

is set to true.


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java e31afa89a 
  
repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
 fae28c440 
  
repository/src/main/java/org/apache/atlas/repository/patches/ProcessNamePatch.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/73405/diff/2/

Changes: https://reviews.apache.org/r/73405/diff/1-2/


Testing
---

**Functional test**
- Validated with medium data set (5M entities).

**Volume test**
- Validated improvement for a lineage entity with 1200 inputs and 1700 outputs. 
With this change, the _AtlasEntityHeader_ payload size reduces by 90%.


Thanks,

Ashutosh Mestry

Re: Review Request 73405: ATLAS-4302: Migrated Data: Process Entity Name not set to QualifiedName

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73405/#review223101
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 3, 2021, 9:43 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73405/
> ---
> 
> (Updated June 3, 2021, 9:43 p.m.)
> 
> 
> Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-4302
> https://issues.apache.org/jira/browse/ATLAS-4302
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> Java patch is optionally run when 
> ```atlas.process.name.update.patch
> 
> is set to true.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java e31afa89a 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
>  fae28c440 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/ProcessNamePatch.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73405/diff/1/
> 
> 
> Testing
> ---
> 
> **Functional test**
> - Validated with medium data set (5M entities).
> 
> **Volume test**
> - Validated improvement for a lineage entity with 1200 inputs and 1700 
> outputs. With this change, the _AtlasEntityHeader_ payload size reduces by 
> 90%.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 73405: ATLAS-4302: Migrated Data: Process Entity Name not set to QualifiedName

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73405/#review223100
---




repository/src/main/java/org/apache/atlas/repository/patches/ProcessNamePatch.java
Lines 120 (patched)


Add if debug is enabled case. 

if (LOG.isDebugEnabled()) {

same for line 129


- Nixon Rodrigues


On June 3, 2021, 9:43 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73405/
> ---
> 
> (Updated June 3, 2021, 9:43 p.m.)
> 
> 
> Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-4302
> https://issues.apache.org/jira/browse/ATLAS-4302
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> Java patch is optionally run when 
> ```atlas.process.name.update.patch
> 
> is set to true.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java e31afa89a 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
>  fae28c440 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/ProcessNamePatch.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73405/diff/1/
> 
> 
> Testing
> ---
> 
> **Functional test**
> - Validated with medium data set (5M entities).
> 
> **Volume test**
> - Validated improvement for a lineage entity with 1200 inputs and 1700 
> outputs. With this change, the _AtlasEntityHeader_ payload size reduces by 
> 90%.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>