Re: Review Request 74787: ATLAS-4817 : Change compression from 'GZ' to 'SNAPPY' in Atlas HBase tables
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74787/ --- (Updated April 3, 2024, 10:24 a.m.) Review request for atlas, Jayendra Parab and Pinal Shah. Repository: atlas Description --- Currently Atlas is using Compression Algorithm as 'GZ' chaning it to 'SNAPPY' Diffs - graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseStoreManager.java f98fa7b76 repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java b7f0dd5e2 Diff: https://reviews.apache.org/r/74787/diff/2/ Testing (updated) --- 1) Unit tests New tests added. Volume testing +--+--+-+ | Description | Message | Duration| | | Count| | +--+--+-+ | Compression | | | | Alogrithm| 18000 | 4 hr 11 min | | as "GZ" | | | +--+--+-+ | Compression | | | | Alogrithm| 18000 | 1 hr 55 min | | as "SNAPPY" | | | +--+--+-+ 2) Precommit - https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1535/console Thanks, Vinayak Marraiya
Re: Review Request 74787: ATLAS-4817 : Change compression from 'GZ' to 'SNAPPY' in Atlas HBase tables
> On April 3, 2024, 8:23 a.m., Pinal Shah wrote: > > Can we add the tests performed in the description box > > Also Does SNAPPY took 4hr 11min for 18k messages ? less compared to GZ or > > it is mistake Editing above: time taken is more compared to GZ - Pinal --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74787/#review226371 --- On April 3, 2024, 4:19 a.m., Vinayak Marraiya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74787/ > --- > > (Updated April 3, 2024, 4:19 a.m.) > > > Review request for atlas, Jayendra Parab and Pinal Shah. > > > Repository: atlas > > > Description > --- > > Currently Atlas is using Compression Algorithm as 'GZ' chaning it to 'SNAPPY' > > > Diffs > - > > > graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseStoreManager.java > f98fa7b76 > > repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java > b7f0dd5e2 > > > Diff: https://reviews.apache.org/r/74787/diff/2/ > > > Testing > --- > > 1) Unit tests >New tests added. > >Volume testing >+--+--+-+ >| Description | Message | Duration| >| | Count| | >+--+--+-+ >| Compression | | | >| Alogrithm| 18000 | 1 hr 55 min | >| as "GZ" | | | >+--+--+-+ >| Compression | | | >| Alogrithm| 18000 | 4 hr 11 min | >| as "SNAPPY" | | | >+--+--+-+ > > 2) Precommit - > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1535/console > > > Thanks, > > Vinayak Marraiya > >
Re: Review Request 74787: ATLAS-4817 : Change compression from 'GZ' to 'SNAPPY' in Atlas HBase tables
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74787/#review226371 --- Ship it! Can we add the tests performed in the description box Also Does SNAPPY took 4hr 11min for 18k messages ? less compared to GZ or it is mistake - Pinal Shah On April 3, 2024, 4:19 a.m., Vinayak Marraiya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74787/ > --- > > (Updated April 3, 2024, 4:19 a.m.) > > > Review request for atlas, Jayendra Parab and Pinal Shah. > > > Repository: atlas > > > Description > --- > > Currently Atlas is using Compression Algorithm as 'GZ' chaning it to 'SNAPPY' > > > Diffs > - > > > graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseStoreManager.java > f98fa7b76 > > repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java > b7f0dd5e2 > > > Diff: https://reviews.apache.org/r/74787/diff/2/ > > > Testing > --- > > 1) Unit tests >New tests added. > >Volume testing >+--+--+-+ >| Description | Message | Duration| >| | Count| | >+--+--+-+ >| Compression | | | >| Alogrithm| 18000 | 1 hr 55 min | >| as "GZ" | | | >+--+--+-+ >| Compression | | | >| Alogrithm| 18000 | 4 hr 11 min | >| as "SNAPPY" | | | >+--+--+-+ > > 2) Precommit - > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1535/console > > > Thanks, > > Vinayak Marraiya > >
Re: Review Request 74787: ATLAS-4817 : Change compression from 'GZ' to 'SNAPPY' in Atlas HBase tables
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74787/ --- (Updated April 3, 2024, 4:19 a.m.) Review request for atlas, Jayendra Parab and Pinal Shah. Repository: atlas Description --- Currently Atlas is using Compression Algorithm as 'GZ' chaning it to 'SNAPPY' Diffs - graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseStoreManager.java f98fa7b76 repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java b7f0dd5e2 Diff: https://reviews.apache.org/r/74787/diff/2/ Testing --- 1) Unit tests New tests added. Volume testing +--+--+-+ | Description | Message | Duration| | | Count| | +--+--+-+ | Compression | | | | Alogrithm| 18000 | 1 hr 55 min | | as "GZ" | | | +--+--+-+ | Compression | | | | Alogrithm| 18000 | 4 hr 11 min | | as "SNAPPY" | | | +--+--+-+ 2) Precommit - https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1535/console Thanks, Vinayak Marraiya
