Re: Review Request 74939: ATLAS-4842 : Export/Import: fetchType as "incremental" does full export instead of connected

2024-04-05 Thread Pinal Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74939/#review226381
---


Ship it!




Ship It!

- Pinal Shah


On April 5, 2024, 8:41 a.m., Priyanshi Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74939/
> ---
> 
> (Updated April 5, 2024, 8:41 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Pinal Shah, and Sheetal Shah.
> 
> 
> Bugs: ATLAS-4842
> https://issues.apache.org/jira/browse/ATLAS-4842
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Steps:
> 
> create two hive_tables in same database:
> 
> 1. create table hive1(id int);
> 2. create table hive1_ctas as select * from hive1;
> 3. create table hive2(name string);
> 4. Perform incremental export of hive1 with changeMarker as 0 and skipLineage 
> value as false.
> 5. Import the zip.
> 
> Expectations:
> 
> a) Expectation is only the requested hive_table hive1 and its related 
> entities should be exported.
> 
> Problem:
> 
> hive2 is also imported which is an independently created entity and not 
> related to hive1.
> 
> Solution:
> 
> 1. Earlier, the implementation for fetchType as INCREMENTAL was getting 
> satisfied only if the value of skipLineage was "true" otherwise it was 
> implementing the default fetchType i.e FULL fetch and hence, all the 
> independently created entities in same db was also getting fetched.
> 
> 2. Now, the problem is fixed by adding additional condition which will handle 
> INCREMENTAL fetchType even if the value for skipLineage is false.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/EntitiesExtractor.java
>  da5cf37c4 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  65d7a1872 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/ExportIncrementalTest.java
>  0e3955dcd 
>   
> repository/src/test/resources/json/stocksDB-Entities/typedef-new-classification-T3.json
>  PRE-CREATION 
>   
> repository/src/test/resources/json/stocksDB-Entities/typesdef-new-classification-T2.json
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/74939/diff/6/
> 
> 
> Testing
> ---
> 
> Manual testing has been done for the same.
> 
> PC Link : 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1594/
> 
> 
> Thanks,
> 
> Priyanshi Shah
> 
>

Re: Review Request 74939: ATLAS-4842 : Export/Import: fetchType as "incremental" does full export instead of connected

2024-04-05 Thread Priyanshi Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74939/
---

(Updated April 5, 2024, 8:41 a.m.)


Review request for atlas, Jayendra Parab, Pinal Shah, and Sheetal Shah.


Bugs: ATLAS-4842
https://issues.apache.org/jira/browse/ATLAS-4842


Repository: atlas


Description
---

Steps:

create two hive_tables in same database:

1. create table hive1(id int);
2. create table hive1_ctas as select * from hive1;
3. create table hive2(name string);
4. Perform incremental export of hive1 with changeMarker as 0 and skipLineage 
value as false.
5. Import the zip.

Expectations:

a) Expectation is only the requested hive_table hive1 and its related entities 
should be exported.

Problem:

hive2 is also imported which is an independently created entity and not related 
to hive1.

Solution:

1. Earlier, the implementation for fetchType as INCREMENTAL was getting 
satisfied only if the value of skipLineage was "true" otherwise it was 
implementing the default fetchType i.e FULL fetch and hence, all the 
independently created entities in same db was also getting fetched.

2. Now, the problem is fixed by adding additional condition which will handle 
INCREMENTAL fetchType even if the value for skipLineage is false.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/impexp/EntitiesExtractor.java
 da5cf37c4 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 
65d7a1872 
  
repository/src/test/java/org/apache/atlas/repository/impexp/ExportIncrementalTest.java
 0e3955dcd 
  
repository/src/test/resources/json/stocksDB-Entities/typedef-new-classification-T3.json
 PRE-CREATION 
  
repository/src/test/resources/json/stocksDB-Entities/typesdef-new-classification-T2.json
 PRE-CREATION 


Diff: https://reviews.apache.org/r/74939/diff/6/

Changes: https://reviews.apache.org/r/74939/diff/5-6/


Testing
---

Manual testing has been done for the same.

PC Link : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1594/


Thanks,

Priyanshi Shah

Re: Review Request 74939: ATLAS-4842 : Export/Import: fetchType as "incremental" does full export instead of connected

2024-04-05 Thread Pinal Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74939/#review226380
---




repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
Lines 500 (patched)


retain original method and create new one, since it is a public method

public boolean isHiveTableIncrementalSkipLineage() {
return isHiveTableIncremental;
}

public boolean isHiveTableIncremental {
return isHiveTableIncremental;
}


- Pinal Shah


On April 4, 2024, 1:16 p.m., Priyanshi Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74939/
> ---
> 
> (Updated April 4, 2024, 1:16 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Pinal Shah, and Sheetal Shah.
> 
> 
> Bugs: ATLAS-4842
> https://issues.apache.org/jira/browse/ATLAS-4842
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Steps:
> 
> create two hive_tables in same database:
> 
> 1. create table hive1(id int);
> 2. create table hive1_ctas as select * from hive1;
> 3. create table hive2(name string);
> 4. Perform incremental export of hive1 with changeMarker as 0 and skipLineage 
> value as false.
> 5. Import the zip.
> 
> Expectations:
> 
> a) Expectation is only the requested hive_table hive1 and its related 
> entities should be exported.
> 
> Problem:
> 
> hive2 is also imported which is an independently created entity and not 
> related to hive1.
> 
> Solution:
> 
> 1. Earlier, the implementation for fetchType as INCREMENTAL was getting 
> satisfied only if the value of skipLineage was "true" otherwise it was 
> implementing the default fetchType i.e FULL fetch and hence, all the 
> independently created entities in same db was also getting fetched.
> 
> 2. Now, the problem is fixed by adding additional condition which will handle 
> INCREMENTAL fetchType even if the value for skipLineage is false.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/EntitiesExtractor.java
>  da5cf37c4 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  65d7a1872 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/ExportIncrementalTest.java
>  0e3955dcd 
>   
> repository/src/test/resources/json/stocksDB-Entities/typedef-new-classification-T3.json
>  PRE-CREATION 
>   
> repository/src/test/resources/json/stocksDB-Entities/typesdef-new-classification-T2.json
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/74939/diff/5/
> 
> 
> Testing
> ---
> 
> Manual testing has been done for the same.
> 
> PC Link : 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1594/
> 
> 
> Thanks,
> 
> Priyanshi Shah
> 
>

Re: Review Request 74939: ATLAS-4842 : Export/Import: fetchType as "incremental" does full export instead of connected

2024-04-05 Thread Mandar Ambawane 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74939/#review226379
---


Ship it!




Ship It!

- Mandar Ambawane


On April 4, 2024, 1:16 p.m., Priyanshi Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74939/
> ---
> 
> (Updated April 4, 2024, 1:16 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Pinal Shah, and Sheetal Shah.
> 
> 
> Bugs: ATLAS-4842
> https://issues.apache.org/jira/browse/ATLAS-4842
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Steps:
> 
> create two hive_tables in same database:
> 
> 1. create table hive1(id int);
> 2. create table hive1_ctas as select * from hive1;
> 3. create table hive2(name string);
> 4. Perform incremental export of hive1 with changeMarker as 0 and skipLineage 
> value as false.
> 5. Import the zip.
> 
> Expectations:
> 
> a) Expectation is only the requested hive_table hive1 and its related 
> entities should be exported.
> 
> Problem:
> 
> hive2 is also imported which is an independently created entity and not 
> related to hive1.
> 
> Solution:
> 
> 1. Earlier, the implementation for fetchType as INCREMENTAL was getting 
> satisfied only if the value of skipLineage was "true" otherwise it was 
> implementing the default fetchType i.e FULL fetch and hence, all the 
> independently created entities in same db was also getting fetched.
> 
> 2. Now, the problem is fixed by adding additional condition which will handle 
> INCREMENTAL fetchType even if the value for skipLineage is false.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/EntitiesExtractor.java
>  da5cf37c4 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  65d7a1872 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/ExportIncrementalTest.java
>  0e3955dcd 
>   
> repository/src/test/resources/json/stocksDB-Entities/typedef-new-classification-T3.json
>  PRE-CREATION 
>   
> repository/src/test/resources/json/stocksDB-Entities/typesdef-new-classification-T2.json
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/74939/diff/5/
> 
> 
> Testing
> ---
> 
> Manual testing has been done for the same.
> 
> PC Link : 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1594/
> 
> 
> Thanks,
> 
> Priyanshi Shah
> 
>

Re: Review Request 74939: ATLAS-4842 : Export/Import: fetchType as "incremental" does full export instead of connected

2024-04-04 Thread Priyanshi Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74939/
---

(Updated April 4, 2024, 1:16 p.m.)


Review request for atlas, Jayendra Parab, Pinal Shah, and Sheetal Shah.


Bugs: ATLAS-4842
https://issues.apache.org/jira/browse/ATLAS-4842


Repository: atlas


Description
---

Steps:

create two hive_tables in same database:

1. create table hive1(id int);
2. create table hive1_ctas as select * from hive1;
3. create table hive2(name string);
4. Perform incremental export of hive1 with changeMarker as 0 and skipLineage 
value as false.
5. Import the zip.

Expectations:

a) Expectation is only the requested hive_table hive1 and its related entities 
should be exported.

Problem:

hive2 is also imported which is an independently created entity and not related 
to hive1.

Solution:

1. Earlier, the implementation for fetchType as INCREMENTAL was getting 
satisfied only if the value of skipLineage was "true" otherwise it was 
implementing the default fetchType i.e FULL fetch and hence, all the 
independently created entities in same db was also getting fetched.

2. Now, the problem is fixed by adding additional condition which will handle 
INCREMENTAL fetchType even if the value for skipLineage is false.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/impexp/EntitiesExtractor.java
 da5cf37c4 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 
65d7a1872 
  
repository/src/test/java/org/apache/atlas/repository/impexp/ExportIncrementalTest.java
 0e3955dcd 
  
repository/src/test/resources/json/stocksDB-Entities/typedef-new-classification-T3.json
 PRE-CREATION 
  
repository/src/test/resources/json/stocksDB-Entities/typesdef-new-classification-T2.json
 PRE-CREATION 


Diff: https://reviews.apache.org/r/74939/diff/5/

Changes: https://reviews.apache.org/r/74939/diff/4-5/


Testing
---

Manual testing has been done for the same.

PC Link : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1594/


Thanks,

Priyanshi Shah

Re: Review Request 74939: ATLAS-4842 : Export/Import: fetchType as "incremental" does full export instead of connected

2024-04-04 Thread Mandar Ambawane 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74939/#review226377
---




repository/src/test/java/org/apache/atlas/repository/impexp/ExportIncrementalTest.java
Line 62 (original), 62 (patched)


Please import only those classes from package which you are going to use 
here.


- Mandar Ambawane


On April 4, 2024, 7:18 a.m., Priyanshi Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74939/
> ---
> 
> (Updated April 4, 2024, 7:18 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Pinal Shah, and Sheetal Shah.
> 
> 
> Bugs: ATLAS-4842
> https://issues.apache.org/jira/browse/ATLAS-4842
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Steps:
> 
> create two hive_tables in same database:
> 
> 1. create table hive1(id int);
> 2. create table hive1_ctas as select * from hive1;
> 3. create table hive2(name string);
> 4. Perform incremental export of hive1 with changeMarker as 0 and skipLineage 
> value as false.
> 5. Import the zip.
> 
> Expectations:
> 
> a) Expectation is only the requested hive_table hive1 and its related 
> entities should be exported.
> 
> Problem:
> 
> hive2 is also imported which is an independently created entity and not 
> related to hive1.
> 
> Solution:
> 
> 1. Earlier, the implementation for fetchType as INCREMENTAL was getting 
> satisfied only if the value of skipLineage was "true" otherwise it was 
> implementing the default fetchType i.e FULL fetch and hence, all the 
> independently created entities in same db was also getting fetched.
> 
> 2. Now, the problem is fixed by adding additional condition which will handle 
> INCREMENTAL fetchType even if the value for skipLineage is false.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/EntitiesExtractor.java
>  da5cf37c4 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  65d7a1872 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/ExportIncrementalTest.java
>  0e3955dcd 
>   
> repository/src/test/resources/json/stocksDB-Entities/typedef-new-classification-T3.json
>  PRE-CREATION 
>   
> repository/src/test/resources/json/stocksDB-Entities/typesdef-new-classification-T2.json
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/74939/diff/4/
> 
> 
> Testing
> ---
> 
> Manual testing has been done for the same.
> 
> PC Link : 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1594/
> 
> 
> Thanks,
> 
> Priyanshi Shah
> 
>

Re: Review Request 74939: ATLAS-4842 : Export/Import: fetchType as "incremental" does full export instead of connected

2024-04-04 Thread Priyanshi Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74939/
---

(Updated April 4, 2024, 7:18 a.m.)


Review request for atlas, Jayendra Parab, Pinal Shah, and Sheetal Shah.


Bugs: ATLAS-4842
https://issues.apache.org/jira/browse/ATLAS-4842


Repository: atlas


Description
---

Steps:

create two hive_tables in same database:

1. create table hive1(id int);
2. create table hive1_ctas as select * from hive1;
3. create table hive2(name string);
4. Perform incremental export of hive1 with changeMarker as 0 and skipLineage 
value as false.
5. Import the zip.

Expectations:

a) Expectation is only the requested hive_table hive1 and its related entities 
should be exported.

Problem:

hive2 is also imported which is an independently created entity and not related 
to hive1.

Solution:

1. Earlier, the implementation for fetchType as INCREMENTAL was getting 
satisfied only if the value of skipLineage was "true" otherwise it was 
implementing the default fetchType i.e FULL fetch and hence, all the 
independently created entities in same db was also getting fetched.

2. Now, the problem is fixed by adding additional condition which will handle 
INCREMENTAL fetchType even if the value for skipLineage is false.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/impexp/EntitiesExtractor.java
 da5cf37c4 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 
65d7a1872 
  
repository/src/test/java/org/apache/atlas/repository/impexp/ExportIncrementalTest.java
 0e3955dcd 
  
repository/src/test/resources/json/stocksDB-Entities/typedef-new-classification-T3.json
 PRE-CREATION 
  
repository/src/test/resources/json/stocksDB-Entities/typesdef-new-classification-T2.json
 PRE-CREATION 


Diff: https://reviews.apache.org/r/74939/diff/4/

Changes: https://reviews.apache.org/r/74939/diff/3-4/


Testing (updated)
---

Manual testing has been done for the same.

PC Link : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1594/


Thanks,

Priyanshi Shah

Re: Review Request 74939: ATLAS-4842 : Export/Import: fetchType as "incremental" does full export instead of connected

2024-04-02 Thread Priyanshi Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74939/
---

(Updated April 2, 2024, 11:34 a.m.)


Review request for atlas, Jayendra Parab, Pinal Shah, and Sheetal Shah.


Bugs: ATLAS-4842
https://issues.apache.org/jira/browse/ATLAS-4842


Repository: atlas


Description
---

Steps:

create two hive_tables in same database:

1. create table hive1(id int);
2. create table hive1_ctas as select * from hive1;
3. create table hive2(name string);
4. Perform incremental export of hive1 with changeMarker as 0 and skipLineage 
value as false.
5. Import the zip.

Expectations:

a) Expectation is only the requested hive_table hive1 and its related entities 
should be exported.

Problem:

hive2 is also imported which is an independently created entity and not related 
to hive1.

Solution:

1. Earlier, the implementation for fetchType as INCREMENTAL was getting 
satisfied only if the value of skipLineage was "true" otherwise it was 
implementing the default fetchType i.e FULL fetch and hence, all the 
independently created entities in same db was also getting fetched.

2. Now, the problem is fixed by adding additional condition which will handle 
INCREMENTAL fetchType even if the value for skipLineage is false.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/impexp/EntitiesExtractor.java
 da5cf37c4 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 
65d7a1872 
  
repository/src/test/java/org/apache/atlas/repository/impexp/ExportIncrementalTest.java
 0e3955dcd 
  
repository/src/test/resources/json/stocksDB-Entities/typesdef-new-classification-T2.json
 PRE-CREATION 


Diff: https://reviews.apache.org/r/74939/diff/3/

Changes: https://reviews.apache.org/r/74939/diff/2-3/


Testing (updated)
---

Manual testing has been done for the same.

PC Link : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1588/


Thanks,

Priyanshi Shah

Re: Review Request 74939: ATLAS-4842 : Export/Import: fetchType as "incremental" does full export instead of connected

2024-03-28 Thread Priyanshi Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74939/
---

(Updated March 28, 2024, 12:59 p.m.)


Review request for atlas, Jayendra Parab, Pinal Shah, and Sheetal Shah.


Bugs: ATLAS-4842
https://issues.apache.org/jira/browse/ATLAS-4842


Repository: atlas


Description
---

Steps:

create two hive_tables in same database:

1. create table hive1(id int);
2. create table hive1_ctas as select * from hive1;
3. create table hive2(name string);
4. Perform incremental export of hive1 with changeMarker as 0 and skipLineage 
value as false.
5. Import the zip.

Expectations:

a) Expectation is only the requested hive_table hive1 and its related entities 
should be exported.

Problem:

hive2 is also imported which is an independently created entity and not related 
to hive1.

Solution:

1. Earlier, the implementation for fetchType as INCREMENTAL was getting 
satisfied only if the value of skipLineage was "true" otherwise it was 
implementing the default fetchType i.e FULL fetch and hence, all the 
independently created entities in same db was also getting fetched.

2. Now, the problem is fixed by adding additional condition which will handle 
INCREMENTAL fetchType even if the value for skipLineage is false.


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/impexp/EntitiesExtractor.java
 da5cf37c4 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 
65d7a1872 
  
repository/src/test/java/org/apache/atlas/repository/impexp/ExportIncrementalTest.java
 0e3955dcd 


Diff: https://reviews.apache.org/r/74939/diff/2/


Testing (updated)
---

Manual testing has been done for the same.

PC Link : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1581/


Thanks,

Priyanshi Shah

Re: Review Request 74939: ATLAS-4842 : Export/Import: fetchType as "incremental" does full export instead of connected

2024-03-28 Thread Priyanshi Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74939/
---

(Updated March 28, 2024, 12:53 p.m.)


Review request for atlas, Jayendra Parab, Pinal Shah, and Sheetal Shah.


Bugs: ATLAS-4842
https://issues.apache.org/jira/browse/ATLAS-4842


Repository: atlas


Description (updated)
---

Steps:

create two hive_tables in same database:

1. create table hive1(id int);
2. create table hive1_ctas as select * from hive1;
3. create table hive2(name string);
4. Perform incremental export of hive1 with changeMarker as 0 and skipLineage 
value as false.
5. Import the zip.

Expectations:

a) Expectation is only the requested hive_table hive1 and its related entities 
should be exported.

Problem:

hive2 is also imported which is an independently created entity and not related 
to hive1.

Solution:

1. Earlier, the implementation for fetchType as INCREMENTAL was getting 
satisfied only if the value of skipLineage was "true" otherwise it was 
implementing the default fetchType i.e FULL fetch and hence, all the 
independently created entities in same db was also getting fetched.

2. Now, the problem is fixed by adding additional condition which will handle 
INCREMENTAL fetchType even if the value for skipLineage is false.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/impexp/EntitiesExtractor.java
 da5cf37c4 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 
65d7a1872 
  
repository/src/test/java/org/apache/atlas/repository/impexp/ExportIncrementalTest.java
 0e3955dcd 


Diff: https://reviews.apache.org/r/74939/diff/2/

Changes: https://reviews.apache.org/r/74939/diff/1-2/


Testing
---

Manual testing has been done for the same.

PC Link : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1573/


Thanks,

Priyanshi Shah

Re: Review Request 74939: ATLAS-4842 : Export/Import: fetchType as "incremental" does full export instead of connected

2024-03-21 Thread Priyanshi Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74939/
---

(Updated March 21, 2024, 8:59 a.m.)


Review request for atlas, Jayendra Parab, Pinal Shah, and Sheetal Shah.


Bugs: ATLAS-4842
https://issues.apache.org/jira/browse/ATLAS-4842


Repository: atlas


Description (updated)
---

Steps:

create two hive_tables in same database:

1. create table hive1(id int);
2. create table hive2(name string);
3. Perform incremental export of hive1 with changeMarker provided by previous 
export.
4. Import the zip.

Expectations:

a) Expectation is only the requested hive_table hive1 should be exported.

Problem:

hive2 is also imported.

Solution:

1. Earlier, the implementation for fetchType as INCREMENTAL was getting 
satisfied only if the value of skipLineage was "true" otherwise it was 
implementing the default fetchType i.e FULL fetch and hence, all the unrelated 
entities was also getting fetched.

2. Now, the problem is fixed by adding additional condition which will handle 
INCREMENTAL fetchType even if the value for skipLineage is false.


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/impexp/EntitiesExtractor.java
 da5cf37c4 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 
65d7a1872 


Diff: https://reviews.apache.org/r/74939/diff/1/


Testing
---

Manual testing has been done for the same.

PC Link : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1573/


Thanks,

Priyanshi Shah

Re: Review Request 74939: ATLAS-4842 : Export/Import: fetchType as "incremental" does full export instead of connected

2024-03-20 Thread Priyanshi Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74939/
---

(Updated March 20, 2024, 12:28 p.m.)


Review request for atlas, Jayendra Parab, Pinal Shah, and Sheetal Shah.


Bugs: ATLAS-4842
https://issues.apache.org/jira/browse/ATLAS-4842


Repository: atlas


Description
---

Steps:

create two hive_tables in same database:

1. create table hive1(id int);
2. create table hive2(name string);
3. Perform incremental export of hive1 with changeMarker provided by previous 
export.
4. Import the zip.

Expectations:

a) Expectation is only the requested hive_table hive1 should be exported.

Problem:

hive2 is also imported.


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/impexp/EntitiesExtractor.java
 da5cf37c4 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 
65d7a1872 


Diff: https://reviews.apache.org/r/74939/diff/1/


Testing (updated)
---

Manual testing has been done for the same.

PC Link : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1573/


Thanks,

Priyanshi Shah

Re: Review Request 74939: ATLAS-4842 : Export/Import: fetchType as "incremental" does full export instead of connected

2024-03-19 Thread Priyanshi Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74939/
---

(Updated March 19, 2024, 9:03 a.m.)


Review request for atlas, Jayendra Parab, Pinal Shah, and Sheetal Shah.


Summary (updated)
-

ATLAS-4842 : Export/Import: fetchType as "incremental" does full export instead 
of connected


Bugs: ATLAS-4842
https://issues.apache.org/jira/browse/ATLAS-4842


Repository: atlas


Description
---

Steps:

create two hive_tables in same database:

1. create table hive1(id int);
2. create table hive2(name string);
3. Perform incremental export of hive1 with changeMarker provided by previous 
export.
4. Import the zip.

Expectations:

a) Expectation is only the requested hive_table hive1 should be exported.

Problem:

hive2 is also imported.


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/impexp/EntitiesExtractor.java
 da5cf37c4 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 
65d7a1872 


Diff: https://reviews.apache.org/r/74939/diff/1/


Testing
---

Manual testing has been done for the same.


Thanks,

Priyanshi Shah