Re: Review Request 74947: ATLAS-4838 : Export/Import : changeMarker is not set to entity's lastupdatetime or its closer timestamp value
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74947/#review226361 --- Ship it! Ship It! - Pinal Shah On March 28, 2024, 11:20 a.m., Priyanshi Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74947/ > --- > > (Updated March 28, 2024, 11:20 a.m.) > > > Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and > Sheetal Shah. > > > Bugs: ATLAS-4838 > https://issues.apache.org/jira/browse/ATLAS-4838 > > > Repository: atlas > > > Description > --- > > Steps: > > When an hive table entity is exported using fetchType incremental with > changeMarker 0 , after exporting , the changeMarker in the export response is > not set to recent timestamp. > > Problem: > > The value of changeMarker was set on the basis of the earliest request > recorded on the server. There was some unused pending requests contexts which > were not cleared after its usage and hence, changeMarker the value was > changeMarker was wrongly set. > > Solution: > > Have cleared all the unused pending requests which was found. > > > Diffs > - > > > repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java > e72a87713 > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > 0025276bb > webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java > 4c3a1c569 > webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java > ea74d21ad > > > Diff: https://reviews.apache.org/r/74947/diff/2/ > > > Testing > --- > > Performed multiple export operations with incremental fetch type, the change > marker values were updated properly on each export operation. > > PC link: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1578/ > > > Thanks, > > Priyanshi Shah > >
Re: Review Request 74947: ATLAS-4838 : Export/Import : changeMarker is not set to entity's lastupdatetime or its closer timestamp value
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74947/#review226360 --- Ship it! Ship It! - Jayendra Parab On March 28, 2024, 11:20 a.m., Priyanshi Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74947/ > --- > > (Updated March 28, 2024, 11:20 a.m.) > > > Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and > Sheetal Shah. > > > Bugs: ATLAS-4838 > https://issues.apache.org/jira/browse/ATLAS-4838 > > > Repository: atlas > > > Description > --- > > Steps: > > When an hive table entity is exported using fetchType incremental with > changeMarker 0 , after exporting , the changeMarker in the export response is > not set to recent timestamp. > > Problem: > > The value of changeMarker was set on the basis of the earliest request > recorded on the server. There was some unused pending requests contexts which > were not cleared after its usage and hence, changeMarker the value was > changeMarker was wrongly set. > > Solution: > > Have cleared all the unused pending requests which was found. > > > Diffs > - > > > repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java > e72a87713 > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > 0025276bb > webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java > 4c3a1c569 > webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java > ea74d21ad > > > Diff: https://reviews.apache.org/r/74947/diff/2/ > > > Testing > --- > > Performed multiple export operations with incremental fetch type, the change > marker values were updated properly on each export operation. > > PC link: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1578/ > > > Thanks, > > Priyanshi Shah > >
Re: Review Request 74947: ATLAS-4838 : Export/Import : changeMarker is not set to entity's lastupdatetime or its closer timestamp value
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74947/ --- (Updated March 28, 2024, 11:20 a.m.) Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and Sheetal Shah. Bugs: ATLAS-4838 https://issues.apache.org/jira/browse/ATLAS-4838 Repository: atlas Description (updated) --- Steps: When an hive table entity is exported using fetchType incremental with changeMarker 0 , after exporting , the changeMarker in the export response is not set to recent timestamp. Problem: The value of changeMarker was set on the basis of the earliest request recorded on the server. There was some unused pending requests contexts which were not cleared after its usage and hence, changeMarker the value was changeMarker was wrongly set. Solution: Have cleared all the unused pending requests which was found. Diffs - repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java e72a87713 webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 0025276bb webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 4c3a1c569 webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java ea74d21ad Diff: https://reviews.apache.org/r/74947/diff/2/ Testing (updated) --- Performed multiple export operations with incremental fetch type, the change marker values were updated properly on each export operation. PC link: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1578/ Thanks, Priyanshi Shah
Re: Review Request 74947: ATLAS-4838 : Export/Import : changeMarker is not set to entity's lastupdatetime or its closer timestamp value
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74947/ --- (Updated March 28, 2024, 4:41 a.m.) Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and Sheetal Shah. Bugs: ATLAS-4838 https://issues.apache.org/jira/browse/ATLAS-4838 Repository: atlas Description --- Steps: When an hive table entity is exported using fetchType incremental with changeMarker 0 , after exporting , the changeMarker in the export response is not set to recent timestamp. Problem: The value of changeMarker was set on the basis of the earliest request recorded on the server. There was some unused pending requests which was not cleared after its usage and hence, changeMarker the value was changeMarker was wrongly set. Solution: Have cleared all the unused pending requests which was found. Diffs (updated) - repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java e72a87713 webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 0025276bb webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 4c3a1c569 webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java ea74d21ad Diff: https://reviews.apache.org/r/74947/diff/2/ Changes: https://reviews.apache.org/r/74947/diff/1-2/ Testing (updated) --- Manual testing has been done for the same and also pre-commit got passed. PC link: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1578/ Thanks, Priyanshi Shah
