Re: Review Request 61854: ATLAS-2082: basic-search fails when in-memory filters all results from index-query
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61854/#review183630 --- Ship it! Ship It! - Sarath Subramanian On Aug. 23, 2017, 10:44 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61854/ > --- > > (Updated Aug. 23, 2017, 10:44 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-2082 > https://issues.apache.org/jira/browse/ATLAS-2082 > > > Repository: atlas > > > Description > --- > > ATLAS-2044 introduced in-memory filtering of results returnred from > index-query, to address the issue of index-query returning more results than > expected when some special characters are present in the indexed values. When > this in-memory filters all results from index-query, basis-seach sent down > empty list of vertices to subsequent graph query - which resulted in this > failure. Fixed this issue by adding is-empty checks. > > > Diffs > - > > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > 29670bc9 > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > f4ac8ab7 > > > Diff: https://reviews.apache.org/r/61854/diff/1/ > > > Testing > --- > > Verified that the search completes successfully without hitting the reported > error. > > > Thanks, > > Madhan Neethiraj > >
Re: Review Request 61854: ATLAS-2082: basic-search fails when in-memory filters all results from index-query
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61854/#review183628 --- Ship it! Ship It! - Apoorv Naik On Aug. 23, 2017, 5:44 p.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61854/ > --- > > (Updated Aug. 23, 2017, 5:44 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-2082 > https://issues.apache.org/jira/browse/ATLAS-2082 > > > Repository: atlas > > > Description > --- > > ATLAS-2044 introduced in-memory filtering of results returnred from > index-query, to address the issue of index-query returning more results than > expected when some special characters are present in the indexed values. When > this in-memory filters all results from index-query, basis-seach sent down > empty list of vertices to subsequent graph query - which resulted in this > failure. Fixed this issue by adding is-empty checks. > > > Diffs > - > > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > 29670bc9 > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > f4ac8ab7 > > > Diff: https://reviews.apache.org/r/61854/diff/1/ > > > Testing > --- > > Verified that the search completes successfully without hitting the reported > error. > > > Thanks, > > Madhan Neethiraj > >
Review Request 61854: ATLAS-2082: basic-search fails when in-memory filters all results from index-query
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61854/ --- Review request for atlas. Bugs: ATLAS-2082 https://issues.apache.org/jira/browse/ATLAS-2082 Repository: atlas Description --- ATLAS-2044 introduced in-memory filtering of results returnred from index-query, to address the issue of index-query returning more results than expected when some special characters are present in the indexed values. When this in-memory filters all results from index-query, basis-seach sent down empty list of vertices to subsequent graph query - which resulted in this failure. Fixed this issue by adding is-empty checks. Diffs - repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 29670bc9 repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java f4ac8ab7 Diff: https://reviews.apache.org/r/61854/diff/1/ Testing --- Verified that the search completes successfully without hitting the reported error. Thanks, Madhan Neethiraj
