Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65885/#review200445 --- Ship it! Ship It! - David Radley On March 28, 2018, 3:28

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

> On March 26, 2018, 1:32 p.m., David Radley wrote: > > pom.xml > > Line 673 (original), 673 (patched) > > > > > > I did a build with :"mvn clean package -Pdist" without your patch and > > it runs through

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65885/ --- (Updated March 28, 2018, 3:28 p.m.) Review request for atlas and David Radley.

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

> On March 26, 2018, 1:32 p.m., David Radley wrote: > > pom.xml > > Line 673 (original), 673 (patched) > > > > > > I did a build with :"mvn clean package -Pdist" without your patch and > > it runs through

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65885/ --- (Updated March 26, 2018, 8:07 p.m.) Review request for atlas and David Radley.

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

> On March 26, 2018, 1:32 p.m., David Radley wrote: > > pom.xml > > Line 673 (original), 673 (patched) > > > > > > I did a build with :"mvn clean package -Pdist" without your patch and > > it runs through

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

> On March 26, 2018, 1:32 p.m., David Radley wrote: > > docs/src/site/twiki/InstallationSteps.twiki > > Lines 43 (patched) > > > > > > I suggest mentioningthat you require the MANAGE_LOCAL_SOLR variable to > > be

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65885/#review199964 --- distro/src/conf/cassandra.yml.template Lines 21 (patched)

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65885/ --- (Updated March 20, 2018, 12:04 a.m.) Review request for atlas and David

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

> On March 19, 2018, 7:28 p.m., David Radley wrote: > > docs/src/site/twiki/InstallationSteps.twiki > > Lines 45 (patched) > > > > > > I built Atlas as per these instructions. I then started atlas. Atlas > > started

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

> On March 19, 2018, 7:28 p.m., David Radley wrote: > > docs/src/site/twiki/InstallationSteps.twiki > > Lines 45 (patched) > > > > > > I built Atlas as per these instructions. I then started atlas. Atlas > > started

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

> On March 19, 2018, 7:28 p.m., David Radley wrote: > > docs/src/site/twiki/InstallationSteps.twiki > > Lines 45 (patched) > > > > > > I built Atlas as per these instructions. I then started atlas. Atlas > > started

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65885/#review199456 --- docs/src/site/twiki/InstallationSteps.twiki Lines 45 (patched)

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

> On March 19, 2018, 12:31 a.m., David Radley wrote: > > distro/src/conf/atlas-application.properties > > Line 23 (original), 23 (patched) > > > > > > Sorry for the delay in reviewing. Unfortunatley the patch now

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65885/ --- (Updated March 19, 2018, 11:51 a.m.) Review request for atlas and David

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65885/#review199398 --- distro/src/conf/atlas-application.properties Line 23 (original),

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

> On March 9, 2018, 1:38 a.m., Apoorv Naik wrote: > > distro/pom.xml > > Lines 252 (patched) > > > > > > Although harmless, it's better to even avoid download if it's not > > needed. It's always a good thing to

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65885/#review198893 --- distro/pom.xml Lines 252 (patched)

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65885/ --- (Updated March 8, 2018, 6:53 p.m.) Review request for atlas and David Radley.

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65885/ --- (Updated March 8, 2018, 6:51 p.m.) Review request for atlas and David Radley.

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

> On March 8, 2018, 6:02 p.m., Apoorv Naik wrote: > > distro/pom.xml > > Lines 252 (patched) > > > > > > Looks like this will be run for all profiles, can you make this > > specific to cassandra profile ? Does it

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65885/#review198890 --- distro/pom.xml Lines 252 (patched)

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

> On March 4, 2018, 11:04 a.m., David Radley wrote: > > distro/pom.xml > > Lines 302 (patched) > > > > > > for consistency should we have as well? > > Pierre Padovani wrote: > You cannot just have cassandra

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

> On March 4, 2018, 11:07 a.m., David Radley wrote: > > My review comments are from my initial look at the code; I hope to try > > running this patch to verify it works for me > > Pierre Padovani wrote: > I'll update the patch with the above changes today or tomorrow as I have > time. >

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

> On March 4, 2018, 11:07 a.m., David Radley wrote: > > My review comments are from my initial look at the code; I hope to try > > running this patch to verify it works for me > > Pierre Padovani wrote: > I'll update the patch with the above changes today or tomorrow as I have > time. >

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

> On March 4, 2018, 11:07 a.m., David Radley wrote: > > My review comments are from my initial look at the code; I hope to try > > running this patch to verify it works for me > > Pierre Padovani wrote: > I'll update the patch with the above changes today or tomorrow as I have > time.

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

> On March 4, 2018, 11:04 a.m., David Radley wrote: > > distro/pom.xml > > Lines 258 (patched) > > > > > > I see that you are downloading Zookeeper. Many components require > > zookeeper - so it may already exist

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

> On March 4, 2018, 11:07 a.m., David Radley wrote: > > My review comments are from my initial look at the code; I hope to try > > running this patch to verify it works for me I'll update the patch with the above changes today or tomorrow as I have time. - Pierre

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65885/#review198593 --- My review comments are from my initial look at the code; I hope

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65885/#review198584 --- distro/pom.xml Lines 258 (patched)

Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65885/ --- Review request for atlas and David Radley. Bugs: ATLAS-2470