Re: Review Request 66601: ATLAS-2561: basic-search update to enable search by glossary-term

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66601/
---

(Updated April 15, 2018, 9:11 a.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Nixon 
Rodrigues, and Sarath Subramanian.


Changes
---

Updates for the review comments.


Bugs: ATLAS-2561
https://issues.apache.org/jira/browse/ATLAS-2561


Repository: atlas


Description
---

Updated basic-search API to add 'termName' as a search parameter. When 
'termName' is provided, only entities that are associated with given term will 
be returned by the search.


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 539a2252f 
  intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 
347a31493 
  repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
341a04731 
  repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 
PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ee68d63f3 


Diff: https://reviews.apache.org/r/66601/diff/2/

Changes: https://reviews.apache.org/r/66601/diff/1-2/


Testing
---

Verified the new implemenation via curl calls.


Thanks,

Madhan Neethiraj

Re: Review Request 66601: ATLAS-2561: basic-search update to enable search by glossary-term

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66601/#review201174
---


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/discovery/SearchContext.java
Lines 229 (patched)


Change AtlasEdgeDirection.OUT -> attrName.getRelationshipEdgeDirection()

Iterable edges = GraphHelper.getEdgesForLabel(glossaryTerm, 
attrName.getRelationshipEdgeLabel(), attrName.getRelationshipEdgeDirection());


- Sarath Subramanian


On April 13, 2018, 1:11 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66601/
> ---
> 
> (Updated April 13, 2018, 1:11 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Nixon 
> Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2561
> https://issues.apache.org/jira/browse/ATLAS-2561
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Updated basic-search API to add 'termName' as a search parameter. When 
> 'termName' is provided, only entities that are associated with given term 
> will be returned by the search.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java c6be3622d 
>   intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 
> 347a31493 
>   repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
> 341a04731 
>   
> repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 
> PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ee68d63f3 
> 
> 
> Diff: https://reviews.apache.org/r/66601/diff/1/
> 
> 
> Testing
> ---
> 
> Verified the new implemenation via curl calls.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Review Request 66601: ATLAS-2561: basic-search update to enable search by glossary-term

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66601/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Nixon 
Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-2561
https://issues.apache.org/jira/browse/ATLAS-2561


Repository: atlas


Description
---

Updated basic-search API to add 'termName' as a search parameter. When 
'termName' is provided, only entities that are associated with given term will 
be returned by the search.


Diffs
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java c6be3622d 
  intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 
347a31493 
  repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
341a04731 
  repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 
PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ee68d63f3 


Diff: https://reviews.apache.org/r/66601/diff/1/


Testing
---

Verified the new implemenation via curl calls.


Thanks,

Madhan Neethiraj