Re: Review Request 66626: ATLAS-2566: Model classes annotated with @AtlasJSON
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66626/#review201487
---
@Apoorv - please review the following pre-commit test failures and update the
patch to resovle these.
Failed tests:
KafkaConsumerTest.testReceive:87->assertMessagesEqual:158 Maps do not match
for key:MyTrait actual:Struct{typeName=MyTrait, values={}}
expected:Struct{typeName=MyTrait, values={}} expected [Struct{typeName=MyTrait,
values={}}] but found [Struct{typeName=MyTrait, values={}}]
HookNotificationDeserializerTest.testDeserialize:55->assertEqualMessage:138
Maps do not match for key:MyTrait actual:Struct{typeName=MyTrait, values={}}
expected:Struct{typeName=MyTrait, values={}} expected [Struct{typeName=MyTrait,
values={}}] but found [Struct{typeName=MyTrait, values={}}]
HookNotificationDeserializerTest.testDeserializeCompressedMessage:86->assertEqualMessage:138
Maps do not match for key:MyTrait actual:Struct{typeName=MyTrait, values={}}
expected:Struct{typeName=MyTrait, values={}} expected [Struct{typeName=MyTrait,
values={}}] but found [Struct{typeName=MyTrait, values={}}]
HookNotificationDeserializerTest.testDeserializeLegacyMessage:66->assertEqualMessage:138
Maps do not match for key:MyTrait actual:Struct{typeName=MyTrait, values={}}
expected:Struct{typeName=MyTrait, values={}} expected [Struct{typeName=MyTrait,
values={}}] but found [Struct{typeName=MyTrait, values={}}]
HookNotificationDeserializerTest.testDeserializeSplitMessage:101->assertEqualMessage:138
Maps do not match for key:MyTrait actual:Struct{typeName=MyTrait, values={}}
expected:Struct{typeName=MyTrait, values={}} expected [Struct{typeName=MyTrait,
values={}}] but found [Struct{typeName=MyTrait, values={}}]
Tests run: 54, Failures: 5, Errors: 0, Skipped: 0
- Madhan Neethiraj
On April 16, 2018, 3 a.m., Apoorv Naik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66626/
> ---
>
> (Updated April 16, 2018, 3 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-2566
> https://issues.apache.org/jira/browse/ATLAS-2566
>
>
> Repository: atlas
>
>
> Description
> ---
>
> Following consistent annotation strategy across all Atlas model classes.
>
>
> Diffs
> -
>
> intg/src/main/java/org/apache/atlas/model/PList.java 55239fb6c
> intg/src/main/java/org/apache/atlas/model/SearchFilter.java 62929a78d
> intg/src/main/java/org/apache/atlas/model/TimeBoundary.java 882a33c9d
> intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java
> 1045c7747
> intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java
> d274cc07e
> intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java
> 39ebf23c5
> intg/src/main/java/org/apache/atlas/model/impexp/AtlasExportRequest.java
> f50c0615b
> intg/src/main/java/org/apache/atlas/model/impexp/AtlasExportResult.java
> b12d43e2c
> intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java
> 54d6f4887
> intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportResult.java
> b97cbb3fb
> intg/src/main/java/org/apache/atlas/model/impexp/MigrationStatus.java
> 901494506
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java
> e6a7f1963
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java
> 6ad830a5d
> intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java
> ab5f145af
>
> intg/src/main/java/org/apache/atlas/model/instance/AtlasRelatedObjectId.java
> 543de61dc
> intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java
> ecccb83b3
> intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java
> 18e7407ff
>
> intg/src/main/java/org/apache/atlas/model/instance/ClassificationAssociateRequest.java
> 3f946ef7a
>
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java
> 45892629d
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java
> daf4ca88c
> intg/src/main/java/org/apache/atlas/model/instance/GuidMapping.java
> c3cec85a0
> intg/src/main/java/org/apache/atlas/model/legacy/EntityResult.java
> 52b9ec5b8
> intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java
> 27186ca7c
> intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetrics.java
> cfccc96c3
>
> intg/src/main/java/org/apache/atlas/model/notification/AtlasNotificationBaseMessage.java
> ff45d5713
>
> intg/src/main/java/org/apache/atlas/model/notification/AtlasNotificationMessage.java
> 810ba97c9
>
> intg/src/main/java/org/apache/atlas/model/notification/AtlasNotificationStringMessage.java
> bc8442785
>
> intg/sr
Re: Review Request 66626: ATLAS-2566: Model classes annotated with @AtlasJSON
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66626/ --- (Updated April 16, 2018, 3 a.m.) Review request for atlas. Changes --- Rebased on master Bugs: ATLAS-2566 https://issues.apache.org/jira/browse/ATLAS-2566 Repository: atlas Description --- Following consistent annotation strategy across all Atlas model classes. Diffs - intg/src/main/java/org/apache/atlas/model/PList.java 55239fb6c intg/src/main/java/org/apache/atlas/model/SearchFilter.java 62929a78d intg/src/main/java/org/apache/atlas/model/TimeBoundary.java 882a33c9d intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 1045c7747 intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java d274cc07e intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 347a31493 intg/src/main/java/org/apache/atlas/model/impexp/AtlasExportRequest.java f50c0615b intg/src/main/java/org/apache/atlas/model/impexp/AtlasExportResult.java b12d43e2c intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java 54d6f4887 intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportResult.java b97cbb3fb intg/src/main/java/org/apache/atlas/model/impexp/MigrationStatus.java 901494506 intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java e6a7f1963 intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 6ad830a5d intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java ab5f145af intg/src/main/java/org/apache/atlas/model/instance/AtlasRelatedObjectId.java 543de61dc intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java c133e3948 intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 18e7407ff intg/src/main/java/org/apache/atlas/model/instance/ClassificationAssociateRequest.java 3f946ef7a intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 45892629d intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java daf4ca88c intg/src/main/java/org/apache/atlas/model/instance/GuidMapping.java c3cec85a0 intg/src/main/java/org/apache/atlas/model/legacy/EntityResult.java 52b9ec5b8 intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java 27186ca7c intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetrics.java cfccc96c3 intg/src/main/java/org/apache/atlas/model/notification/AtlasNotificationBaseMessage.java ff45d5713 intg/src/main/java/org/apache/atlas/model/notification/AtlasNotificationMessage.java 810ba97c9 intg/src/main/java/org/apache/atlas/model/notification/AtlasNotificationStringMessage.java bc8442785 intg/src/main/java/org/apache/atlas/model/notification/EntityNotification.java f70eb3f00 intg/src/main/java/org/apache/atlas/model/notification/HookNotification.java 5b5fa04e2 intg/src/main/java/org/apache/atlas/model/notification/MessageVersion.java 5e1787ad0 intg/src/main/java/org/apache/atlas/model/profile/AtlasUserProfile.java fca680c74 intg/src/main/java/org/apache/atlas/model/profile/AtlasUserSavedSearch.java 36ab3b11a intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java d8e7184f1 intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java f6a692790 intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 36bb3df1f intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java c72300339 intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipDef.java 8b94b4339 intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipEndDef.java 302b879e4 intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java a4c707a91 intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java b0edcc075 intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 3634fdfd3 intg/src/main/java/org/apache/atlas/v1/model/discovery/DSLSearchResult.java 2181fca88 intg/src/main/java/org/apache/atlas/v1/model/discovery/FullTextSearchResult.java b11594814 intg/src/main/java/org/apache/atlas/v1/model/instance/AtlasSystemAttributes.java 80a91d35c intg/src/main/java/org/apache/atlas/v1/model/instance/Id.java a7b699a2f intg/src/main/java/org/apache/atlas/v1/model/instance/Referenceable.java 083db5fcf intg/src/main/java/org/apache/atlas/v1/model/instance/Struct.java c534a7612 intg/src/main/java/org/apache/atlas/v1/model/lineage/DataSetLineageResponse.java 5c035f350 intg/src/main/java/org/apache/atlas/v1/model/lineage/LineageResponse.java 78e07ad08 intg/src/main/java/org/apache/atlas/v1/model/lineage/SchemaResponse.java 46498c8c2 intg/src/main/java/org/apache/atlas/v1/model/notification/EntityNotificationV1.java 35fd7a62f intg/src/main/
Review Request 66626: ATLAS-2566: Model classes annotated with @AtlasJSON
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66626/ --- Review request for atlas. Bugs: ATLAS-2566 https://issues.apache.org/jira/browse/ATLAS-2566 Repository: atlas Description --- Following consistent annotation strategy across all Atlas model classes. Diffs - intg/src/main/java/org/apache/atlas/model/PList.java 55239fb6c intg/src/main/java/org/apache/atlas/model/SearchFilter.java 62929a78d intg/src/main/java/org/apache/atlas/model/TimeBoundary.java 882a33c9d intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 1045c7747 intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java d274cc07e intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 347a31493 intg/src/main/java/org/apache/atlas/model/impexp/AtlasExportRequest.java f50c0615b intg/src/main/java/org/apache/atlas/model/impexp/AtlasExportResult.java b12d43e2c intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java 54d6f4887 intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportResult.java b97cbb3fb intg/src/main/java/org/apache/atlas/model/impexp/MigrationStatus.java 901494506 intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java e6a7f1963 intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 6ad830a5d intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java ab5f145af intg/src/main/java/org/apache/atlas/model/instance/AtlasRelatedObjectId.java 543de61dc intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java c133e3948 intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 18e7407ff intg/src/main/java/org/apache/atlas/model/instance/ClassificationAssociateRequest.java 3f946ef7a intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 45892629d intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java daf4ca88c intg/src/main/java/org/apache/atlas/model/instance/GuidMapping.java c3cec85a0 intg/src/main/java/org/apache/atlas/model/legacy/EntityResult.java 52b9ec5b8 intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java 27186ca7c intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetrics.java cfccc96c3 intg/src/main/java/org/apache/atlas/model/notification/AtlasNotificationBaseMessage.java ff45d5713 intg/src/main/java/org/apache/atlas/model/notification/AtlasNotificationMessage.java 810ba97c9 intg/src/main/java/org/apache/atlas/model/notification/AtlasNotificationStringMessage.java bc8442785 intg/src/main/java/org/apache/atlas/model/notification/EntityNotification.java f70eb3f00 intg/src/main/java/org/apache/atlas/model/notification/HookNotification.java 5b5fa04e2 intg/src/main/java/org/apache/atlas/model/notification/MessageVersion.java 5e1787ad0 intg/src/main/java/org/apache/atlas/model/profile/AtlasUserProfile.java fca680c74 intg/src/main/java/org/apache/atlas/model/profile/AtlasUserSavedSearch.java 36ab3b11a intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java d8e7184f1 intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java f6a692790 intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 36bb3df1f intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java c72300339 intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipDef.java 8b94b4339 intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipEndDef.java 302b879e4 intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java a4c707a91 intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java b0edcc075 intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 3634fdfd3 intg/src/main/java/org/apache/atlas/v1/model/discovery/DSLSearchResult.java 2181fca88 intg/src/main/java/org/apache/atlas/v1/model/discovery/FullTextSearchResult.java b11594814 intg/src/main/java/org/apache/atlas/v1/model/instance/AtlasSystemAttributes.java 80a91d35c intg/src/main/java/org/apache/atlas/v1/model/instance/Id.java a7b699a2f intg/src/main/java/org/apache/atlas/v1/model/instance/Referenceable.java 083db5fcf intg/src/main/java/org/apache/atlas/v1/model/instance/Struct.java c534a7612 intg/src/main/java/org/apache/atlas/v1/model/lineage/DataSetLineageResponse.java 5c035f350 intg/src/main/java/org/apache/atlas/v1/model/lineage/LineageResponse.java 78e07ad08 intg/src/main/java/org/apache/atlas/v1/model/lineage/SchemaResponse.java 46498c8c2 intg/src/main/java/org/apache/atlas/v1/model/notification/EntityNotificationV1.java 35fd7a62f intg/src/main/java/org/apache/atlas/v1/model/notification/EntityNotificationV2.java a
