Re: Review Request 69190: ATLAS-2936: store and retrieve provenance type

2018-10-31 Thread Ashutosh Mestry 


> On Oct. 30, 2018, 10:11 p.m., Ashutosh Mestry wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
> > Line 73 (original), 73 (patched)
> > 
> >
> > Please revert to individual imports.
> 
> Graham Wallis wrote:
> Will do - sorry about that - I think IntelliJ aggregates them 
> automatically, although there is probably a configuration option somewhere to 
> disable it.

Press Command + , key to get 'System preferences...' dialog. Choose 'Code 
Style/Java'. Select 'Imports' tab. 

Set 'Class count to use import with '*' to a high number (15).
Set 'Names count to use static import with '*' to a high number (10).


- Ashutosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69190/#review210195
---


On Oct. 30, 2018, 3:22 p.m., Graham Wallis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69190/
> ---
> 
> (Updated Oct. 30, 2018, 3:22 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-2936: Add provenanceType system attribute
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 
> ed2ca4ce784405cdc489c951b1be5b1fc51bbd34 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> 066b0d0f424b27220ab102d3d2a04b7568790c8a 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 
> bc79dadc75ceb927747fa94f8189a540cd145bf2 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> b4189d2d1e7359b7a3c4c210438a385d124c3d74 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
>  512fff470d04bc09f4b3d52aaefcecc7816c25f1 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  c08f4c471b0a37276f2af99a32c4fc673f3811c5 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  f03262faae5889dad05bb1c635a0b17d2bdfb6f4 
> 
> 
> Diff: https://reviews.apache.org/r/69190/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with ODPi Compliance Test Suite.
> 
> 
> Thanks,
> 
> Graham Wallis
> 
>

Re: Review Request 69190: ATLAS-2936: store and retrieve provenance type

2018-10-31 Thread Graham Wallis 


> On Oct. 30, 2018, 10:11 p.m., Ashutosh Mestry wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
> > Line 73 (original), 73 (patched)
> > 
> >
> > Please revert to individual imports.

Will do - sorry about that - I think IntelliJ aggregates them automatically, 
although there is probably a configuration option somewhere to disable it.


- Graham


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69190/#review210195
---


On Oct. 30, 2018, 3:22 p.m., Graham Wallis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69190/
> ---
> 
> (Updated Oct. 30, 2018, 3:22 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-2936: Add provenanceType system attribute
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 
> ed2ca4ce784405cdc489c951b1be5b1fc51bbd34 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> 066b0d0f424b27220ab102d3d2a04b7568790c8a 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 
> bc79dadc75ceb927747fa94f8189a540cd145bf2 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> b4189d2d1e7359b7a3c4c210438a385d124c3d74 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
>  512fff470d04bc09f4b3d52aaefcecc7816c25f1 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  c08f4c471b0a37276f2af99a32c4fc673f3811c5 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  f03262faae5889dad05bb1c635a0b17d2bdfb6f4 
> 
> 
> Diff: https://reviews.apache.org/r/69190/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with ODPi Compliance Test Suite.
> 
> 
> Thanks,
> 
> Graham Wallis
> 
>

Re: Review Request 69190: ATLAS-2936: store and retrieve provenance type

2018-10-30 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69190/#review210199
---


Ship it!




Ship It!

- Sarath Subramanian


On Oct. 30, 2018, 8:22 a.m., Graham Wallis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69190/
> ---
> 
> (Updated Oct. 30, 2018, 8:22 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-2936: Add provenanceType system attribute
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 
> ed2ca4ce784405cdc489c951b1be5b1fc51bbd34 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> 066b0d0f424b27220ab102d3d2a04b7568790c8a 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 
> bc79dadc75ceb927747fa94f8189a540cd145bf2 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> b4189d2d1e7359b7a3c4c210438a385d124c3d74 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
>  512fff470d04bc09f4b3d52aaefcecc7816c25f1 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  c08f4c471b0a37276f2af99a32c4fc673f3811c5 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  f03262faae5889dad05bb1c635a0b17d2bdfb6f4 
> 
> 
> Diff: https://reviews.apache.org/r/69190/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with ODPi Compliance Test Suite.
> 
> 
> Thanks,
> 
> Graham Wallis
> 
>

Re: Review Request 69190: ATLAS-2936: store and retrieve provenance type

2018-10-30 Thread Ashutosh Mestry 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69190/#review210195
---


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
Line 73 (original), 73 (patched)


Please revert to individual imports.


- Ashutosh Mestry


On Oct. 30, 2018, 3:22 p.m., Graham Wallis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69190/
> ---
> 
> (Updated Oct. 30, 2018, 3:22 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-2936: Add provenanceType system attribute
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 
> ed2ca4ce784405cdc489c951b1be5b1fc51bbd34 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> 066b0d0f424b27220ab102d3d2a04b7568790c8a 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 
> bc79dadc75ceb927747fa94f8189a540cd145bf2 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> b4189d2d1e7359b7a3c4c210438a385d124c3d74 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
>  512fff470d04bc09f4b3d52aaefcecc7816c25f1 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  c08f4c471b0a37276f2af99a32c4fc673f3811c5 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  f03262faae5889dad05bb1c635a0b17d2bdfb6f4 
> 
> 
> Diff: https://reviews.apache.org/r/69190/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with ODPi Compliance Test Suite.
> 
> 
> Thanks,
> 
> Graham Wallis
> 
>

Review Request 69190: ATLAS-2936: store and retrieve provenance type

2018-10-30 Thread Graham Wallis 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69190/
---

Review request for atlas.


Repository: atlas


Description
---

ATLAS-2936: Add provenanceType system attribute


Diffs
-

  common/src/main/java/org/apache/atlas/repository/Constants.java 
ed2ca4ce784405cdc489c951b1be5b1fc51bbd34 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
066b0d0f424b27220ab102d3d2a04b7568790c8a 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 
bc79dadc75ceb927747fa94f8189a540cd145bf2 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
b4189d2d1e7359b7a3c4c210438a385d124c3d74 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
 512fff470d04bc09f4b3d52aaefcecc7816c25f1 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 c08f4c471b0a37276f2af99a32c4fc673f3811c5 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 f03262faae5889dad05bb1c635a0b17d2bdfb6f4 


Diff: https://reviews.apache.org/r/69190/diff/1/


Testing
---

Tested with ODPi Compliance Test Suite.


Thanks,

Graham Wallis