Re: Review Request 72446: Optimize FreeTextSearchProcessor to apply exclude deleted entity filter on solr side.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72446/ --- (Updated April 29, 2020, 10:14 a.m.) Review request for atlas, Ashutosh Mestry, Bolke de Bruin, madhan, and Sarath Subramanian. Changes --- reference to jira in description Repository: atlas Description --- Current implementation of FreeTextSearchProcessor applies filtering in memory to exclude deleted entities. This introduces significant performance overhead by generating redundant calls to solr index. The goal is to improve performance of FreeTextSearchProcessor by applying filter in solr query. Reference to jira https://issues.apache.org/jira/browse/ATLAS-3760 Diffs - repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java 92b5eb4d2 Diff: https://reviews.apache.org/r/72446/diff/1/ Testing (updated) --- Verified on our dev env and achieved 10x faster response for simple call to atlas basic search with over 50k entities. Patch applied on top of master branch. Thanks, Damian Warszawski
Re: Review Request 72446: Optimize FreeTextSearchProcessor to apply exclude deleted entity filter on solr side.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72446/ --- (Updated April 29, 2020, 10:12 a.m.) Review request for atlas, Ashutosh Mestry, Bolke de Bruin, madhan, and Sarath Subramanian. Repository: atlas Description (updated) --- Current implementation of FreeTextSearchProcessor applies filtering in memory to exclude deleted entities. This introduces significant performance overhead by generating redundant calls to solr index. The goal is to improve performance of FreeTextSearchProcessor by applying filter in solr query. Reference to jira https://issues.apache.org/jira/browse/ATLAS-3760 Diffs - repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java 92b5eb4d2 Diff: https://reviews.apache.org/r/72446/diff/1/ Testing --- Verified on our dev env and achieved 10x faster response for simple call to atlas basic search with over 50k entities. Thanks, Damian Warszawski
Re: Review Request 72446: Optimize FreeTextSearchProcessor to apply exclude deleted entity filter on solr side.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72446/#review220535 --- Ship it! @damian.warszaw...@gmail.com - the updates look good! Thanks for the patch. - Madhan Neethiraj On April 28, 2020, 9:25 p.m., Damian Warszawski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72446/ > --- > > (Updated April 28, 2020, 9:25 p.m.) > > > Review request for atlas, Ashutosh Mestry, Bolke de Bruin, madhan, and Sarath > Subramanian. > > > Repository: atlas > > > Description > --- > > Current implementation of FreeTextSearchProcessor applies filtering in memory > to exclude deleted entities. This introduces significant performance overhead > by generating redundant calls to solr index. The goal is to improve > performance of FreeTextSearchProcessor by applying filter in solr query. > > > Diffs > - > > > repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java > 92b5eb4d2 > > > Diff: https://reviews.apache.org/r/72446/diff/1/ > > > Testing > --- > > Verified on our dev env and achieved 10x faster response for simple call to > atlas basic search with over 50k entities. > > > Thanks, > > Damian Warszawski > >
Review Request 72446: Optimize FreeTextSearchProcessor to apply exclude deleted entity filter on solr side.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72446/ --- Review request for atlas and Bolke de Bruin. Repository: atlas Description --- Current implementation of FreeTextSearchProcessor applies filtering in memory to exclude deleted entities. This introduces significant performance overhead by generating redundant calls to solr index. The goal is to improve performance of FreeTextSearchProcessor by applying filter in solr query. Diffs - repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java 92b5eb4d2 Diff: https://reviews.apache.org/r/72446/diff/1/ Testing --- Verified on our dev env and achieved 10x faster response for simple call to atlas basic search with over 50k entities. Thanks, Damian Warszawski
