Re: Review Request 72729: ATLAS-3910: Use KafkaZkClient instead of ZkUtils

2020-08-25 Thread Ramesh Mani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72729/#review221707
---


Ship it!




Ship It!

- Ramesh Mani


On Aug. 11, 2020, 7:42 a.m., Viktor Somogyi-Vass wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72729/
> ---
> 
> (Updated Aug. 11, 2020, 7:42 a.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3910: Use KafkaZkClient instead of ZkUtils
> 
> 
> Diffs
> -
> 
>   
> addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java
>  40b1fee71e57175cd7ddf8a3696ef147282295c2 
>   
> addons/kafka-bridge/src/test/java/org/apache/atlas/kafka/bridge/KafkaBridgeTest.java
>  c8cc85cda1f62b2d1a0a49c61abf06d9beb6fdb7 
>   notification/src/main/java/org/apache/atlas/hook/AtlasTopicCreator.java 
> c69574103e360fcfb7dfb525bb06043a1fd647c3 
>   notification/src/test/java/org/apache/atlas/hook/AtlasTopicCreatorTest.java 
> 293784770502299875177bd4a4a9c4b32c6b5a9a 
> 
> 
> Diff: https://reviews.apache.org/r/72729/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Viktor Somogyi-Vass
> 
>

Re: Review Request 72729: ATLAS-3910: Use KafkaZkClient instead of ZkUtils

2020-08-24 Thread Viktor Somogyi-Vass 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72729/#review221686
---


Ship it!




Ship It!

- Viktor Somogyi-Vass


On Aug. 11, 2020, 7:42 a.m., Viktor Somogyi-Vass wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72729/
> ---
> 
> (Updated Aug. 11, 2020, 7:42 a.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3910: Use KafkaZkClient instead of ZkUtils
> 
> 
> Diffs
> -
> 
>   
> addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java
>  40b1fee71e57175cd7ddf8a3696ef147282295c2 
>   
> addons/kafka-bridge/src/test/java/org/apache/atlas/kafka/bridge/KafkaBridgeTest.java
>  c8cc85cda1f62b2d1a0a49c61abf06d9beb6fdb7 
>   notification/src/main/java/org/apache/atlas/hook/AtlasTopicCreator.java 
> c69574103e360fcfb7dfb525bb06043a1fd647c3 
>   notification/src/test/java/org/apache/atlas/hook/AtlasTopicCreatorTest.java 
> 293784770502299875177bd4a4a9c4b32c6b5a9a 
> 
> 
> Diff: https://reviews.apache.org/r/72729/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Viktor Somogyi-Vass
> 
>

Re: Review Request 72729: ATLAS-3910: Use KafkaZkClient instead of ZkUtils

2020-08-11 Thread Viktor Somogyi-Vass 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72729/
---

(Updated Aug. 11, 2020, 7:42 a.m.)


Review request for atlas and Madhan Neethiraj.


Repository: atlas


Description
---

ATLAS-3910: Use KafkaZkClient instead of ZkUtils


Diffs (updated)
-

  
addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java
 40b1fee71e57175cd7ddf8a3696ef147282295c2 
  
addons/kafka-bridge/src/test/java/org/apache/atlas/kafka/bridge/KafkaBridgeTest.java
 c8cc85cda1f62b2d1a0a49c61abf06d9beb6fdb7 
  notification/src/main/java/org/apache/atlas/hook/AtlasTopicCreator.java 
c69574103e360fcfb7dfb525bb06043a1fd647c3 
  notification/src/test/java/org/apache/atlas/hook/AtlasTopicCreatorTest.java 
293784770502299875177bd4a4a9c4b32c6b5a9a 


Diff: https://reviews.apache.org/r/72729/diff/2/

Changes: https://reviews.apache.org/r/72729/diff/1-2/


Testing
---


Thanks,

Viktor Somogyi-Vass

Re: Review Request 72729: ATLAS-3910: Use KafkaZkClient instead of ZkUtils

2020-08-06 Thread Ramesh Mani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72729/#review221484
---



fix it and ship it


addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java
Line 35 (original), 32 (patched)


Instead of import org.apache.commons.cli.*
please leave those import as it were.



addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java
Line 51 (original), 45 (patched)


Instead of java.util.* please leave as it was with all the import 
statements.


- Ramesh Mani


On Aug. 6, 2020, 1:50 p.m., Viktor Somogyi-Vass wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72729/
> ---
> 
> (Updated Aug. 6, 2020, 1:50 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3910: Use KafkaZkClient instead of ZkUtils
> 
> 
> Diffs
> -
> 
>   
> addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java
>  40b1fee71e57175cd7ddf8a3696ef147282295c2 
>   
> addons/kafka-bridge/src/test/java/org/apache/atlas/kafka/bridge/KafkaBridgeTest.java
>  c8cc85cda1f62b2d1a0a49c61abf06d9beb6fdb7 
>   notification/src/main/java/org/apache/atlas/hook/AtlasTopicCreator.java 
> c69574103e360fcfb7dfb525bb06043a1fd647c3 
>   notification/src/test/java/org/apache/atlas/hook/AtlasTopicCreatorTest.java 
> 293784770502299875177bd4a4a9c4b32c6b5a9a 
> 
> 
> Diff: https://reviews.apache.org/r/72729/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Viktor Somogyi-Vass
> 
>

Review Request 72729: ATLAS-3910: Use KafkaZkClient instead of ZkUtils

2020-08-04 Thread Viktor Somogyi-Vass 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72729/
---

Review request for atlas.


Repository: atlas


Description
---

ATLAS-3910: Use KafkaZkClient instead of ZkUtils


Diffs
-

  
addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java
 40b1fee71e57175cd7ddf8a3696ef147282295c2 
  
addons/kafka-bridge/src/test/java/org/apache/atlas/kafka/bridge/KafkaBridgeTest.java
 c8cc85cda1f62b2d1a0a49c61abf06d9beb6fdb7 
  notification/src/main/java/org/apache/atlas/hook/AtlasTopicCreator.java 
c69574103e360fcfb7dfb525bb06043a1fd647c3 
  notification/src/test/java/org/apache/atlas/hook/AtlasTopicCreatorTest.java 
293784770502299875177bd4a4a9c4b32c6b5a9a 


Diff: https://reviews.apache.org/r/72729/diff/1/


Testing
---


Thanks,

Viktor Somogyi-Vass