Re: Review Request 72923: ATLAS-3968 : - Refactor the typedef API authorization error message with type guid instead type name for call with guid as parameter

2020-10-01 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72923/#review221986
---


Ship it!




Ship It!

- Madhan Neethiraj


On Oct. 1, 2020, 2:37 p.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72923/
> ---
> 
> (Updated Oct. 1, 2020, 2:37 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-3968
> https://issues.apache.org/jira/browse/ATLAS-3968
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Bug details - When un-authorised reader reads a type using the guid, the 
> error message mentions about the type name instead of the guid.
> 
> This patch refactor's the typedef API authorization error message with type 
> guid instead type name for call with guid as parameter.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
>  9aa8fbcf5 
> 
> 
> Diff: https://reviews.apache.org/r/72923/diff/1/
> 
> 
> Testing
> ---
> 
> Tested typedef of all categorty API with guid and name paramter for 
> authorized and unauthorized users.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>



Review Request 72923: ATLAS-3968 : - Refactor the typedef API authorization error message with type guid instead type name for call with guid as parameter

2020-10-01 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72923/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, and Sarath 
Subramanian.


Bugs: ATLAS-3968
https://issues.apache.org/jira/browse/ATLAS-3968


Repository: atlas


Description
---

Bug details - When un-authorised reader reads a type using the guid, the error 
message mentions about the type name instead of the guid.

This patch refactor's the typedef API authorization error message with type 
guid instead type name for call with guid as parameter.


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 9aa8fbcf5 


Diff: https://reviews.apache.org/r/72923/diff/1/


Testing
---

Tested typedef of all categorty API with guid and name paramter for authorized 
and unauthorized users.


Thanks,

Nixon Rodrigues