[jira] [Commented] (ATLAS-1346) Search APIs should return empty list instead of throwing exception
[ https://issues.apache.org/jira/browse/ATLAS-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796529#comment-15796529 ] Madhan Neethiraj commented on ATLAS-1346: - +1 for the patch. Thanks [~apoorvnaik]. [~yhemanth] - thanks for the note about ATLAS-805. This patch doesn't change the transaction semantics but only avoids logging the exception to application.log. > Search APIs should return empty list instead of throwing exception > -- > > Key: ATLAS-1346 > URL: https://issues.apache.org/jira/browse/ATLAS-1346 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.8-incubating >Reporter: Apoorv Naik >Assignee: Apoorv Naik > Fix For: 0.8-incubating > > Attachments: ATLAS-1346.v1.patch > > > When the search call yields no results either return an empty list or avoid > logging the error in the logs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1346) Search APIs should return empty list instead of throwing exception
[ https://issues.apache.org/jira/browse/ATLAS-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712575#comment-15712575 ] Apoorv Naik commented on ATLAS-1346: [~yhemanth] Thanks for the clarification Hemanth. Will look into it. > Search APIs should return empty list instead of throwing exception > -- > > Key: ATLAS-1346 > URL: https://issues.apache.org/jira/browse/ATLAS-1346 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.8-incubating >Reporter: Apoorv Naik >Assignee: Apoorv Naik > Fix For: 0.8-incubating > > > Currently the APIs return a 404 when there's no result found in the > repository which causes the graph transaction to rollback, instead the search > API should return an empty list and the rest layer should translate it to a > 404 or the read-only APIs should be excluded from the GraphTransaction > interceptor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1346) Search APIs should return empty list instead of throwing exception
[ https://issues.apache.org/jira/browse/ATLAS-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15711228#comment-15711228 ] Hemanth Yamijala commented on ATLAS-1346: - A long while back, on ATLAS-805, we discovered that Titan's read only operations also could end up mutating some underlying indexes. Without proper transaction boundaries, this seemed to cause some failures for operations run after the read queries - please look at this comment in particular: https://issues.apache.org/jira/browse/ATLAS-805?focusedCommentId=15289274&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15289274 So, could you please double-check if removing transactionality is still OK? > Search APIs should return empty list instead of throwing exception > -- > > Key: ATLAS-1346 > URL: https://issues.apache.org/jira/browse/ATLAS-1346 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.8-incubating >Reporter: Apoorv Naik >Assignee: Apoorv Naik > Fix For: 0.8-incubating > > > Currently the APIs return a 404 when there's no result found in the > repository which causes the graph transaction to rollback, instead the search > API should return an empty list and the rest layer should translate it to a > 404 or the read-only APIs should be excluded from the GraphTransaction > interceptor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
