Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/ --- (Updated Sept. 27, 2016, 4:08 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/#review150510 --- Ship it! Ship It! - Madhan Neethiraj On Sept. 27, 2016, 12:2

Re: Review Request 51939: Framework to apply updates to types in the type-system

> On Sept. 20, 2016, 1:28 p.m., Suma Shivaprasad wrote: > > typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java, > > line 314 > > > > > > We would need to audit types as well to > > know

Re: Review Request 51939: Framework to apply updates to types in the type-system

> On Sept. 26, 2016, 4:43 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/services/AtlasTypePatch.java, > > line 78 > > > > > > Consider using type Map for parames. fixed in latest diff

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/ --- (Updated Sept. 26, 2016, 5:25 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/#review150489 --- repository/src/main/java/org/apache/atlas/services/AtlasTypePatch

Re: Review Request 51939: Framework to apply updates to types in the type-system

On Sept. 21, 2016, 7:46 a.m., Sarath Kumar Subramanian wrote: > > Add tests > > > > 1. Currently, the model files(like hive_model.json) are auto generated from > > model definitions defined in java(like HiveDataModelGenerator). The patch > > files in this case has to be hand coded which is err

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/ --- (Updated Sept. 26, 2016, 3:27 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/ --- (Updated Sept. 25, 2016, 11:13 p.m.) Review request for atlas, Madhan Neethiraj

Re: Review Request 51939: Framework to apply updates to types in the type-system

On Sept. 21, 2016, 2:46 p.m., Sarath Kumar Subramanian wrote: > > Add tests > > > > 1. Currently, the model files(like hive_model.json) are auto generated from > > model definitions defined in java(like HiveDataModelGenerator). The patch > > files in this case has to be hand coded which is err

Re: Review Request 51939: Framework to apply updates to types in the type-system

On Sept. 21, 2016, 2:46 p.m., Sarath Kumar Subramanian wrote: > > Add tests > > > > 1. Currently, the model files(like hive_model.json) are auto generated from > > model definitions defined in java(like HiveDataModelGenerator). The patch > > files in this case has to be hand coded which is err

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/#review150153 --- Ship it! Ship It! - Madhan Neethiraj On Sept. 23, 2016, 3:02

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/ --- (Updated Sept. 22, 2016, 8:02 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 51939: Framework to apply updates to types in the type-system

On Sept. 21, 2016, 7:46 a.m., Sarath Kumar Subramanian wrote: > > Add tests > > > > 1. Currently, the model files(like hive_model.json) are auto generated from > > model definitions defined in java(like HiveDataModelGenerator). The patch > > files in this case has to be hand coded which is err

Re: Review Request 51939: Framework to apply updates to types in the type-system

On Sept. 21, 2016, 2:46 p.m., Sarath Kumar Subramanian wrote: > > Add tests > > > > 1. Currently, the model files(like hive_model.json) are auto generated from > > model definitions defined in java(like HiveDataModelGenerator). The patch > > files in this case has to be hand coded which is err

Re: Review Request 51939: Framework to apply updates to types in the type-system

On Sept. 21, 2016, 2:46 p.m., Sarath Kumar Subramanian wrote: > > Add tests > > > > 1. Currently, the model files(like hive_model.json) are auto generated from > > model definitions defined in java(like HiveDataModelGenerator). The patch > > files in this case has to be hand coded which is err

Re: Review Request 51939: Framework to apply updates to types in the type-system

On Sept. 21, 2016, 2:46 p.m., Sarath Kumar Subramanian wrote: > > Add tests > > > > 1. Currently, the model files(like hive_model.json) are auto generated from > > model definitions defined in java(like HiveDataModelGenerator). The patch > > files in this case has to be hand coded which is err

Re: Review Request 51939: Framework to apply updates to types in the type-system

On Sept. 21, 2016, 7:46 a.m., Sarath Kumar Subramanian wrote: > > Add tests > > > > 1. Currently, the model files(like hive_model.json) are auto generated from > > model definitions defined in java(like HiveDataModelGenerator). The patch > > files in this case has to be hand coded which is err

Re: Review Request 51939: Framework to apply updates to types in the type-system

> On Sept. 21, 2016, 1:55 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/services/AtlasTypePatch.java, > > line 77 > > > > > > Consider adding attributeDefinitions as a first class attrib

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/ --- (Updated Sept. 22, 2016, 12:34 a.m.) Review request for atlas, Madhan Neethiraj

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/#review149854 --- repository/src/main/java/org/apache/atlas/services/AtlasTypeAttri

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/#review149811 --- repository/src/main/java/org/apache/atlas/services/AtlasTypeAttri

Re: Review Request 51939: Framework to apply updates to types in the type-system

> On Sept. 20, 2016, 1:11 p.m., David Radley wrote: > > It looks like this is a way of updating the versions of types using a local > > file on the Atlas server. I think we should be SaaS and expose this sort of > > functionality primarily as a REST API, otherwise this could become a > > barri

Re: Review Request 51939: Framework to apply updates to types in the type-system

> On Sept. 20, 2016, 1:11 p.m., David Radley wrote: > > It looks like this is a way of updating the versions of types using a local > > file on the Atlas server. I think we should be SaaS and expose this sort of > > functionality primarily as a REST API, otherwise this could become a > > barri

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/ --- (Updated Sept. 21, 2016, 7:51 a.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/ --- (Updated Sept. 21, 2016, 7:21 a.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/#review149727 --- typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSy

Re: Review Request 51939: Framework to apply updates to types in the type-system

> On Sept. 20, 2016, 4:15 a.m., Suma Shivaprasad wrote: > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java, > > line 191 > > > > > > it would make more sense to sort by date instead o

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/#review149703 --- typesystem/src/main/java/org/apache/atlas/typesystem/types/Hierar

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/#review149702 --- repository/src/main/java/org/apache/atlas/services/DefaultMetadat

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/#review149700 --- repository/src/main/java/org/apache/atlas/services/DefaultMetadat

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/#review149699 --- repository/src/main/java/org/apache/atlas/services/AddAttributePa

Re: Review Request 51939: Framework to apply updates to types in the type-system

> On Sept. 20, 2016, 1:11 p.m., David Radley wrote: > > It looks like this is a way of updating the versions of types using a local > > file on the Atlas server. I think we should be SaaS and expose this sort of > > functionality primarily as a REST API, otherwise this could become a > > barri

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/#review149652 --- It looks like this is a way of updating the versions of types usin

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/#review149608 --- repository/src/main/java/org/apache/atlas/services/DefaultMetadat

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/#review149607 --- repository/src/main/java/org/apache/atlas/services/AddAttributePa

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/#review149553 --- repository/src/main/java/org/apache/atlas/repository/typestore/Gr

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/#review149552 --- repository/src/main/java/org/apache/atlas/repository/typestore/Gr

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/ --- (Updated Sept. 19, 2016, 6:10 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/ --- (Updated Sept. 19, 2016, 4:56 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 51939: Framework to apply updates to types in the type-system

> On Sept. 16, 2016, 1:19 a.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/services/AtlasTypeUpdate.java, > > line 157 > > > > > > Is using JSON string the only way to update types in the

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/#review149181 --- I like the idea of introducing versions for types. I would like it

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/#review149166 --- repository/src/main/java/org/apache/atlas/services/AtlasTypeUpdat

Re: Review Request 51939: Framework to apply updates to types in the type-system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/#review149157 --- Comments from partial review. I will complete the review later tod