Re: Review Request 52257: Return system attributes in get entity definition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52257/#review156288 --- Ship it! Ship It! - Suma Shivaprasad On Nov. 18, 2016, 7:15

Re: Review Request 52257: Return system attributes in get entity definition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52257/ --- (Updated Nov. 18, 2016, 7:15 a.m.) Review request for atlas. Bugs: ATLAS-916

Re: Review Request 52257: Return system attributes in get entity definition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52257/#review156180 --- repository/src/main/java/org/apache/atlas/repository/graph/GraphH

Re: Review Request 52257: Return system attributes in get entity definition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52257/#review156176 --- repository/src/main/java/org/apache/atlas/repository/graph/GraphH

Re: Review Request 52257: Return system attributes in get entity definition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52257/ --- (Updated Nov. 16, 2016, 1:33 p.m.) Review request for atlas. Changes ---

Re: Review Request 52257: Return system attributes in get entity definition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52257/#review156026 --- Fix it, then Ship it! repository/src/main/java/org/apache/atla

Re: Review Request 52257: Return system attributes in get entity definition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52257/ --- (Updated Nov. 15, 2016, 4:33 p.m.) Review request for atlas. Bugs: ATLAS-916

Re: Review Request 52257: Return system attributes in get entity definition

> On Nov. 14, 2016, 7:49 p.m., Suma Shivaprasad wrote: > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java, > > line 161 > > > > > > do we need composite for modification tim

Re: Review Request 52257: Return system attributes in get entity definition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52257/#review155836 --- repository/src/main/java/org/apache/atlas/repository/graph/GraphB

Re: Review Request 52257: Return system attributes in get entity definition

> On Oct. 24, 2016, 10:27 p.m., Suma Shivaprasad wrote: > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java, > > line 137 > > > > > > The Index should be of String type..not

Re: Review Request 52257: Return system attributes in get entity definition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52257/ --- (Updated Nov. 14, 2016, 4:50 a.m.) Review request for atlas. Changes ---

Re: Review Request 52257: Return system attributes in get entity definition

> On Oct. 24, 2016, 11:51 p.m., Suma Shivaprasad wrote: > > repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java, > > line 188 > > > > > > can you add test for querying by these s

Re: Review Request 52257: Return system attributes in get entity definition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52257/#review153763 --- repository/src/test/java/org/apache/atlas/discovery/GraphBackedDi

Re: Review Request 52257: Return system attributes in get entity definition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52257/#review153762 --- repository/src/main/java/org/apache/atlas/repository/graph/GraphB

Re: Review Request 52257: Return system attributes in get entity definition

> On Oct. 24, 2016, 8:10 p.m., Suma Shivaprasad wrote: > > Ship It! Pls fix below comments - Suma --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52257/#review153729 -

Re: Review Request 52257: Return system attributes in get entity definition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52257/#review153749 --- repository/src/main/java/org/apache/atlas/repository/graph/GraphB

Re: Review Request 52257: Return system attributes in get entity definition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52257/#review153729 --- Ship it! Ship It! - Suma Shivaprasad On Oct. 17, 2016, 11:44

Re: Review Request 52257: Return system attributes in get entity definition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52257/ --- (Updated Oct. 17, 2016, 11:44 a.m.) Review request for atlas. Changes ---

Re: Review Request 52257: Return system attributes in get entity definition

> On Oct. 4, 2016, 6:14 p.m., Suma Shivaprasad wrote: > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java, > > line 295 > > > > > > can we add asserts in getEntityDefint

Re: Review Request 52257: Return system attributes in get entity definition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52257/#review151364 --- repository/src/main/java/org/apache/atlas/repository/graph/GraphB

Re: Review Request 52257: Return system attributes in get entity definition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52257/#review151362 --- typesystem/src/main/java/org/apache/atlas/typesystem/persistence/

Re: Review Request 52257: Return system attributes in get entity definition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52257/#review151360 --- typesystem/src/test/scala/org/apache/atlas/typesystem/json/Instan

Re: Review Request 52257: Return system attributes in get entity definition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52257/#review151357 --- repository/src/main/java/org/apache/atlas/repository/graph/GraphB

Re: Review Request 52257: Return system attributes in get entity definition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52257/ --- (Updated Oct. 4, 2016, 11:13 a.m.) Review request for atlas. Changes ---

Re: Review Request 52257: Return system attributes in get entity definition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52257/#review150656 --- repository/src/main/java/org/apache/atlas/repository/graph/GraphT