Re: Review Request 54858: Atlas-1178: Use .gitignore so git does not see binary files as changed

[David Radley]

Hi David,
I have made these changes, 
 all the best, David.



From:   David Kantor <dkan...@us.ibm.com>
To: David Kantor <dkan...@us.ibm.com>
Cc: David Radley/UK/IBM@IBMGB, Apoorv Naik <naik.apo...@gmail.com>, 
atlas <dev@atlas.incubator.apache.org>
Date:   02/02/2017 16:31
Subject:    Re: Review Request 54858: Atlas-1178: Use .gitignore so 
git does not see binary files as changed
Sent by:David Kantor <nore...@reviews.apache.org>





> On Jan. 30, 2017, 9:04 p.m., David Kantor wrote:
> > .gitignore, line 1
> > <
https://reviews.apache.org/r/54858/diff/3/?file=1604866#file1604866line1>
> >
> > Please set the bugs field to ATLAS-1378 and fix the summary to 
mention ATLAS-1378 rather than 1178.

Please set the bugs field to ATLAS-1378 and fix the summary to mention 
ATLAS-1378 rather than 1178.  Also, please close this request as 
Submitted.  To do that, go to My Dashboard, click the check box next to 
this request, and then click Close Submitted.  Thanks...


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54858/#review163570
---


On Jan. 13, 2017, 4:35 p.m., David Radley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54858/
> ---
> 
> (Updated Jan. 13, 2017, 4:35 p.m.)
> 
> 
> Review request for atlas and David Kantor.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added .gitignore files so git does not see binary files as changed. 
Atlas type system project has a strange .gitignore that I have not 
touched. I notice it contains ignores for Eclipse files, but the way we 
run it the eclipse files are not picked up by git.
> 
> 
> Diffs
> -
> 
>   .gitignore cf2ef7445407f846329b0849d23dcb0aecc4d242 
> 
> Diff: https://reviews.apache.org/r/54858/diff/
> 
> 
> Testing
> ---
> 
> git status shows no untracked changes after a compile.
> 
> 
> Thanks,
> 
> David Radley
> 
>




Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

Re: Review Request 54858: Atlas-1178: Use .gitignore so git does not see binary files as changed

[David Kantor]

> On Jan. 30, 2017, 9:04 p.m., David Kantor wrote:
> > .gitignore, line 1
> > 
> >
> > Please set the bugs field to ATLAS-1378 and fix the summary to mention 
> > ATLAS-1378 rather than 1178.

Please set the bugs field to ATLAS-1378 and fix the summary to mention 
ATLAS-1378 rather than 1178.  Also, please close this request as Submitted.  To 
do that, go to My Dashboard, click the check box next to this request, and then 
click Close Submitted.  Thanks...


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54858/#review163570
---


On Jan. 13, 2017, 4:35 p.m., David Radley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54858/
> ---
> 
> (Updated Jan. 13, 2017, 4:35 p.m.)
> 
> 
> Review request for atlas and David Kantor.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added .gitignore files so git does not see binary files as changed. Atlas 
> type system project has a strange .gitignore that I have not touched. I 
> notice it contains ignores for Eclipse files, but the way we run it the 
> eclipse files are not picked up by git.
> 
> 
> Diffs
> -
> 
>   .gitignore cf2ef7445407f846329b0849d23dcb0aecc4d242 
> 
> Diff: https://reviews.apache.org/r/54858/diff/
> 
> 
> Testing
> ---
> 
> git status shows no untracked changes after a compile.
> 
> 
> Thanks,
> 
> David Radley
> 
>

Re: Review Request 54858: Atlas-1178: Use .gitignore so git does not see binary files as changed

[David Kantor]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54858/#review163571
---


Ship it!




Ship It!

- David Kantor


On Jan. 13, 2017, 4:35 p.m., David Radley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54858/
> ---
> 
> (Updated Jan. 13, 2017, 4:35 p.m.)
> 
> 
> Review request for atlas and David Kantor.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added .gitignore files so git does not see binary files as changed. Atlas 
> type system project has a strange .gitignore that I have not touched. I 
> notice it contains ignores for Eclipse files, but the way we run it the 
> eclipse files are not picked up by git.
> 
> 
> Diffs
> -
> 
>   .gitignore cf2ef7445407f846329b0849d23dcb0aecc4d242 
> 
> Diff: https://reviews.apache.org/r/54858/diff/
> 
> 
> Testing
> ---
> 
> git status shows no untracked changes after a compile.
> 
> 
> Thanks,
> 
> David Radley
> 
>

Re: Review Request 54858: Atlas-1178: Use .gitignore so git does not see binary files as changed

[David Kantor]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54858/#review163570
---




.gitignore (line 1)


Please set the bugs field to ATLAS-1378 and fix the summary to mention 
ATLAS-1378 rather than 1178.


- David Kantor


On Jan. 13, 2017, 4:35 p.m., David Radley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54858/
> ---
> 
> (Updated Jan. 13, 2017, 4:35 p.m.)
> 
> 
> Review request for atlas and David Kantor.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added .gitignore files so git does not see binary files as changed. Atlas 
> type system project has a strange .gitignore that I have not touched. I 
> notice it contains ignores for Eclipse files, but the way we run it the 
> eclipse files are not picked up by git.
> 
> 
> Diffs
> -
> 
>   .gitignore cf2ef7445407f846329b0849d23dcb0aecc4d242 
> 
> Diff: https://reviews.apache.org/r/54858/diff/
> 
> 
> Testing
> ---
> 
> git status shows no untracked changes after a compile.
> 
> 
> Thanks,
> 
> David Radley
> 
>

Re: Review Request 54858: Atlas-1178: Use .gitignore so git does not see binary files as changed

[Apoorv Naik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54858/#review161329
---




.gitignore (line 39)


Would this not affect the distro module? All the python executables reside 
under distro/src/bin

Also which binaries are you looking to exclude ? All the bin dirs that I 
see are locate under target for each module so that should get excluded as per 
the current gitignore


- Apoorv Naik


On Jan. 4, 2017, 10:37 a.m., David Radley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54858/
> ---
> 
> (Updated Jan. 4, 2017, 10:37 a.m.)
> 
> 
> Review request for atlas and David Kantor.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added .gitignore files so git does not see binary files as changed. Atlas 
> type system project has a strange .gitignore that I have not touched. I 
> notice it contains ignores for Eclipse files, but the way we run it the 
> eclipse files are not picked up by git.
> 
> 
> Diffs
> -
> 
>   .gitignore cf2ef7445407f846329b0849d23dcb0aecc4d242 
> 
> Diff: https://reviews.apache.org/r/54858/diff/
> 
> 
> Testing
> ---
> 
> git status shows no untracked changes after a compile.
> 
> 
> Thanks,
> 
> David Radley
> 
>

Re: Review Request 54858: Atlas-1178: Use .gitignore so git does not see binary files as changed

[David Radley]

> On Jan. 3, 2017, 11:33 p.m., David Kantor wrote:
> > Rather then having separate .gitignore files in each sub-project, is it not 
> > possible to enhance the existing .gitignore file in the root project to 
> > cover this use case?

Agreed - I have made this change.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54858/#review160443
---


On Jan. 4, 2017, 10:37 a.m., David Radley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54858/
> ---
> 
> (Updated Jan. 4, 2017, 10:37 a.m.)
> 
> 
> Review request for atlas and David Kantor.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added .gitignore files so git does not see binary files as changed. Atlas 
> type system project has a strange .gitignore that I have not touched. I 
> notice it contains ignores for Eclipse files, but the way we run it the 
> eclipse files are not picked up by git.
> 
> 
> Diffs
> -
> 
>   .gitignore cf2ef7445407f846329b0849d23dcb0aecc4d242 
> 
> Diff: https://reviews.apache.org/r/54858/diff/
> 
> 
> Testing
> ---
> 
> git status shows no untracked changes after a compile.
> 
> 
> Thanks,
> 
> David Radley
> 
>

Re: Review Request 54858: Atlas-1178: Use .gitignore so git does not see binary files as changed

[David Radley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54858/
---

(Updated Jan. 4, 2017, 10:34 a.m.)


Review request for atlas and David Kantor.


Repository: atlas


Description
---

Added .gitignore files so git does not see binary files as changed. Atlas type 
system project has a strange .gitignore that I have not touched. I notice it 
contains ignores for Eclipse files, but the way we run it the eclipse files are 
not picked up by git.


Diffs
-

  addons/falcon-bridge-shim/.gitignore PRE-CREATION 
  addons/falcon-bridge/.gitignore PRE-CREATION 
  addons/hdfs-model/.gitignore PRE-CREATION 
  addons/hive-bridge-shim/.gitignore PRE-CREATION 
  addons/hive-bridge/.gitignore PRE-CREATION 
  addons/sqoop-bridge-shim/.gitignore PRE-CREATION 
  addons/sqoop-bridge/.gitignore PRE-CREATION 
  addons/storm-bridge-shim/.gitignore PRE-CREATION 
  addons/storm-bridge/.gitignore PRE-CREATION 
  authorization/.gitignore PRE-CREATION 
  catalog/.gitignore PRE-CREATION 
  client/.gitignore PRE-CREATION 
  common/.gitignore PRE-CREATION 
  graphdb/api/.gitignore PRE-CREATION 
  graphdb/common/.gitignore PRE-CREATION 
  graphdb/titan0/.gitignore PRE-CREATION 
  intg/.gitignore PRE-CREATION 
  notification/.gitignore PRE-CREATION 
  plugin-classloader/.gitignore PRE-CREATION 
  repository/.gitignore PRE-CREATION 
  server-api/.gitignore PRE-CREATION 
  shaded/hbase-client-shaded/.gitignore PRE-CREATION 
  shaded/hbase-server-shaded/.gitignore PRE-CREATION 
  webapp/.gitignore PRE-CREATION 

Diff: https://reviews.apache.org/r/54858/diff/


Testing
---

git status shows no untracked changes after a compile.


Thanks,

David Radley