Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation

2017-01-05 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54287/#review160685 --- Ship it! Ship It! - Madhan Neethiraj On Jan. 6, 2017, 6:37

Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation

2017-01-05 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54287/ --- (Updated Jan. 5, 2017, 10:37 p.m.) Review request for atlas, Apoorv Naik,

Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation

2017-01-05 Thread Sarath Subramanian
> On Jan. 5, 2017, 6:28 p.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/model/discovery/AtlasDiscoveryService.java, > > line 24 > > > > > > "org.apache.atlas.model" package does not seem a good

Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation

2017-01-05 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54287/ --- (Updated Jan. 5, 2017, 8:44 p.m.) Review request for atlas, Apoorv Naik,

Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation

2017-01-05 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54287/#review160665 --- client/src/main/java/org/apache/atlas/AtlasClient.java

Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation

2017-01-05 Thread Sarath Subramanian
> On Jan. 5, 2017, 12:37 a.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java, > > line 53 > > > > > > Would a search-result have values for fields > >

Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation

2017-01-04 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54287/ --- (Updated Jan. 4, 2017, 3:10 p.m.) Review request for atlas, Apoorv Naik,

Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation

2016-12-28 Thread Sarath Subramanian
> On Dec. 2, 2016, 2:09 a.m., Vimal Sharma wrote: > > intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java, > > line 77 > > > > > > Can we use a HashMap here so that while adding an element, we

Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation

2016-12-28 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54287/ --- (Updated Dec. 28, 2016, 2:02 p.m.) Review request for atlas, Apoorv Naik,

Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation

2016-12-06 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54287/#review158296 ---

Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation

2016-12-06 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54287/#review158295 ---

Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation

2016-12-02 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54287/ --- (Updated Dec. 2, 2016, 2:47 p.m.) Review request for atlas, Apoorv Naik,

Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation

2016-12-02 Thread Sarath Subramanian
> On Dec. 2, 2016, 2:09 a.m., Vimal Sharma wrote: > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java, > > line 154 > > > > > > Can you log this instead was debugging and forgot to

Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation

2016-12-02 Thread Sarath Subramanian
> On Dec. 2, 2016, 12:44 p.m., Apoorv Naik wrote: > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java, > > line 197 > > > > > > Any reason we're not using AtlasGraphQuery to build

Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation

2016-12-02 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54287/#review157763 ---

Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation

2016-12-02 Thread Vimal Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54287/#review157719 ---