Re: Review Request 57769: ATLAS-1671 :- Client IP is not populated for Atlas service in audit tab of Ranger

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57769/#review169465
---


Fix it, then Ship it!





authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java
Lines 168 (patched)


getRequestIpAddress() is present in Servlets.java as well. Consider 
removing Servlets.getRequestIpAddress() to avoid duplicate code.


- Madhan Neethiraj


On March 20, 2017, 9:09 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57769/
> ---
> 
> (Updated March 20, 2017, 9:09 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-1671
> https://issues.apache.org/jira/browse/ATLAS-1671
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch incudes fix in Atlas for client IP is not populated for Atlas 
> service in audit tab of Ranger.
> 
> 
> Diffs
> -
> 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java
>  377aca7 
>   
> authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java
>  1b4661e 
>   
> authorization/src/test/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizerTest.java
>  a3fc489 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 0dfdeb2 
> 
> 
> Diff: https://reviews.apache.org/r/57769/diff/1/
> 
> 
> Testing
> ---
> 
> Tested Atlas with Atlas-Ranger plugin on and client IP is recorded and shown 
> in RangerAdmin->Audit->Acess UI properly.
> Tested Atlas build and the testcases goes well.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Review Request 57769: ATLAS-1671 :- Client IP is not populated for Atlas service in audit tab of Ranger

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57769/
---

Review request for atlas, Apoorv Naik and Madhan Neethiraj.


Bugs: ATLAS-1671
https://issues.apache.org/jira/browse/ATLAS-1671


Repository: atlas


Description
---

This patch incudes fix in Atlas for client IP is not populated for Atlas 
service in audit tab of Ranger.


Diffs
-

  
authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java 
377aca7 
  
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java
 1b4661e 
  
authorization/src/test/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizerTest.java
 a3fc489 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
0dfdeb2 


Diff: https://reviews.apache.org/r/57769/diff/1/


Testing
---

Tested Atlas with Atlas-Ranger plugin on and client IP is recorded and shown in 
RangerAdmin->Audit->Acess UI properly.
Tested Atlas build and the testcases goes well.


Thanks,

Nixon Rodrigues