[jira] [Commented] (AVRO-2069) Use primitive fields in generated getters & setters in Java code

[ https://issues.apache.org/jira/browse/AVRO-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147464#comment-16147464 ] Daniil Gitelson commented on AVRO-2069: --- [~nkollar], sorry, missed them. Fixed. > Use primitive

Re: Avro schema resolution

Thanks Doug! In this case, I think in this case ResolvingGrammarGenerator doesn't implement the schema resolution logic according to the spec, created a Jira for it: https://issues.apache.org/jira/browse/AVRO-2072 What do you think about Anders comment about to int -> float promotion on

[jira] [Updated] (AVRO-2072) ResolvingGrammarGenerator doesn't implement schema resolution correctly for unions

[ https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nandor Kollar updated AVRO-2072: Attachment: AVRO-2072.patch > ResolvingGrammarGenerator doesn't implement schema resolution

[jira] [Commented] (AVRO-2072) ResolvingGrammarGenerator doesn't implement schema resolution correctly for unions

[ https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147116#comment-16147116 ] Nandor Kollar commented on AVRO-2072: - Thanks Zoltan, I'll have a look at the failing tests! >

[jira] [Comment Edited] (AVRO-2069) Use primitive fields in generated getters & setters in Java code

[ https://issues.apache.org/jira/browse/AVRO-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147129#comment-16147129 ] Nandor Kollar edited comment on AVRO-2069 at 8/30/17 12:09 PM: --- [~dguitelson]

[jira] [Commented] (AVRO-2069) Use primitive fields in generated getters & setters in Java code

[ https://issues.apache.org/jira/browse/AVRO-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147129#comment-16147129 ] Nandor Kollar commented on AVRO-2069: - [~dguitelson] looks like three test fails in

[jira] [Assigned] (AVRO-2069) Use primitive fields in generated getters & setters in Java code

[ https://issues.apache.org/jira/browse/AVRO-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nandor Kollar reassigned AVRO-2069: --- Assignee: Daniil Gitelson > Use primitive fields in generated getters & setters in Java code

[jira] [Commented] (AVRO-2072) ResolvingGrammarGenerator doesn't implement schema resolution correctly for unions

[ https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147147#comment-16147147 ] Nandor Kollar commented on AVRO-2072: - [~zolyfarkas] I don't see any test failure, guess you executed

[jira] [Commented] (AVRO-2072) ResolvingGrammarGenerator doesn't implement schema resolution correctly for unions

[ https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147229#comment-16147229 ] Zoltan Farkas commented on AVRO-2072: - I executed this against my branch... which is ahead of the

Re: [jira] [Commented] (AVRO-2072) ResolvingGrammarGenerator doesn't implement schema resolution correctly for unions

Hi Anders, Do you recall in which Jira did you add these tests? I'd like to indicate that AVRO-2072 depends on that item too. As of the compatibility and changing the spec, this should be discussed here and we should agree in the direction to follow. I'm especially interested in PMCs and

[jira] [Comment Edited] (AVRO-2072) ResolvingGrammarGenerator doesn't implement schema resolution correctly for unions

[ https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147229#comment-16147229 ] Zoltan Farkas edited comment on AVRO-2072 at 8/30/17 1:22 PM: -- I executed this

[jira] [Commented] (AVRO-2072) ResolvingGrammarGenerator doesn't implement schema resolution correctly for unions

[ https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147294#comment-16147294 ] Nandor Kollar commented on AVRO-2072: - [~zolyfarkas] I think this is fine, the test should expect float

Re: [jira] [Commented] (AVRO-2072) ResolvingGrammarGenerator doesn't implement schema resolution correctly for unions

Hi all, Thanks Nandor and others for bringing my comment up for discussuion. The failing tests were written by me, as I wanted to know how Avro really worked - and if we change the behaviour, naturally the tests should be updated as well. The question is how we should go about this, as it

[jira] [Commented] (AVRO-2072) ResolvingGrammarGenerator doesn't implement schema resolution correctly for unions

[ https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147348#comment-16147348 ] Nandor Kollar commented on AVRO-2072: - Ah okay, I think the pull request for AVRO-1931 didn't include

[jira] [Commented] (AVRO-2072) ResolvingGrammarGenerator doesn't implement schema resolution correctly for unions

[ https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147312#comment-16147312 ] Zoltan Farkas commented on AVRO-2072: - [~nkollar] Missed that part of the spec, the patch behavior is