[jira] [Commented] (AVRO-1613) Support for non-standard JSON when reading schemas
[
https://issues.apache.org/jira/browse/AVRO-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14367871#comment-14367871
]
Alfonso Nishikawa commented on AVRO-1613:
-
I don't dare to reopen the issue because I actually don't know statistics about
usage :P
I think I have been considerably conservative: nothing that used to work is
expected to fail, so I propose the patch for commit if you find it nice :)
Don't be compassionate with this patch commenting. It took me much time because
I have been thinking about it a lot, and any new idea, vision, oppinion or
review is very very much welcomed.
Thanks!
> Support for non-standard JSON when reading schemas
> --
>
> Key: AVRO-1613
> URL: https://issues.apache.org/jira/browse/AVRO-1613
> Project: Avro
> Issue Type: Wish
> Components: java
>Reporter: Alfonso Nishikawa
>Priority: Minor
> Attachments: AVRO-1613v1.patch
>
>
> It would be good to:
> * Allow unquoted field names
> * Allow single quotes
> * Allow comments
> when reading a schema. The proper extensions ([shown
> here|http://wiki.fasterxml.com/JacksonFeaturesNonStandard]) of Jackson could
> be enabled in {{Schema$Parser.parse(JsonParser)}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1613) Support for non-standard JSON when reading schemas
[
https://issues.apache.org/jira/browse/AVRO-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241943#comment-14241943
]
Ryan Blue commented on AVRO-1613:
-
I'm also not opposed. I think Doug rightly identified the question that we need
to answer: "whether folks use a given .avsc file with multiple Avro
implementations."
If you think the answer is that people don't reuse the same avsc with multiple
implementations and this is a feature that you want, then let's reopen.
> Support for non-standard JSON when reading schemas
> --
>
> Key: AVRO-1613
> URL: https://issues.apache.org/jira/browse/AVRO-1613
> Project: Avro
> Issue Type: Wish
> Components: java
>Reporter: Alfonso Nishikawa
>Priority: Minor
>
> It would be good to:
> * Allow unquoted field names
> * Allow single quotes
> * Allow comments
> when reading a schema. The proper extensions ([shown
> here|http://wiki.fasterxml.com/JacksonFeaturesNonStandard]) of Jackson could
> be enabled in {{Schema$Parser.parse(JsonParser)}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1613) Support for non-standard JSON when reading schemas
[
https://issues.apache.org/jira/browse/AVRO-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241932#comment-14241932
]
Doug Cutting commented on AVRO-1613:
I would not oppose reopening this.
> Support for non-standard JSON when reading schemas
> --
>
> Key: AVRO-1613
> URL: https://issues.apache.org/jira/browse/AVRO-1613
> Project: Avro
> Issue Type: Wish
> Components: java
>Reporter: Alfonso Nishikawa
>Priority: Minor
>
> It would be good to:
> * Allow unquoted field names
> * Allow single quotes
> * Allow comments
> when reading a schema. The proper extensions ([shown
> here|http://wiki.fasterxml.com/JacksonFeaturesNonStandard]) of Jackson could
> be enabled in {{Schema$Parser.parse(JsonParser)}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1613) Support for non-standard JSON when reading schemas
[
https://issues.apache.org/jira/browse/AVRO-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241639#comment-14241639
]
Alfonso Nishikawa commented on AVRO-1613:
-
Should we reopen the issue?
> Support for non-standard JSON when reading schemas
> --
>
> Key: AVRO-1613
> URL: https://issues.apache.org/jira/browse/AVRO-1613
> Project: Avro
> Issue Type: Wish
> Components: java
>Reporter: Alfonso Nishikawa
>Priority: Minor
>
> It would be good to:
> * Allow unquoted field names
> * Allow single quotes
> * Allow comments
> when reading a schema. The proper extensions ([shown
> here|http://wiki.fasterxml.com/JacksonFeaturesNonStandard]) of Jackson could
> be enabled in {{Schema$Parser.parse(JsonParser)}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1613) Support for non-standard JSON when reading schemas
[
https://issues.apache.org/jira/browse/AVRO-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241638#comment-14241638
]
Alfonso Nishikawa commented on AVRO-1613:
-
[~cutting], thanks! Didn't knew that comments are allowed. I only use .avsc
with java implementation and I don't have further information about usage :\
> Support for non-standard JSON when reading schemas
> --
>
> Key: AVRO-1613
> URL: https://issues.apache.org/jira/browse/AVRO-1613
> Project: Avro
> Issue Type: Wish
> Components: java
>Reporter: Alfonso Nishikawa
>Priority: Minor
>
> It would be good to:
> * Allow unquoted field names
> * Allow single quotes
> * Allow comments
> when reading a schema. The proper extensions ([shown
> here|http://wiki.fasterxml.com/JacksonFeaturesNonStandard]) of Jackson could
> be enabled in {{Schema$Parser.parse(JsonParser)}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1613) Support for non-standard JSON when reading schemas
[
https://issues.apache.org/jira/browse/AVRO-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233300#comment-14233300
]
Doug Cutting commented on AVRO-1613:
By Postel's Law we might be liberal in the JSON syntax we accept, but we should
always produce JSON that adheres closely to the standard. There is a risk that
another implementation may not be able to read a .avsc file that uses
non-standard syntax, but data files, protocol handshakes, schema repositories
etc. should always use standard syntax and thus no interoperability problems
are created there. So the question is whether folks use a given .avsc file
with multiple Avro implementations.
We do currently allow comments. Unquoted field names would make it easier to
both type-in and read hand-written schemas. I don't see significant value in
supporting single quotes.
> Support for non-standard JSON when reading schemas
> --
>
> Key: AVRO-1613
> URL: https://issues.apache.org/jira/browse/AVRO-1613
> Project: Avro
> Issue Type: Wish
> Components: java
>Reporter: Alfonso Nishikawa
>Priority: Minor
>
> It would be good to:
> * Allow unquoted field names
> * Allow single quotes
> * Allow comments
> when reading a schema. The proper extensions ([shown
> here|http://wiki.fasterxml.com/JacksonFeaturesNonStandard]) of Jackson could
> be enabled in {{Schema$Parser.parse(JsonParser)}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1613) Support for non-standard JSON when reading schemas
[
https://issues.apache.org/jira/browse/AVRO-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233189#comment-14233189
]
Ryan Blue commented on AVRO-1613:
-
Thanks for the update, Alfonso!
> Support for non-standard JSON when reading schemas
> --
>
> Key: AVRO-1613
> URL: https://issues.apache.org/jira/browse/AVRO-1613
> Project: Avro
> Issue Type: Wish
> Components: java
>Reporter: Alfonso Nishikawa
>Priority: Minor
>
> It would be good to:
> * Allow unquoted field names
> * Allow single quotes
> * Allow comments
> when reading a schema. The proper extensions ([shown
> here|http://wiki.fasterxml.com/JacksonFeaturesNonStandard]) of Jackson could
> be enabled in {{Schema$Parser.parse(JsonParser)}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1613) Support for non-standard JSON when reading schemas
[
https://issues.apache.org/jira/browse/AVRO-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232995#comment-14232995
]
Alfonso Nishikawa commented on AVRO-1613:
-
[~rdblue], no, there isn't any specification. I find your arguments much
convincing :)
It is not related to IDL, just the hassle writing a lot of quotes, but you are
right pointing the necessity of consistency between languages features.
Thank you!!
> Support for non-standard JSON when reading schemas
> --
>
> Key: AVRO-1613
> URL: https://issues.apache.org/jira/browse/AVRO-1613
> Project: Avro
> Issue Type: Wish
> Components: java
>Reporter: Alfonso Nishikawa
>Priority: Minor
>
> It would be good to:
> * Allow unquoted field names
> * Allow single quotes
> * Allow comments
> when reading a schema. The proper extensions ([shown
> here|http://wiki.fasterxml.com/JacksonFeaturesNonStandard]) of Jackson could
> be enabled in {{Schema$Parser.parse(JsonParser)}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AVRO-1613) Support for non-standard JSON when reading schemas
[
https://issues.apache.org/jira/browse/AVRO-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230165#comment-14230165
]
Ryan Blue commented on AVRO-1613:
-
Is there an extension to the JSON specification that allows these? I'd rather
not rely on a single library's behavior because the schema needs to be usable
across all of the different language implementations. That complicates rolling
out a feature like this because we would be introducing an incompatibility
while Java can read a schema that appears invalid in, say, Python. If there is
a specification for these that we can migrate to, then I think this is possible.
Also, is the motivation for this something that is addressed by
[IDL|https://avro.apache.org/docs/1.7.5/idl.html]? It seems like the motivation
here is to make it easier to write schemas by hand, but I think the JSON
representation isn't necessarily the best place to do that.
> Support for non-standard JSON when reading schemas
> --
>
> Key: AVRO-1613
> URL: https://issues.apache.org/jira/browse/AVRO-1613
> Project: Avro
> Issue Type: Wish
> Components: java
>Reporter: Alfonso Nishikawa
>Priority: Minor
>
> It would be good to:
> * Allow unquoted field names
> * Allow single quotes
> * Allow comments
> when reading a schema. The proper extensions ([shown
> here|http://wiki.fasterxml.com/JacksonFeaturesNonStandard]) of Jackson could
> be enabled in {{Schema$Parser.parse(JsonParser)}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
