[jira] [Commented] (AVRO-2649) [Java] Argument order enforced in avro-tools cli.
[
https://issues.apache.org/jira/browse/AVRO-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119613#comment-17119613
]
Hudson commented on AVRO-2649:
--
FAILURE: Integrated in Jenkins build AvroJava #894 (See
[https://builds.apache.org/job/AvroJava/894/])
[AVRO-2649] Better fix for allowing args in various orders (dkulp:
[https://github.com/apache/avro/commit/1c5e32d2b98e193ea048f8ece8ee3984c6165bfe])
* (edit)
lang/java/tools/src/main/java/org/apache/avro/tool/SpecificCompilerTool.java
> [Java] Argument order enforced in avro-tools cli.
> -
>
> Key: AVRO-2649
> URL: https://issues.apache.org/jira/browse/AVRO-2649
> Project: Apache Avro
> Issue Type: Improvement
>Affects Versions: 1.9.1
>Reporter: Ryan Skraba
>Priority: Minor
> Fix For: 1.10.0
>
>
> The following command line works:
> {code}
> $ avrotool compile -string -bigDecimal schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Input files to compile:
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc
> {code}
> Switching the first two flags causes an error:
> {code}
> $ avrotool compile -bigDecimal -string schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Expected "schema" or "protocol".
> {code}
> There's really no need to enforce a command line option order, especially for
> flags, and it's not user friendly. Most CLI tools don't. There's several
> good command line parsers to help.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2649) [Java] Argument order enforced in avro-tools cli.
[
https://issues.apache.org/jira/browse/AVRO-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119585#comment-17119585
]
ASF subversion and git services commented on AVRO-2649:
---
Commit 1c5e32d2b98e193ea048f8ece8ee3984c6165bfe in avro's branch
refs/heads/master from Daniel Kulp
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=1c5e32d ]
[AVRO-2649] Better fix for allowing args in various orders
> [Java] Argument order enforced in avro-tools cli.
> -
>
> Key: AVRO-2649
> URL: https://issues.apache.org/jira/browse/AVRO-2649
> Project: Apache Avro
> Issue Type: Improvement
>Affects Versions: 1.9.1
>Reporter: Ryan Skraba
>Priority: Minor
> Fix For: 1.10.0
>
>
> The following command line works:
> {code}
> $ avrotool compile -string -bigDecimal schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Input files to compile:
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc
> {code}
> Switching the first two flags causes an error:
> {code}
> $ avrotool compile -bigDecimal -string schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Expected "schema" or "protocol".
> {code}
> There's really no need to enforce a command line option order, especially for
> flags, and it's not user friendly. Most CLI tools don't. There's several
> good command line parsers to help.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2649) [Java] Argument order enforced in avro-tools cli.
[
https://issues.apache.org/jira/browse/AVRO-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119536#comment-17119536
]
ASF subversion and git services commented on AVRO-2649:
---
Commit 6233f475a7a26ca5e08e6d300d683accd3993bc6 in avro's branch
refs/heads/revert-741-AVRO-2649 from RyanSkraba
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=6233f47 ]
Revert "AVRO-2649 Made argument order non-enforceable avro-tools cli (#741)"
This reverts commit 7fd098a56064ece218c66ba1d2ad78bd358f6009.
> [Java] Argument order enforced in avro-tools cli.
> -
>
> Key: AVRO-2649
> URL: https://issues.apache.org/jira/browse/AVRO-2649
> Project: Apache Avro
> Issue Type: Improvement
>Affects Versions: 1.9.1
>Reporter: Ryan Skraba
>Priority: Minor
> Fix For: 1.10.0
>
>
> The following command line works:
> {code}
> $ avrotool compile -string -bigDecimal schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Input files to compile:
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc
> {code}
> Switching the first two flags causes an error:
> {code}
> $ avrotool compile -bigDecimal -string schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Expected "schema" or "protocol".
> {code}
> There's really no need to enforce a command line option order, especially for
> flags, and it's not user friendly. Most CLI tools don't. There's several
> good command line parsers to help.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2649) [Java] Argument order enforced in avro-tools cli.
[
https://issues.apache.org/jira/browse/AVRO-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117011#comment-17117011
]
Hudson commented on AVRO-2649:
--
FAILURE: Integrated in Jenkins build AvroJava #892 (See
[https://builds.apache.org/job/AvroJava/892/])
AVRO-2649 Made argument order non-enforceable avro-tools cli (#741) (github:
[https://github.com/apache/avro/commit/7fd098a56064ece218c66ba1d2ad78bd358f6009])
* (edit)
lang/java/tools/src/main/java/org/apache/avro/tool/SpecificCompilerTool.java
* (edit)
lang/java/tools/src/test/java/org/apache/avro/tool/TestSpecificCompilerTool.java
> [Java] Argument order enforced in avro-tools cli.
> -
>
> Key: AVRO-2649
> URL: https://issues.apache.org/jira/browse/AVRO-2649
> Project: Apache Avro
> Issue Type: Improvement
>Affects Versions: 1.9.1
>Reporter: Ryan Skraba
>Priority: Minor
> Fix For: 1.10.0
>
>
> The following command line works:
> {code}
> $ avrotool compile -string -bigDecimal schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Input files to compile:
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc
> {code}
> Switching the first two flags causes an error:
> {code}
> $ avrotool compile -bigDecimal -string schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Expected "schema" or "protocol".
> {code}
> There's really no need to enforce a command line option order, especially for
> flags, and it's not user friendly. Most CLI tools don't. There's several
> good command line parsers to help.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2649) [Java] Argument order enforced in avro-tools cli.
[
https://issues.apache.org/jira/browse/AVRO-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116895#comment-17116895
]
ASF subversion and git services commented on AVRO-2649:
---
Commit 7fd098a56064ece218c66ba1d2ad78bd358f6009 in avro's branch
refs/heads/master from ravowlga123
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=7fd098a ]
AVRO-2649 Made argument order non-enforceable avro-tools cli (#741)
* AVRO-2649 Made argument order non-enforceable avro-tools cli
* AVRO-2649 Dynamic index value for encoding and templatedir
* AVRO-2649 Add positionindex to save positions of flags
* AVRO-2649 Add test cases
Co-authored-by: Daniel Kulp
> [Java] Argument order enforced in avro-tools cli.
> -
>
> Key: AVRO-2649
> URL: https://issues.apache.org/jira/browse/AVRO-2649
> Project: Apache Avro
> Issue Type: Improvement
>Affects Versions: 1.9.1
>Reporter: Ryan Skraba
>Priority: Minor
>
> The following command line works:
> {code}
> $ avrotool compile -string -bigDecimal schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Input files to compile:
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc
> {code}
> Switching the first two flags causes an error:
> {code}
> $ avrotool compile -bigDecimal -string schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Expected "schema" or "protocol".
> {code}
> There's really no need to enforce a command line option order, especially for
> flags, and it's not user friendly. Most CLI tools don't. There's several
> good command line parsers to help.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2649) [Java] Argument order enforced in avro-tools cli.
[
https://issues.apache.org/jira/browse/AVRO-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116897#comment-17116897
]
ASF subversion and git services commented on AVRO-2649:
---
Commit 7fd098a56064ece218c66ba1d2ad78bd358f6009 in avro's branch
refs/heads/master from ravowlga123
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=7fd098a ]
AVRO-2649 Made argument order non-enforceable avro-tools cli (#741)
* AVRO-2649 Made argument order non-enforceable avro-tools cli
* AVRO-2649 Dynamic index value for encoding and templatedir
* AVRO-2649 Add positionindex to save positions of flags
* AVRO-2649 Add test cases
Co-authored-by: Daniel Kulp
> [Java] Argument order enforced in avro-tools cli.
> -
>
> Key: AVRO-2649
> URL: https://issues.apache.org/jira/browse/AVRO-2649
> Project: Apache Avro
> Issue Type: Improvement
>Affects Versions: 1.9.1
>Reporter: Ryan Skraba
>Priority: Minor
>
> The following command line works:
> {code}
> $ avrotool compile -string -bigDecimal schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Input files to compile:
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc
> {code}
> Switching the first two flags causes an error:
> {code}
> $ avrotool compile -bigDecimal -string schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Expected "schema" or "protocol".
> {code}
> There's really no need to enforce a command line option order, especially for
> flags, and it's not user friendly. Most CLI tools don't. There's several
> good command line parsers to help.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2649) [Java] Argument order enforced in avro-tools cli.
[
https://issues.apache.org/jira/browse/AVRO-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116898#comment-17116898
]
ASF subversion and git services commented on AVRO-2649:
---
Commit 7fd098a56064ece218c66ba1d2ad78bd358f6009 in avro's branch
refs/heads/master from ravowlga123
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=7fd098a ]
AVRO-2649 Made argument order non-enforceable avro-tools cli (#741)
* AVRO-2649 Made argument order non-enforceable avro-tools cli
* AVRO-2649 Dynamic index value for encoding and templatedir
* AVRO-2649 Add positionindex to save positions of flags
* AVRO-2649 Add test cases
Co-authored-by: Daniel Kulp
> [Java] Argument order enforced in avro-tools cli.
> -
>
> Key: AVRO-2649
> URL: https://issues.apache.org/jira/browse/AVRO-2649
> Project: Apache Avro
> Issue Type: Improvement
>Affects Versions: 1.9.1
>Reporter: Ryan Skraba
>Priority: Minor
>
> The following command line works:
> {code}
> $ avrotool compile -string -bigDecimal schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Input files to compile:
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc
> {code}
> Switching the first two flags causes an error:
> {code}
> $ avrotool compile -bigDecimal -string schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Expected "schema" or "protocol".
> {code}
> There's really no need to enforce a command line option order, especially for
> flags, and it's not user friendly. Most CLI tools don't. There's several
> good command line parsers to help.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2649) [Java] Argument order enforced in avro-tools cli.
[
https://issues.apache.org/jira/browse/AVRO-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116896#comment-17116896
]
ASF subversion and git services commented on AVRO-2649:
---
Commit 7fd098a56064ece218c66ba1d2ad78bd358f6009 in avro's branch
refs/heads/master from ravowlga123
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=7fd098a ]
AVRO-2649 Made argument order non-enforceable avro-tools cli (#741)
* AVRO-2649 Made argument order non-enforceable avro-tools cli
* AVRO-2649 Dynamic index value for encoding and templatedir
* AVRO-2649 Add positionindex to save positions of flags
* AVRO-2649 Add test cases
Co-authored-by: Daniel Kulp
> [Java] Argument order enforced in avro-tools cli.
> -
>
> Key: AVRO-2649
> URL: https://issues.apache.org/jira/browse/AVRO-2649
> Project: Apache Avro
> Issue Type: Improvement
>Affects Versions: 1.9.1
>Reporter: Ryan Skraba
>Priority: Minor
>
> The following command line works:
> {code}
> $ avrotool compile -string -bigDecimal schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Input files to compile:
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc
> {code}
> Switching the first two flags causes an error:
> {code}
> $ avrotool compile -bigDecimal -string schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Expected "schema" or "protocol".
> {code}
> There's really no need to enforce a command line option order, especially for
> flags, and it's not user friendly. Most CLI tools don't. There's several
> good command line parsers to help.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2649) [Java] Argument order enforced in avro-tools cli.
[
https://issues.apache.org/jira/browse/AVRO-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116894#comment-17116894
]
ASF subversion and git services commented on AVRO-2649:
---
Commit 7fd098a56064ece218c66ba1d2ad78bd358f6009 in avro's branch
refs/heads/master from ravowlga123
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=7fd098a ]
AVRO-2649 Made argument order non-enforceable avro-tools cli (#741)
* AVRO-2649 Made argument order non-enforceable avro-tools cli
* AVRO-2649 Dynamic index value for encoding and templatedir
* AVRO-2649 Add positionindex to save positions of flags
* AVRO-2649 Add test cases
Co-authored-by: Daniel Kulp
> [Java] Argument order enforced in avro-tools cli.
> -
>
> Key: AVRO-2649
> URL: https://issues.apache.org/jira/browse/AVRO-2649
> Project: Apache Avro
> Issue Type: Improvement
>Affects Versions: 1.9.1
>Reporter: Ryan Skraba
>Priority: Minor
>
> The following command line works:
> {code}
> $ avrotool compile -string -bigDecimal schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Input files to compile:
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc
> {code}
> Switching the first two flags causes an error:
> {code}
> $ avrotool compile -bigDecimal -string schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Expected "schema" or "protocol".
> {code}
> There's really no need to enforce a command line option order, especially for
> flags, and it's not user friendly. Most CLI tools don't. There's several
> good command line parsers to help.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2649) [Java] Argument order enforced in avro-tools cli.
[
https://issues.apache.org/jira/browse/AVRO-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16991766#comment-16991766
]
Rabi Kumar K C commented on AVRO-2649:
--
Thanks [~ryanskraba] for the reply. As I have already implemented this using
args.contains so will open a PR for this soon.
> [Java] Argument order enforced in avro-tools cli.
> -
>
> Key: AVRO-2649
> URL: https://issues.apache.org/jira/browse/AVRO-2649
> Project: Apache Avro
> Issue Type: Improvement
>Affects Versions: 1.9.1
>Reporter: Ryan Skraba
>Priority: Minor
>
> The following command line works:
> {code}
> $ avrotool compile -string -bigDecimal schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Input files to compile:
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc
> {code}
> Switching the first two flags causes an error:
> {code}
> $ avrotool compile -bigDecimal -string schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Expected "schema" or "protocol".
> {code}
> There's really no need to enforce a command line option order, especially for
> flags, and it's not user friendly. Most CLI tools don't. There's several
> good command line parsers to help.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2649) [Java] Argument order enforced in avro-tools cli.
[
https://issues.apache.org/jira/browse/AVRO-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16991758#comment-16991758
]
Ryan Skraba commented on AVRO-2649:
---
Please do (with my thanks) -- I've no objection to args.contains, and it looks
like there's already joptsimple *and* commons-cli in the avro-tools as
dependencies, so it is up to you!
> [Java] Argument order enforced in avro-tools cli.
> -
>
> Key: AVRO-2649
> URL: https://issues.apache.org/jira/browse/AVRO-2649
> Project: Apache Avro
> Issue Type: Improvement
>Affects Versions: 1.9.1
>Reporter: Ryan Skraba
>Priority: Minor
>
> The following command line works:
> {code}
> $ avrotool compile -string -bigDecimal schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Input files to compile:
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc
> {code}
> Switching the first two flags causes an error:
> {code}
> $ avrotool compile -bigDecimal -string schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Expected "schema" or "protocol".
> {code}
> There's really no need to enforce a command line option order, especially for
> flags, and it's not user friendly. Most CLI tools don't. There's several
> good command line parsers to help.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2649) [Java] Argument order enforced in avro-tools cli.
[
https://issues.apache.org/jira/browse/AVRO-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16991715#comment-16991715
]
Rabi Kumar K C commented on AVRO-2649:
--
Hi [~ryanskraba], Can I take this up? We can use args.contains in the if
condition of SpecifiCompilerTool.java however if performance is an issue then
maybe I can use parser for command line argument like: org.apache.commons.cli.
Currently, I can't assign the ticket myself please do let me know your thoughts
on this.
> [Java] Argument order enforced in avro-tools cli.
> -
>
> Key: AVRO-2649
> URL: https://issues.apache.org/jira/browse/AVRO-2649
> Project: Apache Avro
> Issue Type: Improvement
>Affects Versions: 1.9.1
>Reporter: Ryan Skraba
>Priority: Minor
>
> The following command line works:
> {code}
> $ avrotool compile -string -bigDecimal schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Input files to compile:
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc
> {code}
> Switching the first two flags causes an error:
> {code}
> $ avrotool compile -bigDecimal -string schema
> ./lang/java/tools/src/test/compiler/input/fieldtest.avsc /tmp/output
> Expected "schema" or "protocol".
> {code}
> There's really no need to enforce a command line option order, especially for
> flags, and it's not user friendly. Most CLI tools don't. There's several
> good command line parsers to help.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
