[jira] [Updated] (AVRO-2061) Improve Invalid File Format Error Message
[ https://issues.apache.org/jira/browse/AVRO-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Szadovszky updated AVRO-2061: --- Resolution: Fixed Fix Version/s: 1.9.0 Status: Resolved (was: Patch Available) > Improve Invalid File Format Error Message > - > > Key: AVRO-2061 > URL: https://issues.apache.org/jira/browse/AVRO-2061 > Project: Avro > Issue Type: Improvement > Components: java >Affects Versions: 1.9.0, 1.8.2 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Trivial > Fix For: 1.9.0 > > Attachments: AVRO-2061.1.patch, AVRO-2061.2.patch > > > {code:title=org.apache.avro.file.DataFileStream} > try { > vin.readFixed(magic); // read magic > } catch (IOException e) { > throw new IOException("Not a data file.", e); > } > if (!Arrays.equals(DataFileConstants.MAGIC, magic)) > throw new IOException("Not a data file."); > {code} > Please consider improving the error message here. I just saw a MapReduce job > fail with an IOException with the message "Not a data file." There was > definitely data files in the input directory, however, they were not Avro > files. It would have been much more helpful if it told me that. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (AVRO-2061) Improve Invalid File Format Error Message
[ https://issues.apache.org/jira/browse/AVRO-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Szadovszky updated AVRO-2061: --- Hadoop Flags: Incompatible change Release Note: Changed the message of the IOException thrown in case of a non avro file is passed for parsing. JIRA set to incompatible and added some release note (feel free to update). +1 > Improve Invalid File Format Error Message > - > > Key: AVRO-2061 > URL: https://issues.apache.org/jira/browse/AVRO-2061 > Project: Avro > Issue Type: Improvement > Components: java >Affects Versions: 1.9.0, 1.8.2 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Trivial > Attachments: AVRO-2061.1.patch, AVRO-2061.2.patch > > > {code:title=org.apache.avro.file.DataFileStream} > try { > vin.readFixed(magic); // read magic > } catch (IOException e) { > throw new IOException("Not a data file.", e); > } > if (!Arrays.equals(DataFileConstants.MAGIC, magic)) > throw new IOException("Not a data file."); > {code} > Please consider improving the error message here. I just saw a MapReduce job > fail with an IOException with the message "Not a data file." There was > definitely data files in the input directory, however, they were not Avro > files. It would have been much more helpful if it told me that. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (AVRO-2061) Improve Invalid File Format Error Message
[ https://issues.apache.org/jira/browse/AVRO-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated AVRO-2061: -- Attachment: AVRO-2061.2.patch > Improve Invalid File Format Error Message > - > > Key: AVRO-2061 > URL: https://issues.apache.org/jira/browse/AVRO-2061 > Project: Avro > Issue Type: Improvement > Components: java >Affects Versions: 1.9.0, 1.8.2 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Trivial > Attachments: AVRO-2061.1.patch, AVRO-2061.2.patch > > > {code:title=org.apache.avro.file.DataFileStream} > try { > vin.readFixed(magic); // read magic > } catch (IOException e) { > throw new IOException("Not a data file.", e); > } > if (!Arrays.equals(DataFileConstants.MAGIC, magic)) > throw new IOException("Not a data file."); > {code} > Please consider improving the error message here. I just saw a MapReduce job > fail with an IOException with the message "Not a data file." There was > definitely data files in the input directory, however, they were not Avro > files. It would have been much more helpful if it told me that. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (AVRO-2061) Improve Invalid File Format Error Message
[ https://issues.apache.org/jira/browse/AVRO-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated AVRO-2061: -- Status: Patch Available (was: Open) > Improve Invalid File Format Error Message > - > > Key: AVRO-2061 > URL: https://issues.apache.org/jira/browse/AVRO-2061 > Project: Avro > Issue Type: Improvement > Components: java >Affects Versions: 1.8.2, 1.9.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Trivial > Attachments: AVRO-2061.1.patch > > > {code:title=org.apache.avro.file.DataFileStream} > try { > vin.readFixed(magic); // read magic > } catch (IOException e) { > throw new IOException("Not a data file.", e); > } > if (!Arrays.equals(DataFileConstants.MAGIC, magic)) > throw new IOException("Not a data file."); > {code} > Please consider improving the error message here. I just saw a MapReduce job > fail with an IOException with the message "Not a data file." There was > definitely data files in the input directory, however, they were not Avro > files. It would have been much more helpful if it told me that. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (AVRO-2061) Improve Invalid File Format Error Message
[ https://issues.apache.org/jira/browse/AVRO-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated AVRO-2061: -- Attachment: AVRO-2061.1.patch > Improve Invalid File Format Error Message > - > > Key: AVRO-2061 > URL: https://issues.apache.org/jira/browse/AVRO-2061 > Project: Avro > Issue Type: Improvement > Components: java >Affects Versions: 1.9.0, 1.8.2 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Trivial > Attachments: AVRO-2061.1.patch > > > {code:title=org.apache.avro.file.DataFileStream} > try { > vin.readFixed(magic); // read magic > } catch (IOException e) { > throw new IOException("Not a data file.", e); > } > if (!Arrays.equals(DataFileConstants.MAGIC, magic)) > throw new IOException("Not a data file."); > {code} > Please consider improving the error message here. I just saw a MapReduce job > fail with an IOException with the message "Not a data file." There was > definitely data files in the input directory, however, they were not Avro > files. It would have been much more helpful if it told me that. -- This message was sent by Atlassian JIRA (v6.4.14#64029)