[jira] [Commented] (BAHIR-113) Flink Netty connector missing automated unit tests

2017-04-26 Thread shijinkui (JIRA) 

[ 
https://issues.apache.org/jira/browse/BAHIR-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986120#comment-15986120
 ] 

shijinkui commented on BAHIR-113:
-

hi， [~ckadner] 
I'll finish that ut

> Flink Netty connector missing automated unit tests
> --
>
> Key: BAHIR-113
> URL: https://issues.apache.org/jira/browse/BAHIR-113
> Project: Bahir
>  Issue Type: Test
>  Components: Flink Streaming Connectors
>Affects Versions: Flink-0.1
>Reporter: Christian Kadner
>  Labels: test
>
> The module {{flink-connector-netty}} has examples and "tests" under 
> {{src/test/scala}} yet none of those are automatically run by the Maven build 
> or [Travis CI|https://travis-ci.org/apache/bahir-flink/jobs/226167651].
> Some of the existing "tests" should be converted to 
> [ScalaTest|http://www.scalatest.org] 
> [suites|http://doc.scalatest.org/3.0.1/#org.scalatest.FunSuite]so they 
> can be executed by the Maven 
> *[Scalatest|http://www.scalatest.org/user_guide/using_the_scalatest_maven_plugin]*
>  plugin during [automated builds|https://travis-ci.org/apache/bahir-flink].
> Support for Scalatest for Bahir-Flink modules was added with 
> [BAHIR-112|https://issues.apache.org/jira/browse/BAHIR-112]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BAHIR-113) Flink Netty connector missing automated unit tests

2017-04-26 Thread Christian Kadner (JIRA) 

[ 
https://issues.apache.org/jira/browse/BAHIR-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985750#comment-15985750
 ] 

Christian Kadner commented on BAHIR-113:


Hi [~shijinkui],

since you contributed the module 
{{[flink-connector-netty|https://github.com/apache/bahir-flink/pull/7]}}, would 
you be willing to convert some of your tests to *Scalatests*?

Thanks in advance! :-)

> Flink Netty connector missing automated unit tests
> --
>
> Key: BAHIR-113
> URL: https://issues.apache.org/jira/browse/BAHIR-113
> Project: Bahir
>  Issue Type: Test
>  Components: Flink Streaming Connectors
>Affects Versions: Flink-0.1
>Reporter: Christian Kadner
>  Labels: test
>
> The module {{flink-connector-netty}} has examples and "tests" under 
> {{src/test/scala}} yet none of those are automatically run by the Maven build 
> or [Travis CI|https://travis-ci.org/apache/bahir-flink/jobs/226167651].
> Some of the existing "tests" should be converted to 
> [ScalaTest|http://www.scalatest.org] 
> [suites|http://doc.scalatest.org/3.0.1/#org.scalatest.FunSuite]so they 
> can be executed by the Maven 
> *[Scalatest|http://www.scalatest.org/user_guide/using_the_scalatest_maven_plugin]*
>  plugin during [automated builds|https://travis-ci.org/apache/bahir-flink].
> Support for Scalatest for Bahir-Flink modules was added with 
> [BAHIR-112|https://issues.apache.org/jira/browse/BAHIR-112]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)