Re: [BEAM-135] Utilities for "batching" elements in a DoFn

2017-02-09 Thread Etienne Chauchot
Hi, @JB: good to know for the roadmap! thanks @Kenn: just to be clear: the timer fires fine. What I noticed is that it seems to be SET more than once because timer.setForNowPlus in called the @ProcessElement method. I am not 100% sure of it, what I noticed is that it started to work fine

Re: Issue with Coder documentation regarding context

2017-02-09 Thread Kenneth Knowles
+1 totally agree that this is hardly documented and worth making clear. File a JIRA? Your write-up is nice, though I have a little to add: The context doesn't even really indicate whether it is nested or not; we chose the wrong name. It actually indicates whether this is the _last_ object in the

Issue with Coder documentation regarding context

2017-02-09 Thread Aviem Zur
Hi, I think improvements can be made to the documentation of `encode` and `decode` methods in `Coder`. A coder may be used to encode/decode several objects using a single stream, you cannot assume that the stream the coder encodes to/decodes from only contains bytes representing a single object.