Build failed in Jenkins: beam_Release_NightlySnapshot #649

2018-01-11 Thread Apache Jenkins Server
See Changes: [tgroh] Add RemoteGrpcPort[Read/Write] abstractions [kenn] Shade protobuf-java-util alongside protobuf-java [kenn] Remove Dataflow hack from shared translation code [lcwik] [BEAM-2863]

Re: jackson to parse options?

2018-01-11 Thread Lukasz Cwik
Robert Bradshaw had the idea of migrating away from using main(String[] args) and just refactoring the code to test the WordCount PTransform allowing one to write a traditional JUnit test that didn't call main(String[] args). This would change what the contents of our examples are and make them

[SQL] Windowing and triggering changes proposal

2018-01-11 Thread Anton Kedin
Hi, Wanted to gather feedback on changes I propose to the behavior of some aspects of windowing and triggering in Beam SQL. In short: Beam SQL currently overrides input PCollections' windowing/triggering configuration in few cases. For example if a query has a simple GROUP BY clause, we would

Re: jackson to parse options?

2018-01-11 Thread Romain Manni-Bucau
Some inputs - maybe comments? - would be appreciated on: 1. Why using json in https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/TestPipeline.java#L480 and not iterate over the options? 2. Also this is likely used to do a fromArgs and create

Re: Gradle status

2018-01-11 Thread Kenneth Knowles
On Thu, Jan 11, 2018 at 8:43 AM, Romain Manni-Bucau wrote: > 2. gradle build doesn't use the same output directory than maven so it is > not really smooth to have both and have to maintain both > I also have an opinion on this. It is useful and reasonable to be able to

Re: jackson to parse options?

2018-01-11 Thread Lukasz Cwik
1) TestPipeline#convertToArgs is meant to convert TestPipelineOptions into a String[] containing --arg=value for integration tests that only have a main(String[] arg) entry point like WordCount. There is this PR[1] that is outstanding that is attempting to clean this up and simplify it so that we

Re: Gradle status

2018-01-11 Thread Jean-Baptiste Onofré
Hi Luke, Great: let's eventually add new sub-tasks in this Jira ! Thanks ! Regards JB On 01/11/2018 07:02 PM, Lukasz Cwik wrote: The top level JIRA is here: https://issues.apache.org/jira/browse/BEAM-3249 On Thu, Jan 11, 2018 at 9:56 AM, Kenneth Knowles

Re: Gradle status

2018-01-11 Thread Romain Manni-Bucau
Ok Will try to create task from now on when seeing them Can we also put a kind of timeout for the switch to avoid an in between state lasting 6 months? Something like april? Le 11 janv. 2018 19:05, "Jean-Baptiste Onofré" a écrit : > Hi Luke, > > Great: let's eventually add

Re: Gradle status

2018-01-11 Thread Jean-Baptiste Onofré
Hi, I think we are still in the "polishing" part where Gradle is not yet fully equivalent to Maven. When Maven and Gradle will be aligned, then, we will be able to remove one. I agree that today Gradle is not yet stable/equivalent to Maven. However, that's why we have to create the

Re: jackson to parse options?

2018-01-11 Thread Lukasz Cwik
Give links to the code segments that you want background on. On Wed, Jan 10, 2018 at 12:44 AM, Romain Manni-Bucau wrote: > updated my junit 5 PR to show that: https://github.com/ > apache/beam/pull/4360/files#diff-578d1770f8b47ebbc1e74a2c19de9a6aR28 > > It doesn't remove

Re: Gradle status

2018-01-11 Thread Kenneth Knowles
The phase we are in is: "Once Gradle is able to replace Maven in a specific process (or portion thereof), Maven will no longer be maintained for said process (or portion thereof) and will be removed." Once the Gradle presubmit can replace a particular Maven presubmit, we can remove the Maven

Re: Gradle status

2018-01-11 Thread Lukasz Cwik
The top level JIRA is here: https://issues.apache.org/jira/browse/BEAM-3249 On Thu, Jan 11, 2018 at 9:56 AM, Kenneth Knowles wrote: > The phase we are in is: "Once Gradle is able to replace Maven in a > specific process (or portion thereof), Maven will no longer be maintained >

Re: jackson to parse options?

2018-01-11 Thread Romain Manni-Bucau
Hmm, here is my thought: allowing main options settings is super important and one of the most important user experience point. I d even say any IO config shouldnt be an auto value but an option and through the transform name you should be able to prefux the option name and override a particular