Re: Jenkins jobs not running for my PR 10438

2020-01-31 Thread Ismaël Mejía
done On Fri, Jan 31, 2020 at 1:51 PM Rehman Murad Ali < rehman.murad...@venturedive.com> wrote: > Hi, > > I appreciate if someone could trigger the jobs for this PR: > > https://github.com/apache/beam/pull/10627 > > *Thanks* > > *Rehman Murad Ali* > Software Engineer > Mobile: +92 3452076766 >

Re: Jenkins jobs not running for my PR 10438

2020-01-31 Thread Rehman Murad Ali
Hi, I appreciate if someone could trigger the jobs for this PR: https://github.com/apache/beam/pull/10627 *Thanks* *Rehman Murad Ali* Software Engineer Mobile: +92 3452076766 Skype: rehman.muradali On Thu, Jan 30, 2020 at 10:19 PM Luke Cwik wrote: > done > > On Thu, Jan 30, 2020 at 12:28

Re: Release 2.19.0, release candidate #1

2020-01-31 Thread Ismaël Mejía
+1 (binding) - Validated signatures - Run Python wordcount on Direct runner (from wheels) - Run Python wordcount on Flink runner with job-server image (via wheels) - Run Python wordcount on Spark runner with job-server from source (via wheels) - Validate no regressions on Nexmark for Spark

Re: Release 2.19.0, release candidate #1

2020-01-31 Thread Jean-Baptiste Onofré
+1 (binding) Checked quickly on beam-samples. Thanks, Regards JB On 30/01/2020 06:02, Boyuan Zhang wrote: > Hi everyone, > Please review and vote on the release candidate #1 for the version > 2.19.0, as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide

Re: Jenkins jobs not running for my PR 10438

2020-01-31 Thread Tomo Suzuki
HI Beam committers, Would you re-trigger the 2 failed checks in https://github.com/apache/beam/pull/10714 ? Run Java PreCommit Run Java_Examples_Dataflow PreCommit On Fri, Jan 31, 2020 at 7:51 AM Rehman Murad Ali < rehman.murad...@venturedive.com> wrote: > Hi, > > I appreciate if someone could

Re: Jenkins jobs not running for my PR 10438

2020-01-31 Thread Udi Meiri
done On Fri, Jan 31, 2020 at 9:07 AM Tomo Suzuki wrote: > HI Beam committers, > > Would you re-trigger the 2 failed checks in > https://github.com/apache/beam/pull/10714 ? > Run Java PreCommit > Run Java_Examples_Dataflow PreCommit > > > On Fri, Jan 31, 2020 at 7:51 AM Rehman Murad Ali < >

Re: Release 2.19.0, release candidate #1

2020-01-31 Thread Robert Bradshaw
+1 (binding) I validated the source tarball and all the signatures/checksums, and also tried out a Python wheel on a fresh install with some direct runner pipelines. On Fri, Jan 31, 2020 at 1:44 AM Jean-Baptiste Onofré wrote: > > +1 (binding) > > Checked quickly on beam-samples. > > Thanks, >

New contributor to Beam documentation

2020-01-31 Thread Dave Wrede
Hi all, I'm Dave and I recently started working on Dataflow documentation. In addition, I will also be spending some of my time contributing to the Beam docs, when needed. I have a strong passion for great learning experiences and welcome feedback on how we can make Beam more approachable and

Re: Release 2.19.0, release candidate #1

2020-01-31 Thread Valentyn Tymofieiev
+1. Ran 1 mobile gaming batch job and 1 streaming job on Dataflow runner under Python 3.7 using wheels. On Fri, Jan 31, 2020 at 10:13 AM Robert Bradshaw wrote: > +1 (binding) > > I validated the source tarball and all the signatures/checksums, and > also tried out a Python wheel on a fresh

Re: New contributor to Beam documentation

2020-01-31 Thread Kyle Weaver
Hi Dave, Welcome to Beam! Looking forward to working with you :) Kyle On Fri, Jan 31, 2020 at 11:17 AM Dave Wrede wrote: > Hi all, > > I'm Dave and I recently started working on Dataflow documentation. In > addition, I will also be spending some of my time contributing to the Beam > docs,

What's up with the PreCommit_Java_Examples_Dataflow_Phrase?

2020-01-31 Thread Alex Van Boxel
It seems to be in an "terminated in state UNRECOGNIZED but did not return a failure reason" https://builds.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Phrase/ _/ _/ Alex Van Boxel

Re: What's up with the PreCommit_Java_Examples_Dataflow_Phrase?

2020-01-31 Thread Luke Cwik
It has been consistently failing. Opened https://github.com/apache/beam/pull/10738 to disable and it filed BEAM-9235 On Fri, Jan 31, 2020 at 10:26 AM Alex Van Boxel wrote: > It seems to be in an "terminated in state UNRECOGNIZED but did not return > a failure reason" > >

Re: Extending the Beam IO connectors, how to best share the code

2020-01-31 Thread Luke Cwik
Since you'll handle the repository and releases, you are governed by the licenses of your dependencies one of which is Apache Beam that has an ASF 2.0 license. The ASF 2.0 license is fairly liberal as to what you can do and if you have specific questions you'll want to reach out to ASF directly

Re: New contributor to Beam documentation

2020-01-31 Thread Ahmet Altay
Welcome! On Fri, Jan 31, 2020 at 12:03 PM Kyle Weaver wrote: > Hi Dave, > > Welcome to Beam! Looking forward to working with you :) > > Kyle > > On Fri, Jan 31, 2020 at 11:17 AM Dave Wrede wrote: > >> Hi all, >> >> I'm Dave and I recently started working on Dataflow documentation. In >>

Re: [ANNOUNCE] New committer: Michał Walenia

2020-01-31 Thread Ahmet Altay
Congratulations! On Tue, Jan 28, 2020 at 9:16 PM Connell O'Callaghan wrote: > Thank you Pablo for sharing!!! > > Well done Michal!!! > > On Tue, Jan 28, 2020 at 21:07 jincheng sun > wrote: > >> Congrats Michał ! >> >> >> Hannah Jiang 于2020年1月29日 周三01:43写道: >> >>> Congrats you Michal! >>> >>>

[DISCUSSION] Improve release notes by adding a change list file

2020-01-31 Thread Ahmet Altay
Hi all, We currently have two major ways to communicate changes in a release: - A blog post, to highlight major changes in the release. (Example for 2.17: [1]) - JIRA release notes pages listing all issues tagged for a specific release. (Example for 2.17 [2]). There are a few issues with this

Re: [ANNOUNCE] New committer: Hannah Jiang

2020-01-31 Thread Ahmet Altay
Congratulations! On Wed, Jan 29, 2020 at 4:50 PM Robert Bradshaw wrote: > Congratulations, Hannah! > > On Wed, Jan 29, 2020 at 3:23 PM Chamikara Jayalath > wrote: > >> Congrats Hannah! >> >> On Wed, Jan 29, 2020 at 9:22 AM Hannah Jiang >> wrote: >> >>> Thanks everyone! >>> It is a very

Re: Extending the Beam IO connectors, how to best share the code

2020-01-31 Thread Kjetil Halvorsen
Hi, Having our own repository and release process is probably the easiest to start with? We still have a lot of changes entering the code base as we mature the connectors to their "v1" state. Medium/longer term, we'd be happy to contribute the connectors to Beam (given that it doesn't interfere

Re: What's up with the PreCommit_Java_Examples_Dataflow_Phrase?

2020-01-31 Thread Luke Cwik
Your right, it looks like it recovered this morning. On Fri, Jan 31, 2020 at 1:44 PM Luke Cwik wrote: > It has been consistently failing. Opened > https://github.com/apache/beam/pull/10738 to disable and it filed > BEAM-9235 > > On Fri, Jan 31, 2020 at 10:26 AM Alex Van Boxel wrote: > >> It

Re: [DISCUSSION] Improve release notes by adding a change list file

2020-01-31 Thread Kenneth Knowles
+1 This is a great idea. Hope it can lead to higher-value view of relevant changes. I like it being in the root of the repo, so it lives next to the code. Since the website is also markdown, it could be copied over directly at release time, so it can be browsed there, too. Kenn On Fri, Jan

Re: [DISCUSSION] Improve release notes by adding a change list file

2020-01-31 Thread Robert Bradshaw
Yes, yes, yes! This is the one model of release notes that I've actually seen work well at scale. https://lists.apache.org/thread.html/41e03ace17dbcccf7e267ba6d538736b2a99a8e73e7fb45702766b17%40%3Cdev.beam.apache.org%3E Let's make it happen. On Fri, Jan 31, 2020 at 3:47 PM Robert Burke wrote:

Re: [DISCUSSION] Improve release notes by adding a change list file

2020-01-31 Thread Ahmet Altay
Thank you for the quick responses. I sent out https://github.com/apache/beam/pull/10743 to make this change. Please provide feedback or directly edit the PR. On Fri, Jan 31, 2020 at 3:58 PM Robert Bradshaw wrote: > Yes, yes, yes! This is the one model of release notes that I've > actually seen

Re: [DISCUSSION] Improve release notes by adding a change list file

2020-01-31 Thread Robert Burke
I like this suggestion, Jira titles and commit summaries don't necessarily reflect the user impact for a given change (or set of changes). Being able to see the Forest instead of the trees. On Fri, Jan 31, 2020, 3:37 PM Kenneth Knowles wrote: > +1 > > This is a great idea. Hope it can lead to

Re: [DISCUSS] BIP reloaded

2020-01-31 Thread Kenneth Knowles
These stages sound like a great starting point to me. Would you be the volunteer to set up a cwiki page for BIPs? Kenn On Mon, Jan 20, 2020 at 3:30 AM Jan Lukavský wrote: > I agree that we can take inspiration from other projects. Besides the > organizational part (what should be part of BIP,