Re: [VOTE] Release 2.23.0, release candidate #1

Seems the performance mystery regression is now clear due to Damian investigation. So everything looks good in the Nexmark side. Now that I re read this thread I may have taken the comment out of context Valentyn, my point is that we as a community need consensus for releases too, not only rules.

Re: [VOTE] Release 2.23.0, release candidate #1

I do not reproduce the Nexmark regression locally with A/B testing on different commits, and I believe it is not blocking the release. A possible reason for the change in Nexmark performance is migration to Jenkins CI, see [1] for details. I will proceed with creating & publishing RC2 artifacts

Re: [VOTE] Release 2.23.0, release candidate #1

> RCs are the point when we expect people to > discover and test features, that's the whole point of RCs otherwise we will > release as it is, so they are the perfect moment to fix issues, in particular if > during the RC tests we discover that new features produce unexpected > regressions,

Re: [VOTE] Release 2.23.0, release candidate #1

> As a general rule, fixes pertaining to new functionality are not a good > candidate for a cherry-pick. I disagree with this statement, RCs are the point when we expect people to discover and test features, that's the whole point of RCs otherwise we will release as it is, so they are the perfect

Re: [VOTE] Release 2.23.0, release candidate #1

On Mon, Jul 20, 2020 at 1:20 PM Kenneth Knowles wrote: > Agree. Great management of this release discussion. > > While I think Robert laid out the reasons for avoiding cherry picks very > clearly, I just want to emphasize that it is *not* appropriate to treat > every cherry pick according to

Re: [VOTE] Release 2.23.0, release candidate #1

Agree. Great management of this release discussion. While I think Robert laid out the reasons for avoiding cherry picks very clearly, I just want to emphasize that it is *not* appropriate to treat every cherry pick according to risk/reward* which ignores the policy. The reasons for following a

Re: [VOTE] Release 2.23.0, release candidate #1

@Valentyn: Thank you for your transparency in the release process and for considering pending cherry-pick requests. No blockers from my side. -Max On 18.07.20 01:11, Ahmet Altay wrote: Thank you Valentyn. Being a release manager is difficult. It requires balancing between stability, following

Re: [VOTE] Release 2.23.0, release candidate #1

Thank you Valentyn. Being a release manager is difficult. It requires balancing between stability, following the process, regressions, timelines. Thank you for following the process, thank you for asking the right questions, thank you for doing the release. On Fri, Jul 17, 2020 at 3:59 PM Robert

Re: [VOTE] Release 2.23.0, release candidate #1

Thank you, Valentyn! On Fri, Jul 17, 2020 at 3:25 PM Chamikara Jayalath wrote: > > > > On Fri, Jul 17, 2020 at 3:01 PM Valentyn Tymofieiev > wrote: >> >> As a general rule, fixes pertaining to new functionality are not a good >> candidate for a cherry-pick. >> >> A case for an exception can

Re: [VOTE] Release 2.23.0, release candidate #1

On Fri, Jul 17, 2020 at 3:01 PM Valentyn Tymofieiev wrote: > As a general rule, fixes pertaining to new functionality are not a good > candidate for a cherry-pick. > > A case for an exception can be made for polishing features related to > major wide announcements with a hard deadline, which

Re: [VOTE] Release 2.23.0, release candidate #1

As a general rule, fixes pertaining to new functionality are not a good candidate for a cherry-pick. A case for an exception can be made for polishing features related to major wide announcements with a hard deadline, which appears to be the case for xlang on Dataflow. I will prepare an RC2 with

Re: [VOTE] Release 2.23.0, release candidate #1

On Fri, Jul 17, 2020 at 10:01 AM Robert Bradshaw wrote: > Taking a step back, the goal of avoiding cherry-picks is to reduce > risk and increase the velocity of our releases, as otherwise the > release manager gets inundated by a never ending list of features > people want to get in that puts

Re: [VOTE] Release 2.23.0, release candidate #1

Taking a step back, the goal of avoiding cherry-picks is to reduce risk and increase the velocity of our releases, as otherwise the release manager gets inundated by a never ending list of features people want to get in that puts the releases further and further behind (increasing the desire to

Re: [VOTE] Release 2.23.0, release candidate #1

On Thu, Jul 16, 2020 at 7:46 PM Chamikara Jayalath wrote: > > > On Thu, Jul 16, 2020 at 7:28 PM Valentyn Tymofieiev > wrote: > >> >> >> On Thu, Jul 16, 2020, 19:07 Chamikara Jayalath >> wrote: >> >>> >>> >>> On Thu, Jul 16, 2020 at 6:16 PM Valentyn Tymofieiev >>> wrote: >>> Thanks for

Re: [VOTE] Release 2.23.0, release candidate #1

On Thu, Jul 16, 2020 at 7:28 PM Valentyn Tymofieiev wrote: > > > On Thu, Jul 16, 2020, 19:07 Chamikara Jayalath > wrote: > >> >> >> On Thu, Jul 16, 2020 at 6:16 PM Valentyn Tymofieiev >> wrote: >> >>> Thanks for the feedback, help with release validation, and for reaching >>> out on dev@

Re: [VOTE] Release 2.23.0, release candidate #1

On Thu, Jul 16, 2020, 19:07 Chamikara Jayalath wrote: > > > On Thu, Jul 16, 2020 at 6:16 PM Valentyn Tymofieiev > wrote: > >> Thanks for the feedback, help with release validation, and for reaching >> out on dev@ regarding a cherry-pick request. >> >> BEAM-10397

Re: [VOTE] Release 2.23.0, release candidate #1

On Thu, Jul 16, 2020 at 6:16 PM Valentyn Tymofieiev wrote: > Thanks for the feedback, help with release validation, and for reaching > out on dev@ regarding a cherry-pick request. > > BEAM-10397 pertains to > new functionality (xlang support on

Re: [VOTE] Release 2.23.0, release candidate #1

Hi, Are there strong objections to the ability to do patches? Cheers Reza On Fri, Jul 17, 2020 at 9:16 AM Valentyn Tymofieiev wrote: > Thanks for the feedback, help with release validation, and for reaching > out on dev@ regarding a cherry-pick request. > > BEAM-10397

Re: [VOTE] Release 2.23.0, release candidate #1

Thanks for the feedback, help with release validation, and for reaching out on dev@ regarding a cherry-pick request. BEAM-10397 pertains to new functionality (xlang support on Dataflow). Are there any reasons that this fix cannot wait until

Re: [VOTE] Release 2.23.0, release candidate #1

I agree. I think Dataflow x-lang users could run into flaky pipelines due to this. Valentyn, are you OK with creating a new RC that includes the fix (already merged - https://github.com/apache/beam/pull/12164) and preferably https://github.com/apache/beam/pull/12196 ? Thanks, Cham On Wed, Jul

Re: [VOTE] Release 2.23.0, release candidate #1

I think we need to cherry-pick https://issues.apache.org/jira/browse/BEAM-10397 which fixes missing environment errors for Dataflow xlang pipelines. Internally, we have a flaky xlang kafkaio test because of missing environment errors and any xlang pipelines using GroupByKey could encounter this.

Re: [VOTE] Release 2.23.0, release candidate #1

On Wed, Jul 15, 2020 at 4:55 PM Robert Bradshaw wrote: > All the artifacts, signatures, and hashes look good. > > I would like to understand the severity of > https://issues.apache.org/jira/browse/BEAM-10397 before giving my > vote. > +Heejong Lee to comment on this. > > On Wed, Jul 15, 2020

Re: [VOTE] Release 2.23.0, release candidate #1

All the artifacts, signatures, and hashes look good. I would like to understand the severity of https://issues.apache.org/jira/browse/BEAM-10397 before giving my vote. On Wed, Jul 15, 2020 at 10:51 AM Pablo Estrada wrote: > > +1 > I was able to run the python 3.8 quickstart from wheels on

Re: [VOTE] Release 2.23.0, release candidate #1

+1 I was able to run the python 3.8 quickstart from wheels on DirectRunner. I verified hashes for Python files. -P. On Fri, Jul 10, 2020 at 4:34 PM Ahmet Altay wrote: > I validated the python 3 quickstarts. I had issues with running > with python 3.8 wheel files, but did not have issues with

Re: [VOTE] Release 2.23.0, release candidate #1

+1. Thanks. Tried several Python batch examples and a streaming pipeline with x-lang Kafka with Dataflow. - Cham On Fri, Jul 10, 2020 at 4:34 PM Ahmet Altay wrote: > I validated the python 3 quickstarts. I had issues with running > with python 3.8 wheel files, but did not have issues with

Re: [VOTE] Release 2.23.0, release candidate #1

I validated the python 3 quickstarts. I had issues with running with python 3.8 wheel files, but did not have issues with source distributions, or other python wheel files. I have not tested python 2 quickstarts. On Thu, Jul 9, 2020 at 10:53 PM Valentyn Tymofieiev wrote: > Hi everyone, > >

[VOTE] Release 2.23.0, release candidate #1

Hi everyone, Please review and vote on the release candidate #1 for the version 2.23.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1],