Re: Pipeline upgrade to 2.55.0-SNAPSHOT broken for FlinkRunner

2024-02-22 Thread Robert Bradshaw via dev
On Wed, Feb 21, 2024 at 11:58 PM Jan Lukavský wrote: > > Reasons we use Java serialization are not fundamental, probably only > historical. Thinking about it, yes, there is lucky coincidence that we > currently have to change the serialization because of Flink 1.17 support. > Flink 1.17

Re: Pipeline upgrade to 2.55.0-SNAPSHOT broken for FlinkRunner

2024-02-22 Thread Kenneth Knowles
Great. Let me know if I can help. I broke it after all :-) Kenn On Thu, Feb 22, 2024 at 2:58 AM Jan Lukavský wrote: > Reasons we use Java serialization are not fundamental, probably only > historical. Thinking about it, yes, there is lucky coincidence that we > currently have to change the

Re: Pipeline upgrade to 2.55.0-SNAPSHOT broken for FlinkRunner

2024-02-21 Thread Jan Lukavský
Reasons we use Java serialization are not fundamental, probably only historical. Thinking about it, yes, there is lucky coincidence that we currently have to change the serialization because of Flink 1.17 support. Flink 1.17 actually removes the legacy java serialization from Flink and

Re: Pipeline upgrade to 2.55.0-SNAPSHOT broken for FlinkRunner

2024-02-21 Thread Kenneth Knowles
Yea I think we should restore the necessary classes but also fix the FlinkRunner. Java serialization is inherently self-update-incompatible. On Wed, Feb 21, 2024 at 1:35 PM Reuven Lax via dev wrote: > Is there a fundamental reason we serialize java classes into Flink > savepoints. > > On Wed,

Re: Pipeline upgrade to 2.55.0-SNAPSHOT broken for FlinkRunner

2024-02-21 Thread Reuven Lax via dev
Is there a fundamental reason we serialize java classes into Flink savepoints. On Wed, Feb 21, 2024 at 9:51 AM Robert Bradshaw via dev wrote: > We could consider merging the gradle targets without renaming the > classpaths as an intermediate step. > > Optimistically, perhaps there's a small

Re: Pipeline upgrade to 2.55.0-SNAPSHOT broken for FlinkRunner

2024-02-21 Thread Robert Bradshaw via dev
We could consider merging the gradle targets without renaming the classpaths as an intermediate step. Optimistically, perhaps there's a small number of classes that we need to preserve (e.g. SerializablePipelineOptions looks like it was something specifically intended to be serialized; maybe that

Pipeline upgrade to 2.55.0-SNAPSHOT broken for FlinkRunner

2024-02-21 Thread Jan Lukavský
Hi, while implementing FlinkRunner for Flink 1.17 I tried to verify that a running Pipeline is able to successfully upgrade from Flink 1.16 to Flink 1.17. There is some change regarding serialization needed for Flink 1.17, so this was a concern. Unfortunately recently we merged