Re: [Bug?] Combiner components don't inherit annotations of source CombineByKey

[Robert Bradshaw via dev]

Very clear now :). Thanks for the fix; it looks good.

On Fri, Sep 15, 2023 at 5:07 PM Joey Tran  wrote:

> Ended up just filing a PR [1]
>
> [1] https://github.com/apache/beam/pull/28489
>
>
> On Fri, Sep 15, 2023 at 12:51 PM Joey Tran 
> wrote:
>
>> While implementing a runner, we tried annotating a CombineByKey
>> transform. I noticed that the annotations for the CBK are then lost in the
>> fusion optimization stage when the CBK is broken into components. Is this
>> intentional?
>>
>> I can put up a PR if this seems worth fixing (it is for us at least),
>> just want to confirm before doing so
>>
>>
>>

Re: [Bug?] Combiner components don't inherit annotations of source CombineByKey

[Joey Tran]

Ended up just filing a PR [1]

[1] https://github.com/apache/beam/pull/28489


On Fri, Sep 15, 2023 at 12:51 PM Joey Tran 
wrote:

> While implementing a runner, we tried annotating a CombineByKey transform.
> I noticed that the annotations for the CBK are then lost in the fusion
> optimization stage when the CBK is broken into components. Is this
> intentional?
>
> I can put up a PR if this seems worth fixing (it is for us at least), just
> want to confirm before doing so
>
>
>

Re: [Bug?] Combiner components don't inherit annotations of source CombineByKey

[Robert Bradshaw via dev]

Could you clarify what you mean by annotating the transform?

On Fri, Sep 15, 2023 at 9:57 AM Joey Tran  wrote:

> While implementing a runner, we tried annotating a CombineByKey transform.
> I noticed that the annotations for the CBK are then lost in the fusion
> optimization stage when the CBK is broken into components. Is this
> intentional?
>
> I can put up a PR if this seems worth fixing (it is for us at least), just
> want to confirm before doing so
>
>
>