Re: Go SDK build failures with maven

2018-04-20 Thread Henning Rohde 
Great!

On Fri, Apr 20, 2018 at 6:28 AM Colm O hEigeartaigh 
wrote:

> Thanks for the quick turnaround! Both builds now working correctly for me.
>
> Colm.
>
> On Fri, Apr 20, 2018 at 12:50 AM, Henning Rohde 
> wrote:
>
>> Hi Colm,
>>
>>   The extra pubsub dependency broke the Maven build. The warning you see
>> in gradle seems to be a (non-breaking) linter check that the format string,
>> which is interesting given that the function called is an internal one --
>> but the check happens to be correct.
>>
>>  Sent you https://github.com/apache/beam/pull/5190 for both issues.
>> Sorry about the noise.
>>
>> Thanks,
>>  Henning
>>
>> On Thu, Apr 19, 2018 at 10:01 AM Henning Rohde 
>> wrote:
>>
>>> The Go build works best with Gradle and that's what you should use
>>> (other than possibly manually running go build etc). It looks like the
>>> build might be broken due to the Go streaming PR independently of the build
>>> tooling. Let me take a look.
>>>
>>> On Thu, Apr 19, 2018 at 7:09 AM Colm O hEigeartaigh 
>>> wrote:
>>>
 Hi all,

 Is the Apache Maven build still maintained? I'm seeing some recent
 failures in the Go SDK:

 [INFO] --- mvn-golang-wrapper:2.1.7:test (go-test) @ beam-sdks-go ---
 [INFO] Prepared command line : bin/go test ./...
 [ERROR]
 [ERROR] -Exec.Err-
 [ERROR] /home/colm/.mvnGoLang/.go_path/src/
 cloud.google.com/go/pubsub/subscription.go:30:2: cannot find package "
 golang.org/x/sync/errgroup" in any of:
 [ERROR] /home/colm/.mvnGoLang/go1.9.linux-amd64/src/
 golang.org/x/sync/errgroup (from $GOROOT)
 [ERROR] /home/colm/.mvnGoLang/.go_path/src/
 golang.org/x/sync/errgroup (from $GOPATH)
 [ERROR] /home/colm/src/apache/beam/sdks/go/target/src/
 golang.org/x/sync/errgroup
 [ERROR] /home/colm/.mvnGoLang/.go_path/src/
 cloud.google.com/go/pubsub/flow_controller.go:19:2: cannot find
 package "golang.org/x/sync/semaphore" in any of:
 [ERROR] /home/colm/.mvnGoLang/go1.9.linux-amd64/src/
 golang.org/x/sync/semaphore (from $GOROOT)
 [ERROR] /home/colm/.mvnGoLang/.go_path/src/
 golang.org/x/sync/semaphore (from $GOPATH)
 [ERROR] /home/colm/src/apache/beam/sdks/go/target/src/
 golang.org/x/sync/semaphore
 [ERROR]

 Incidentally, when run via gradle I see:

 /home/colm/src/apache/beam/sdks/go/pkg/beam/util/pubsubx/pubsub.go:75:
 wrong number of args for format in Errorf call: 1 needed but 2 args
 /home/colm/src/apache/beam/sdks/go/pkg/beam/util/pubsubx/pubsub.go:78:
 wrong number of args for format in Errorf call: 1 needed but 2 args
 /home/colm/src/apache/beam/sdks/go/target/src/
 github.com/apache/beam/sdks/go/pkg/beam/util/pubsubx/pubsub.go:75:
 wrong number of args for format in Errorf call: 1 needed but 2 args
 /home/colm/src/apache/beam/sdks/go/target/src/
 github.com/apache/beam/sdks/go/pkg/beam/util/pubsubx/pubsub.go:78:
 wrong number of args for format in Errorf call: 1 needed but 2 args


 Colm.


 --
 Colm O hEigeartaigh

 Talend Community Coder
 http://coders.talend.com

>>>
>
>
> --
> Colm O hEigeartaigh
>
> Talend Community Coder
> http://coders.talend.com
>

Re: Go SDK build failures with maven

2018-04-20 Thread Colm O hEigeartaigh 
Thanks for the quick turnaround! Both builds now working correctly for me.

Colm.

On Fri, Apr 20, 2018 at 12:50 AM, Henning Rohde  wrote:

> Hi Colm,
>
>   The extra pubsub dependency broke the Maven build. The warning you see
> in gradle seems to be a (non-breaking) linter check that the format string,
> which is interesting given that the function called is an internal one --
> but the check happens to be correct.
>
>  Sent you https://github.com/apache/beam/pull/5190 for both issues. Sorry
> about the noise.
>
> Thanks,
>  Henning
>
> On Thu, Apr 19, 2018 at 10:01 AM Henning Rohde  wrote:
>
>> The Go build works best with Gradle and that's what you should use (other
>> than possibly manually running go build etc). It looks like the build might
>> be broken due to the Go streaming PR independently of the build tooling.
>> Let me take a look.
>>
>> On Thu, Apr 19, 2018 at 7:09 AM Colm O hEigeartaigh 
>> wrote:
>>
>>> Hi all,
>>>
>>> Is the Apache Maven build still maintained? I'm seeing some recent
>>> failures in the Go SDK:
>>>
>>> [INFO] --- mvn-golang-wrapper:2.1.7:test (go-test) @ beam-sdks-go ---
>>> [INFO] Prepared command line : bin/go test ./...
>>> [ERROR]
>>> [ERROR] -Exec.Err-
>>> [ERROR] /home/colm/.mvnGoLang/.go_path/src/cloud.google.com/go/
>>> pubsub/subscription.go:30:2: cannot find package "
>>> golang.org/x/sync/errgroup" in any of:
>>> [ERROR] /home/colm/.mvnGoLang/go1.9.linux-amd64/src/golang.org/x/
>>> sync/errgroup (from $GOROOT)
>>> [ERROR] /home/colm/.mvnGoLang/.go_path/src/golang.org/x/sync/
>>> errgroup (from $GOPATH)
>>> [ERROR] /home/colm/src/apache/beam/sdks/go/target/src/golang.org/
>>> x/sync/errgroup
>>> [ERROR] /home/colm/.mvnGoLang/.go_path/src/cloud.google.com/go/
>>> pubsub/flow_controller.go:19:2: cannot find package "
>>> golang.org/x/sync/semaphore" in any of:
>>> [ERROR] /home/colm/.mvnGoLang/go1.9.linux-amd64/src/golang.org/x/
>>> sync/semaphore (from $GOROOT)
>>> [ERROR] /home/colm/.mvnGoLang/.go_path/src/golang.org/x/sync/
>>> semaphore (from $GOPATH)
>>> [ERROR] /home/colm/src/apache/beam/sdks/go/target/src/golang.org/
>>> x/sync/semaphore
>>> [ERROR]
>>>
>>> Incidentally, when run via gradle I see:
>>>
>>> /home/colm/src/apache/beam/sdks/go/pkg/beam/util/pubsubx/pubsub.go:75:
>>> wrong number of args for format in Errorf call: 1 needed but 2 args
>>> /home/colm/src/apache/beam/sdks/go/pkg/beam/util/pubsubx/pubsub.go:78:
>>> wrong number of args for format in Errorf call: 1 needed but 2 args
>>> /home/colm/src/apache/beam/sdks/go/target/src/github.com/
>>> apache/beam/sdks/go/pkg/beam/util/pubsubx/pubsub.go:75: wrong number of
>>> args for format in Errorf call: 1 needed but 2 args
>>> /home/colm/src/apache/beam/sdks/go/target/src/github.com/
>>> apache/beam/sdks/go/pkg/beam/util/pubsubx/pubsub.go:78: wrong number of
>>> args for format in Errorf call: 1 needed but 2 args
>>>
>>>
>>> Colm.
>>>
>>>
>>> --
>>> Colm O hEigeartaigh
>>>
>>> Talend Community Coder
>>> http://coders.talend.com
>>>
>>


-- 
Colm O hEigeartaigh

Talend Community Coder
http://coders.talend.com

Re: Go SDK build failures with maven

2018-04-19 Thread Henning Rohde 
Hi Colm,

  The extra pubsub dependency broke the Maven build. The warning you see in
gradle seems to be a (non-breaking) linter check that the format string,
which is interesting given that the function called is an internal one --
but the check happens to be correct.

 Sent you https://github.com/apache/beam/pull/5190 for both issues. Sorry
about the noise.

Thanks,
 Henning

On Thu, Apr 19, 2018 at 10:01 AM Henning Rohde  wrote:

> The Go build works best with Gradle and that's what you should use (other
> than possibly manually running go build etc). It looks like the build might
> be broken due to the Go streaming PR independently of the build tooling.
> Let me take a look.
>
> On Thu, Apr 19, 2018 at 7:09 AM Colm O hEigeartaigh 
> wrote:
>
>> Hi all,
>>
>> Is the Apache Maven build still maintained? I'm seeing some recent
>> failures in the Go SDK:
>>
>> [INFO] --- mvn-golang-wrapper:2.1.7:test (go-test) @ beam-sdks-go ---
>> [INFO] Prepared command line : bin/go test ./...
>> [ERROR]
>> [ERROR] -Exec.Err-
>> [ERROR] /home/colm/.mvnGoLang/.go_path/src/
>> cloud.google.com/go/pubsub/subscription.go:30:2: cannot find package "
>> golang.org/x/sync/errgroup" in any of:
>> [ERROR] /home/colm/.mvnGoLang/go1.9.linux-amd64/src/
>> golang.org/x/sync/errgroup (from $GOROOT)
>> [ERROR] /home/colm/.mvnGoLang/.go_path/src/golang.org/x/sync/errgroup
>> (from $GOPATH)
>> [ERROR] /home/colm/src/apache/beam/sdks/go/target/src/
>> golang.org/x/sync/errgroup
>> [ERROR] /home/colm/.mvnGoLang/.go_path/src/
>> cloud.google.com/go/pubsub/flow_controller.go:19:2: cannot find package "
>> golang.org/x/sync/semaphore" in any of:
>> [ERROR] /home/colm/.mvnGoLang/go1.9.linux-amd64/src/
>> golang.org/x/sync/semaphore (from $GOROOT)
>> [ERROR] /home/colm/.mvnGoLang/.go_path/src/
>> golang.org/x/sync/semaphore (from $GOPATH)
>> [ERROR] /home/colm/src/apache/beam/sdks/go/target/src/
>> golang.org/x/sync/semaphore
>> [ERROR]
>>
>> Incidentally, when run via gradle I see:
>>
>> /home/colm/src/apache/beam/sdks/go/pkg/beam/util/pubsubx/pubsub.go:75:
>> wrong number of args for format in Errorf call: 1 needed but 2 args
>> /home/colm/src/apache/beam/sdks/go/pkg/beam/util/pubsubx/pubsub.go:78:
>> wrong number of args for format in Errorf call: 1 needed but 2 args
>> /home/colm/src/apache/beam/sdks/go/target/src/
>> github.com/apache/beam/sdks/go/pkg/beam/util/pubsubx/pubsub.go:75: wrong
>> number of args for format in Errorf call: 1 needed but 2 args
>> /home/colm/src/apache/beam/sdks/go/target/src/
>> github.com/apache/beam/sdks/go/pkg/beam/util/pubsubx/pubsub.go:78: wrong
>> number of args for format in Errorf call: 1 needed but 2 args
>>
>>
>> Colm.
>>
>>
>> --
>> Colm O hEigeartaigh
>>
>> Talend Community Coder
>> http://coders.talend.com
>>
>

Re: Go SDK build failures with maven

2018-04-19 Thread Henning Rohde 
The Go build works best with Gradle and that's what you should use (other
than possibly manually running go build etc). It looks like the build might
be broken due to the Go streaming PR independently of the build tooling.
Let me take a look.

On Thu, Apr 19, 2018 at 7:09 AM Colm O hEigeartaigh 
wrote:

> Hi all,
>
> Is the Apache Maven build still maintained? I'm seeing some recent
> failures in the Go SDK:
>
> [INFO] --- mvn-golang-wrapper:2.1.7:test (go-test) @ beam-sdks-go ---
> [INFO] Prepared command line : bin/go test ./...
> [ERROR]
> [ERROR] -Exec.Err-
> [ERROR] /home/colm/.mvnGoLang/.go_path/src/
> cloud.google.com/go/pubsub/subscription.go:30:2: cannot find package "
> golang.org/x/sync/errgroup" in any of:
> [ERROR] /home/colm/.mvnGoLang/go1.9.linux-amd64/src/
> golang.org/x/sync/errgroup (from $GOROOT)
> [ERROR] /home/colm/.mvnGoLang/.go_path/src/golang.org/x/sync/errgroup
> (from $GOPATH)
> [ERROR] /home/colm/src/apache/beam/sdks/go/target/src/
> golang.org/x/sync/errgroup
> [ERROR] /home/colm/.mvnGoLang/.go_path/src/
> cloud.google.com/go/pubsub/flow_controller.go:19:2: cannot find package "
> golang.org/x/sync/semaphore" in any of:
> [ERROR] /home/colm/.mvnGoLang/go1.9.linux-amd64/src/
> golang.org/x/sync/semaphore (from $GOROOT)
> [ERROR] /home/colm/.mvnGoLang/.go_path/src/golang.org/x/sync/semaphore
> (from $GOPATH)
> [ERROR] /home/colm/src/apache/beam/sdks/go/target/src/
> golang.org/x/sync/semaphore
> [ERROR]
>
> Incidentally, when run via gradle I see:
>
> /home/colm/src/apache/beam/sdks/go/pkg/beam/util/pubsubx/pubsub.go:75:
> wrong number of args for format in Errorf call: 1 needed but 2 args
> /home/colm/src/apache/beam/sdks/go/pkg/beam/util/pubsubx/pubsub.go:78:
> wrong number of args for format in Errorf call: 1 needed but 2 args
> /home/colm/src/apache/beam/sdks/go/target/src/
> github.com/apache/beam/sdks/go/pkg/beam/util/pubsubx/pubsub.go:75: wrong
> number of args for format in Errorf call: 1 needed but 2 args
> /home/colm/src/apache/beam/sdks/go/target/src/
> github.com/apache/beam/sdks/go/pkg/beam/util/pubsubx/pubsub.go:78: wrong
> number of args for format in Errorf call: 1 needed but 2 args
>
>
> Colm.
>
>
> --
> Colm O hEigeartaigh
>
> Talend Community Coder
> http://coders.talend.com
>