Ok, if it's annoying the description can be removed. It will still match
extensions though.
On Sat, Feb 15, 2020, 00:58 Kyle Weaver wrote:
> I suppose that'd be okay. It doesn't look like the descriptions add too
> much information.
>
> On Fri, Feb 14, 2020 at 3:55 PM Ismaël Mejía wrote:
>
>>
I'm really enjoying this feature so far! The "Pull Requests" page for Beam
is now way more readable. Thanks Alex :)
On Wed, Feb 12, 2020 at 9:18 PM Alex Van Boxel wrote:
> What do you exactly mean with github grep... where is it an issue. I find
> it useful for searching here:
>
> [image:
What do you exactly mean with github grep... where is it an issue. I find
it useful for searching here:
[image: Screen Shot 2020-02-13 at 06.11.33.png]
OK, you get some false positives, but then the color coding works. You
can't search on a category so this looks like the only alternative. I was
Alex would you consider removing the descriptions from the labels? It seems
that
github greps not only the text of the label but also the text of the
description
producing false positives, e.g. if I search the label `io` it resolves not
only
all the IOs but also results like `core` because it
The prefix is just extra characters makes readibility worse, notice
that the full category (e.g. ios/runners/etc) will match because we have an
extra tag equivalent to the prefix, so filtering is still possible. you
rarely
need to filter for more than one criteria, that's why github does not allow
Ismael, I saw that you removed the prefix. I still want to have some
grouping between the subtypes, so I color coded them.
I also added all the labels in the file. We now have 62 labels.
_/
_/ Alex Van Boxel
On Wed, Feb 12, 2020 at 12:03 PM Ismaël Mejía wrote:
> Forgot to mention, older PRs
Forgot to mention, older PRs will look not classified, up to you guys if you
want to do manually. All new PRs will be automatically labeled.
On Wed, Feb 12, 2020 at 12:02 PM Ismaël Mejía wrote:
> For info Alex's PR to suport autolabeler was merged today and INFRA
> enabled the plugin.
> I
For info Alex's PR to suport autolabeler was merged today and INFRA enabled
the plugin.
I created an artificial PR to check it was autolabeled correctly.
It is working perfectly now.
Thanks Alex !
On Tue, Feb 11, 2020 at 5:23 PM Robert Bradshaw wrote:
> +1 to finding the right balance.
>
> I do
+1 to finding the right balance.
I do think per-runner makes sense, rather than a general "runners."
IOs might make sense as well. Not sure about all the extensions-* I'd
leave those out for now.
On Tue, Feb 11, 2020 at 5:56 AM Ismaël Mejía wrote:
>
> > So I propose going simple with a limited
> So I propose going simple with a limited set of labels. Later on we can
refine. Don't forget that does labels only are useful during the life-cycle
of a PR.
Labels are handy for quick filtering and finding PRs we care about for
example
to review.
I agree with the feeling that we should not go
I'm wondering if we're not taking it too far with those detailed labels.
It's like going from nothing to super details. The simples use-case hasn't
proven itself in practice yet.
So I propose going simple with a limited set of labels. Later on we can
refine. Don't forget that does labels only are
Let some comments too, let's keep the discussion on refinements in the PR.
On Tue, Feb 11, 2020 at 9:13 AM jincheng sun
wrote:
> I left comments on PR, the main suggestion is that we may need a
> discussion about what kind of labels should be add. I would like to share
> my thoughts as follows:
I left comments on PR, the main suggestion is that we may need a discussion
about what kind of labels should be add. I would like to share my thoughts
as follows:
I think we need to add labels according to some rules. For example, the
easiest way is to add labels by languages, java / python / go
I've opened a PR and a ticket with INFRA.
PR: https://github.com/apache/beam/pull/10824
_/
_/ Alex Van Boxel
On Tue, Feb 11, 2020 at 6:57 AM jincheng sun
wrote:
> +1. Autolabeler seems really cool and it seems that it's simple to
> configure and set up.
>
> Best,
> Jincheng
>
>
>
> Udi
+1. Autolabeler seems really cool and it seems that it's simple to
configure and set up.
Best,
Jincheng
Udi Meiri 于2020年2月11日周二 上午2:01写道：
> Cool!
>
> On Mon, Feb 10, 2020 at 9:27 AM Robert Burke wrote:
>
>> +1 to autolabeling
>>
>> On Mon, Feb 10, 2020, 9:21 AM Luke Cwik wrote:
>>
>>> Nice
Cool!
On Mon, Feb 10, 2020 at 9:27 AM Robert Burke wrote:
> +1 to autolabeling
>
> On Mon, Feb 10, 2020, 9:21 AM Luke Cwik wrote:
>
>> Nice
>>
>> On Mon, Feb 10, 2020 at 2:52 AM Alex Van Boxel wrote:
>>
>>> Ha, cool. I'll have a look at the autolabeler. The infra stuff is not
>>> something
+1 to autolabeling
On Mon, Feb 10, 2020, 9:21 AM Luke Cwik wrote:
> Nice
>
> On Mon, Feb 10, 2020 at 2:52 AM Alex Van Boxel wrote:
>
>> Ha, cool. I'll have a look at the autolabeler. The infra stuff is not
>> something I've looked at... I'll dive into that.
>>
>> _/
>> _/ Alex Van Boxel
>>
>>
Nice
On Mon, Feb 10, 2020 at 2:52 AM Alex Van Boxel wrote:
> Ha, cool. I'll have a look at the autolabeler. The infra stuff is not
> something I've looked at... I'll dive into that.
>
> _/
> _/ Alex Van Boxel
>
>
> On Mon, Feb 10, 2020 at 11:49 AM Ismaël Mejía wrote:
>
>> +1
>>
>> You don't
Ha, cool. I'll have a look at the autolabeler. The infra stuff is not
something I've looked at... I'll dive into that.
_/
_/ Alex Van Boxel
On Mon, Feb 10, 2020 at 11:49 AM Ismaël Mejía wrote:
> +1
>
> You don't need to write your own action, there is already one autolabeler
> action [1].
>
+1
You don't need to write your own action, there is already one autolabeler
action [1].
INFRA can easily configure it for Beam (as they did for Avro [2]) if we
request it.
The plugin is quite easy to configure and works like a charm [3].
[1] https://github.com/probot/autolabeler
[1]
Great initiative, thanks Alex! I was thinking to add such labels into PR title
but I believe that GitHub labels are better since it can be used easily for
filtering, for example.
Maybe it could be useful to add more granulation for labels, like “release”,
“runners”, “website”, etc but I’m
ThanksIt sounds good to me. Regards JBLe lun. 10 f?vr. 2020 ? 08:35, Alex Van Boxel a ?crit :I've started putting labels on PR's. I've done the first page for now (as I'm afraid putting them on older once could affect the stale bot. I hope this is ok.For now I'm only focussing on language and I'm
22 matches
Mail list logo
