Re: portableWordCountBatch and portableWordCountStreaming failing in Python PreCommit

2019-09-17 Thread Ning Kang
Thank you Hannah! It works for me! On Mon, Sep 16, 2019 at 9:56 PM Mark Liu wrote: > Thank you Hannah! > > BTW, the fix is https://github.com/apache/beam/pull/9588. > Since this affects release, https://github.com/apache/beam/pull/9595 will > be cherry-picked to release branch. > > On Mon, Sep

Re: portableWordCountBatch and portableWordCountStreaming failing in Python PreCommit

2019-09-16 Thread Mark Liu
Thank you Hannah! BTW, the fix is https://github.com/apache/beam/pull/9588. Since this affects release, https://github.com/apache/beam/pull/9595 will be cherry-picked to release branch. On Mon, Sep 16, 2019 at 9:47 PM Hannah Jiang wrote: > The fix is merged. I tested with PRs which used to

Re: portableWordCountBatch and portableWordCountStreaming failing in Python PreCommit

2019-09-16 Thread Hannah Jiang
The fix is merged. I tested with PRs which used to fail and the failures are fixed now. Please rerun the test if your PR is affected. On Mon, Sep 16, 2019 at 6:16 PM Mark Liu wrote: > Thanks for letting me know. I'll keep tracking on this issue since it's a > release blocker. Please update

Re: portableWordCountBatch and portableWordCountStreaming failing in Python PreCommit

2019-09-16 Thread Mark Liu
Thanks for letting me know. I'll keep tracking on this issue since it's a release blocker. Please update here/jira if you have any progress. Mark On Mon, Sep 16, 2019 at 5:04 PM Hannah Jiang wrote: > For issue with flink image, I re-opened a ticket which is currently > blocking

Re: portableWordCountBatch and portableWordCountStreaming failing in Python PreCommit

2019-09-16 Thread Hannah Jiang
For issue with flink image, I re-opened a ticket which is currently blocking release.(BEAM-8165) On Mon, Sep 16, 2019 at 5:00 PM Ahmet Altay wrote: > > > On Mon, Sep 16, 2019 at 2:07 PM Kyle Weaver wrote: > >> The original issue ("GetJobMetrics is unimplemented") is still probably >> hiding

Re: portableWordCountBatch and portableWordCountStreaming failing in Python PreCommit

2019-09-16 Thread Ahmet Altay
On Mon, Sep 16, 2019 at 2:07 PM Kyle Weaver wrote: > The original issue ("GetJobMetrics is unimplemented") is still probably > hiding under the docker issue, so I filed > https://issues.apache.org/jira/browse/BEAM-8245 for it > Thank you. Who should be assigned to this issue? If metrics are

Re: portableWordCountBatch and portableWordCountStreaming failing in Python PreCommit

2019-09-16 Thread Kyle Weaver
The original issue ("GetJobMetrics is unimplemented") is still probably hiding under the docker issue, so I filed https://issues.apache.org/jira/browse/BEAM-8245 for it Kyle Weaver | Software Engineer | github.com/ibzib | kcwea...@google.com On Mon, Sep 16, 2019 at 1:14 PM Hannah Jiang wrote:

Re: portableWordCountBatch and portableWordCountStreaming failing in Python PreCommit

2019-09-16 Thread Hannah Jiang
If we try to create a flink image from master branch, it will create *apachebeam/flink-job-server*, while the code is expecting *jenkins-docker-apache.bintray.io/beam/flink-job-server:latest *. This should be introduced when we

Re: portableWordCountBatch and portableWordCountStreaming failing in Python PreCommit

2019-09-16 Thread Lukasz Cwik
I'm also being impacted by this on my PR[1]. I found BEAM-6316[2] that has a similar error but it was resolved Dec 2018. 1: https://github.com/apache/beam/pull/9583 2: https://issues.apache.org/jira/browse/BEAM-6316 On Mon, Sep 16, 2019 at 12:43 PM Ning Kang wrote: > A new check renders

Re: portableWordCountBatch and portableWordCountStreaming failing in Python PreCommit

2019-09-16 Thread Ning Kang
A new check renders clearer message: Unable to find image ' jenkins-docker-apache.bintray.io/beam/flink-job-server:latest' locally docker: Error response from daemon: unknown: Repo 'apache' was not found. See 'docker run --help'. ERROR:root:Starting job service with ['docker', 'run', '-v',

Re: portableWordCountBatch and portableWordCountStreaming failing in Python PreCommit

2019-09-16 Thread Ning Kang
To Ahmet, these are warnings, I'm not able to identify the errors yet. Thanks everyone! I'm watching the Jira now. On Mon, Sep 16, 2019 at 12:07 PM Chad Dombrova wrote: > Ning, if you're having trouble making sense of the preCommit errors, you > may be interested in this Jira: >

Re: portableWordCountBatch and portableWordCountStreaming failing in Python PreCommit

2019-09-16 Thread Chad Dombrova
Ning, if you're having trouble making sense of the preCommit errors, you may be interested in this Jira: https://issues.apache.org/jira/browse/BEAM-8213# On Mon, Sep 16, 2019 at 12:02 PM Kyle Weaver wrote: > Python 2 isn't the reason the test is failing, that's just a warning. The > actual

Re: portableWordCountBatch and portableWordCountStreaming failing in Python PreCommit

2019-09-16 Thread Kyle Weaver
Python 2 isn't the reason the test is failing, that's just a warning. The actual error is at the very end of the log (it looks familiar to me, though I don't see a JIRA for it): <_Rendezvous of RPC that terminated with: status = StatusCode.UNIMPLEMENTED details = "Method

Re: portableWordCountBatch and portableWordCountStreaming failing in Python PreCommit

2019-09-16 Thread Ahmet Altay
To clarify are they errors or warnings? There is a plan to stop supporting python 2 by ~end of the year. +Valentyn Tymofieiev shared details about it earlier on the dev@ list. On Mon, Sep 16, 2019 at 11:34 AM Ning Kang wrote: > Hi! I've been seeing some errors during "Python PreCommit". > I'm

portableWordCountBatch and portableWordCountStreaming failing in Python PreCommit

2019-09-16 Thread Ning Kang
Hi! I've been seeing some errors during "Python PreCommit". I'm seeing "UserWarning: You are using Apache Beam with Python 2. New releases of Apache Beam will soon support Python 3 only. 'You are using Apache Beam with Python 2. '" Is there any plan to remove py2 tests from the pre-commit check