Re: [3/4] incubator-beam git commit: Remove KeyedResourcePool

2016-10-13 Thread Jean-Baptiste Onofré
Got your message, so it was a mistake and already fixed. No worries. Thanks, Regards JB On 10/14/2016 06:35 AM, Jean-Baptiste Onofré wrote: I saw a push of a eclipse branch on the Beam git repo. Maybe I missed it, but I didn't see discussion about such branch on the dev mailing list. Regards

Re: [3/4] incubator-beam git commit: Remove KeyedResourcePool

2016-10-13 Thread Jean-Baptiste Onofré
I saw a push of a eclipse branch on the Beam git repo. Maybe I missed it, but I didn't see discussion about such branch on the dev mailing list. Regards JB On 10/13/2016 06:52 PM, Daniel Kulp wrote: I just submitted a pull request that fixes the code as well as cherry-picks the yaml change

Re: [3/4] incubator-beam git commit: Remove KeyedResourcePool

2016-10-13 Thread Daniel Kulp
I just submitted a pull request that fixes the code as well as cherry-picks the yaml change from the last branch. Dan > On Oct 13, 2016, at 10:48 AM, Jean-Baptiste Onofré wrote: > > Indeed the .travis.yml has not been merged. I gonna fix that. > > Sorry about that. > > Regards > JB > >

Re: [3/4] incubator-beam git commit: Remove KeyedResourcePool

2016-10-13 Thread Jean-Baptiste Onofré
Indeed the .travis.yml has not been merged. I gonna fix that. Sorry about that. Regards JB On 10/13/2016 04:37 PM, Daniel Kulp wrote: This is in m2e.That said, it looks like the travis.yml file wasn’t merged from my “eclipse” branch so Travis wasn’t actually running agains the eclipse c

Re: [3/4] incubator-beam git commit: Remove KeyedResourcePool

2016-10-13 Thread Daniel Kulp
This is in m2e.That said, it looks like the travis.yml file wasn’t merged from my “eclipse” branch so Travis wasn’t actually running agains the eclipse compiler. That would have caught this. JB and I will investigate how that got lost in the merge to master. A "mvn -Peclipse-jdt clean

Re: [3/4] incubator-beam git commit: Remove KeyedResourcePool

2016-10-13 Thread Jean-Baptiste Onofré
Hi Dan, You mean directly building in Eclipse I guess using m2e ? Regards JB On 10/13/2016 03:59 PM, Daniel Kulp wrote: Just an FYI: this commit has caused things to not build in Eclipse, but I’m not exactly sure why. The errors are in place where methods of the exact signature just mov

Re: [3/4] incubator-beam git commit: Remove KeyedResourcePool

2016-10-13 Thread Daniel Kulp
Just an FYI: this commit has caused things to not build in Eclipse, but I’m not exactly sure why. The errors are in place where methods of the exact signature just moved into an internal class so I’m not yet sure why it’s causing an issue. Description ResourcePathLocation