[GitHub] bigtop issue #268: BIGTOP-2860:Fix TestSpark.groovy syntax error

2017-08-08 Thread c0s 
Github user c0s commented on the issue:

https://github.com/apache/bigtop/pull/268
  
I will squash the commits to a single one before pushing to the master 
branch



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bigtop issue #268: BIGTOP-2860:Fix TestSpark.groovy syntax error

2017-08-06 Thread guyuqi 
Github user guyuqi commented on the issue:

https://github.com/apache/bigtop/pull/268
  
Fixed! thanks naresh!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bigtop issue #268: BIGTOP-2860:Fix TestSpark.groovy syntax error

2017-08-06 Thread nareshgbhat 
Github user nareshgbhat commented on the issue:

https://github.com/apache/bigtop/pull/268
  
As far as I understand the below code change must be by mistake in the patch

static final String SPARK_PORT = System.getenv("SPARK_MASTER_PORT")

should be changed to as below ?

static final String SPARK_MASTER_PORT = System.getenv("SPARK_MASTER_PORT")



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---