[jira] [Commented] (BOOKKEEPER-800) Expose whether a ledger is closed or not

2014-12-04 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235134#comment-14235134 ] Sijie Guo commented on BOOKKEEPER-800: -- the patch lgtm. +1 Expose whether a

[jira] [Commented] (BOOKKEEPER-803) Guide for making a replicated log out of ledgers

2014-12-04 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235138#comment-14235138 ] Sijie Guo commented on BOOKKEEPER-803: -- +1. Guide for making a replicated log

[jira] [Updated] (BOOKKEEPER-813) BookieShell doesn't find index directory

2014-12-04 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-813: - Assignee: Charles Xie BookieShell doesn't find index directory

[jira] [Commented] (BOOKKEEPER-811) Recovery tool doesn't remove cookie after recovering one bookie

2014-12-04 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235140#comment-14235140 ] Sijie Guo commented on BOOKKEEPER-811: -- patch looks good to me. +1. thanks

[jira] [Commented] (BOOKKEEPER-794) BookkeeperProtocol.Response.status is completely ignored

2014-12-04 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235144#comment-14235144 ] Sijie Guo commented on BOOKKEEPER-794: -- I don't understand this ticket. for old

[jira] [Created] (BOOKKEEPER-816) use native fallocate sync_file_range to improve journal allocation

2014-12-04 Thread Sijie Guo (JIRA)
Sijie Guo created BOOKKEEPER-816: Summary: use native fallocate sync_file_range to improve journal allocation Key: BOOKKEEPER-816 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-816 Project:

[jira] [Created] (BOOKKEEPER-819) Bound maximum number of ensemble changes

2014-12-04 Thread Sijie Guo (JIRA)
Sijie Guo created BOOKKEEPER-819: Summary: Bound maximum number of ensemble changes Key: BOOKKEEPER-819 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-819 Project: Bookkeeper Issue

[jira] [Commented] (BOOKKEEPER-804) Client program is not terminated when using openLedgerNoRecovery

2014-12-05 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236651#comment-14236651 ] Sijie Guo commented on BOOKKEEPER-804: -- +1 commit 2b88b11 in master commit

[jira] [Commented] (BOOKKEEPER-796) Make bookkeeper client use reconnectable zookeeper wrapper

2014-12-16 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14247912#comment-14247912 ] Sijie Guo commented on BOOKKEEPER-796: -- [~ikelly] are the failed test cases flaky

[jira] [Commented] (BOOKKEEPER-827) change throttle in GarbageCollector to use either by entry or by byte

2014-12-16 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249565#comment-14249565 ] Sijie Guo commented on BOOKKEEPER-827: -- remove 4.3.1 in fix versions, since it is

[jira] [Created] (BOOKKEEPER-833) EntryLogId and EntryLogLimit should not be larger than Integer.MAX_VALUE

2014-12-22 Thread Sijie Guo (JIRA)
Sijie Guo created BOOKKEEPER-833: Summary: EntryLogId and EntryLogLimit should not be larger than Integer.MAX_VALUE Key: BOOKKEEPER-833 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-833

[jira] [Updated] (BOOKKEEPER-837) UpdateLedgerOp - Replace AbstractFuture with SettableFuture

2015-02-13 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-837: - Fix Version/s: (was: 4.3.1) 4.4.0 4.3.2

[jira] [Updated] (BOOKKEEPER-836) disable compaction when disk becomes full, otherwise compaction will fill up disk quickly

2015-02-13 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-836: - Fix Version/s: (was: 4.3.1) 4.3.2 disable compaction when disk

[jira] [Updated] (BOOKKEEPER-639) Provide hostname based bookie and ledger metadata to support IP change

2015-03-17 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-639: - Fix Version/s: 4.4.0 Provide hostname based bookie and ledger metadata to support IP change

[jira] [Created] (BOOKKEEPER-843) GcLedgersTest creates too many ledgers in #testGcLedgersNotLast

2015-03-09 Thread Sijie Guo (JIRA)
Sijie Guo created BOOKKEEPER-843: Summary: GcLedgersTest creates too many ledgers in #testGcLedgersNotLast Key: BOOKKEEPER-843 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-843 Project:

[jira] [Commented] (BOOKKEEPER-839) AuditorPeriodicCheckTest timeout

2015-03-09 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14354147#comment-14354147 ] Sijie Guo commented on BOOKKEEPER-839: -- +1 on decrementing the number of ledgers

[jira] [Resolved] (BOOKKEEPER-566) provide a bookie store interface.

2015-03-12 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo resolved BOOKKEEPER-566. -- Resolution: Won't Fix provide a bookie store interface. -

[jira] [Commented] (BOOKKEEPER-836) disable compaction when disk becomes full, otherwise compaction will fill up disk quickly

2015-03-12 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14358229#comment-14358229 ] Sijie Guo commented on BOOKKEEPER-836: -- if we don't disable major contribution,

[jira] [Commented] (BOOKKEEPER-831) Outdated links in tutorial

2015-03-12 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14358245#comment-14358245 ] Sijie Guo commented on BOOKKEEPER-831: -- +1 for the patch. committing. Outdated

[jira] [Commented] (BOOKKEEPER-840) Deadlock on flushLock on compaction

2015-03-12 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14358286#comment-14358286 ] Sijie Guo commented on BOOKKEEPER-840: -- yes. that is the right fix. since the

[jira] [Updated] (BOOKKEEPER-840) Deadlock on flushLock on compaction

2015-03-12 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-840: - Attachment: BOOKKEEPER-840.path attached a patch to address the deadlock. Deadlock on

[jira] [Commented] (BOOKKEEPER-847) ArrayIndexOutOfBoundsException in LedgerFragmentReplicator::updateEnsembleInfo

2015-03-29 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385946#comment-14385946 ] Sijie Guo commented on BOOKKEEPER-847: -- [~rakeshr] I just took at the code

[jira] [Commented] (BOOKKEEPER-838) ForceWriteThread::run() leaks “logFile.close()” when interrupt comes

2015-02-22 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14333062#comment-14333062 ] Sijie Guo commented on BOOKKEEPER-838: -- committed as

[jira] [Updated] (BOOKKEEPER-838) ForceWriteThread::run() leaks “logFile.close()” when interrupt comes

2015-02-22 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-838: - Fix Version/s: 4.3.1 4.4.0 ForceWriteThread::run() leaks

[jira] [Commented] (BOOKKEEPER-836) disable compaction when disk becomes full, otherwise compaction will fill up disk quickly

2015-02-22 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14333056#comment-14333056 ] Sijie Guo commented on BOOKKEEPER-836: -- I like the idea to disable compaction

[jira] [Commented] (BOOKKEEPER-834) test case error in test class TestDiskChecker

2015-03-18 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14366711#comment-14366711 ] Sijie Guo commented on BOOKKEEPER-834: -- [~fpj] we are still working on some tests

[jira] [Commented] (BOOKKEEPER-834) test case error in test class TestDiskChecker

2015-03-18 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14366715#comment-14366715 ] Sijie Guo commented on BOOKKEEPER-834: -- committed as

[jira] [Commented] (BOOKKEEPER-844) Add more metrics about latency and bytes characteristics on bookie operations

2015-03-18 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14366723#comment-14366723 ] Sijie Guo commented on BOOKKEEPER-844: -- the patch looks good to me. +1.

[jira] [Commented] (BOOKKEEPER-849) Collect stats with sub-milliseconds precision

2015-04-14 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493691#comment-14493691 ] Sijie Guo commented on BOOKKEEPER-849: -- the patch looks good. added a comment on

[jira] [Commented] (BOOKKEEPER-851) Configurable LedgerStorageImplementation

2015-04-14 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493709#comment-14493709 ] Sijie Guo commented on BOOKKEEPER-851: -- could you describe more what is the

[jira] [Commented] (BOOKKEEPER-852) Release LedgerDescriptor and master-key objects when not used anymore

2015-04-14 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493700#comment-14493700 ] Sijie Guo commented on BOOKKEEPER-852: -- commented at the review board. Release

[jira] [Updated] (BOOKKEEPER-835) Update copyright for 2015 on all active branches

2015-04-14 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-835: - Attachment: BOOKKEEPER-835.patch attached a patch to update copy right year. Update

[jira] [Updated] (BOOKKEEPER-833) EntryLogId and EntryLogLimit should not be larger than Integer.MAX_VALUE

2015-04-14 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-833: - Attachment: BOOKKEEPER-833.v2.patch attach a new patch to fix the comment. @fpj changing the

[jira] [Commented] (BOOKKEEPER-833) EntryLogId and EntryLogLimit should not be larger than Integer.MAX_VALUE

2015-04-14 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493753#comment-14493753 ] Sijie Guo commented on BOOKKEEPER-833: -- Should we make it an int if it needs to

[jira] [Commented] (BOOKKEEPER-836) disable compaction when disk becomes full, otherwise compaction will fill up disk quickly

2015-04-21 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504538#comment-14504538 ] Sijie Guo commented on BOOKKEEPER-836: -- the patch looks good to me. +1 disable

[jira] [Commented] (BOOKKEEPER-835) Update copyright for 2015 on all active branches

2015-04-21 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504522#comment-14504522 ] Sijie Guo commented on BOOKKEEPER-835: -- [~fpj] [~ikelly] could any of you review

[jira] [Created] (BOOKKEEPER-853) Use integer for entry log id

2015-04-21 Thread Sijie Guo (JIRA)
Sijie Guo created BOOKKEEPER-853: Summary: Use integer for entry log id Key: BOOKKEEPER-853 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-853 Project: Bookkeeper Issue Type: Bug

[jira] [Updated] (BOOKKEEPER-836) disable compaction when disk becomes full, otherwise compaction will fill up disk quickly

2015-04-21 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-836: - Fix Version/s: (was: 4.3.2) disable compaction when disk becomes full, otherwise

[jira] [Updated] (BOOKKEEPER-853) Use integer for entry log id

2015-04-21 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-853: - Fix Version/s: 4.4.0 Use integer for entry log id

[jira] [Commented] (BOOKKEEPER-846) TestLedgerChecker times out

2015-04-21 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504558#comment-14504558 ] Sijie Guo commented on BOOKKEEPER-846: -- +1 for the patch. committing.

[jira] [Updated] (BOOKKEEPER-843) GcLedgersTest creates too many ledgers in #testGcLedgersNotLast

2015-04-21 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-843: - Fix Version/s: (was: 4.3.1) GcLedgersTest creates too many ledgers in

[jira] [Updated] (BOOKKEEPER-842) Tests related to changing bookie id would fail if DNS resolution can't return hostname

2015-04-21 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-842: - Fix Version/s: (was: 4.3.1) Tests related to changing bookie id would fail if DNS

[jira] [Commented] (BOOKKEEPER-835) Update copyright for 2015 on all active branches

2015-04-23 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510153#comment-14510153 ] Sijie Guo commented on BOOKKEEPER-835: -- could any committers review this? this is

[jira] [Created] (BOOKKEEPER-854) NPE on InterleavedLedgerStorage.onRotateEntryLog

2015-05-19 Thread Sijie Guo (JIRA)
Sijie Guo created BOOKKEEPER-854: Summary: NPE on InterleavedLedgerStorage.onRotateEntryLog Key: BOOKKEEPER-854 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-854 Project: Bookkeeper

[jira] [Updated] (BOOKKEEPER-854) NPE on InterleavedLedgerStorage.onRotateEntryLog

2015-05-19 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-854: - Priority: Blocker (was: Major) NPE on InterleavedLedgerStorage.onRotateEntryLog

[jira] [Commented] (BOOKKEEPER-846) TestLedgerChecker times out

2015-04-16 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14497883#comment-14497883 ] Sijie Guo commented on BOOKKEEPER-846: -- taking a close at LedgerChecker

[jira] [Commented] (BOOKKEEPER-846) TestLedgerChecker times out

2015-04-16 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498289#comment-14498289 ] Sijie Guo commented on BOOKKEEPER-846: -- [~rakeshr] please ignore my first

[jira] [Commented] (BOOKKEEPER-846) TestLedgerChecker times out

2015-04-16 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498407#comment-14498407 ] Sijie Guo commented on BOOKKEEPER-846: -- {code} But I feel there is no harm in

[jira] [Commented] (BOOKKEEPER-841) Bookie should calculate ledgers map writing a new entry log file

2015-04-09 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486790#comment-14486790 ] Sijie Guo commented on BOOKKEEPER-841: -- thanks [~merlimat] The patch looks

[jira] [Commented] (BOOKKEEPER-841) Bookie should calculate ledgers map writing a new entry log file

2015-04-09 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487700#comment-14487700 ] Sijie Guo commented on BOOKKEEPER-841: -- [~merlimat] awesome. I will take a look

[jira] [Updated] (BOOKKEEPER-807) Document updatecookie and updateledgers admin tool sequence

2015-05-19 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-807: - Fix Version/s: (was: 4.3.2) Document updatecookie and updateledgers admin tool sequence

[jira] [Updated] (BOOKKEEPER-821) Failing to write lastId to ledger directories should not fail startup of bookies

2015-05-19 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-821: - Fix Version/s: (was: 4.3.2) Failing to write lastId to ledger directories should not

[jira] [Commented] (BOOKKEEPER-796) Make bookkeeper client use reconnectable zookeeper wrapper

2015-05-20 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14551926#comment-14551926 ] Sijie Guo commented on BOOKKEEPER-796: -- the recreation happens only when

[jira] [Issue Comment Deleted] (BOOKKEEPER-796) Make bookkeeper client use reconnectable zookeeper wrapper

2015-05-20 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-796: - Comment: was deleted (was: the recreation happens only when zookeeper session expired. if the

[jira] [Updated] (BOOKKEEPER-823) Clean up temp files created by hedwig tests

2015-05-19 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-823: - Fix Version/s: (was: 4.3.2) Clean up temp files created by hedwig tests

[jira] [Commented] (BOOKKEEPER-854) NPE on InterleavedLedgerStorage.onRotateEntryLog

2015-05-19 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14551776#comment-14551776 ] Sijie Guo commented on BOOKKEEPER-854: -- committed as

[jira] [Commented] (BOOKKEEPER-796) Make bookkeeper client use reconnectable zookeeper wrapper

2015-05-21 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553752#comment-14553752 ] Sijie Guo commented on BOOKKEEPER-796: -- I don't think it closes zookeeper

[jira] [Commented] (BOOKKEEPER-852) Release LedgerDescriptor and master-key objects when not used anymore

2015-07-06 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616223#comment-14616223 ] Sijie Guo commented on BOOKKEEPER-852: -- I think a cleaner solution is to have a

[jira] [Updated] (BOOKKEEPER-796) Make bookkeeper client use reconnectable zookeeper wrapper

2015-05-23 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-796: - Attachment: BOOKKEEPER-796.patch attach a patch to make bookkeeper use

[jira] [Updated] (BOOKKEEPER-705) handle session expire event in client

2015-05-24 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-705: - Attachment: BOOKKEEPER-705.v2.patch we don't need to do any code change for bookkeeper client

[jira] [Commented] (BOOKKEEPER-705) handle session expire event in client

2015-05-24 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14557649#comment-14557649 ] Sijie Guo commented on BOOKKEEPER-705: -- patch is generated based on

[jira] [Commented] (BOOKKEEPER-705) handle session expire event in client

2015-05-23 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14557634#comment-14557634 ] Sijie Guo commented on BOOKKEEPER-705: -- split the task as what Ivan suggested.

[jira] [Updated] (BOOKKEEPER-707) handle session expire in hub server

2015-05-24 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-707: - Issue Type: Technical task (was: Sub-task) handle session expire in hub server

[jira] [Commented] (BOOKKEEPER-760) Don't close PCBC proactively if bookies disappeared from zookeeper znodes.

2015-07-07 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616262#comment-14616262 ] Sijie Guo commented on BOOKKEEPER-760: -- [~fpj] since you had comments in this

[jira] [Comment Edited] (BOOKKEEPER-855) handle session expire event in bookie

2015-07-07 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616260#comment-14616260 ] Sijie Guo edited comment on BOOKKEEPER-855 at 7/7/15 6:33 AM:

[jira] [Commented] (BOOKKEEPER-687) Use static final Logger for hedwig related modules

2015-07-07 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14617173#comment-14617173 ] Sijie Guo commented on BOOKKEEPER-687: -- Yes. We'd like to have all the Loggers as

[jira] [Commented] (BOOKKEEPER-861) TestZooKeeperClient is buggy

2015-08-11 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14692782#comment-14692782 ] Sijie Guo commented on BOOKKEEPER-861: -- [~fpj] two comments: {code} +

[jira] [Commented] (BOOKKEEPER-860) Enhance client API

2015-07-29 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14646899#comment-14646899 ] Sijie Guo commented on BOOKKEEPER-860: -- requiring a passwd and digest type

[jira] [Commented] (BOOKKEEPER-817) Bookie: LRU FileInfo Eviction Policy

2015-07-31 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14649640#comment-14649640 ] Sijie Guo commented on BOOKKEEPER-817: -- we have a patch available in Twitter's

[jira] [Commented] (BOOKKEEPER-860) Enhance client API

2015-07-28 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645476#comment-14645476 ] Sijie Guo commented on BOOKKEEPER-860: -- [~ikelly] could you be more specific

[jira] [Commented] (BOOKKEEPER-860) Enhance client API

2015-07-29 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645536#comment-14645536 ] Sijie Guo commented on BOOKKEEPER-860: -- [~jujjuri][~ikelly] I think the

[jira] [Commented] (BOOKKEEPER-863) Potential resource leak with unclosed LedgerManager in BookieShell

2015-08-09 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14679253#comment-14679253 ] Sijie Guo commented on BOOKKEEPER-863: -- [~tedyu] I added you as the contributor

[jira] [Updated] (BOOKKEEPER-863) Potential resource leak with unclosed LedgerManager in BookieShell

2015-08-09 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-863: - Assignee: Ted Yu Potential resource leak with unclosed LedgerManager in BookieShell

[jira] [Commented] (BOOKKEEPER-863) Potential resource leak with unclosed LedgerManager in BookieShell

2015-08-09 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14679230#comment-14679230 ] Sijie Guo commented on BOOKKEEPER-863: -- [~tedyu] the fix looks good. could you

[jira] [Updated] (BOOKKEEPER-438) Move ledger id generation out of LedgerManager

2015-08-11 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-438: - Attachment: BOOKKEEPER-438.patch rebased [~tongyu]'s patch to latest master Move ledger id

[jira] [Commented] (BOOKKEEPER-862) Add tracing and stats to OrderedSafeExecutor for debugging slow tasks

2015-08-11 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14692778#comment-14692778 ] Sijie Guo commented on BOOKKEEPER-862: -- could any other committers review this?

[jira] [Updated] (BOOKKEEPER-862) Add tracing and stats to OrderedSafeExecutor for debugging slow tasks

2015-08-09 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-862: - Attachment: ose_stats-rebase.patch [~l4stewar] Leigh, I cleaned up your patch to remove

[jira] [Updated] (BOOKKEEPER-687) Use static final Logger for hedwig related modules

2015-07-16 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-687: - Fix Version/s: 4.4.0 Use static final Logger for hedwig related modules

[jira] [Commented] (BOOKKEEPER-687) Use static final Logger for hedwig related modules

2015-07-16 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14629282#comment-14629282 ] Sijie Guo commented on BOOKKEEPER-687: -- Thanks [~agarg1986] Use static final

[jira] [Commented] (BOOKKEEPER-853) Use integer for entry log id

2015-07-20 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634384#comment-14634384 ] Sijie Guo commented on BOOKKEEPER-853: -- [~agarg1986] no you can't convert ledger

[jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

2015-10-22 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968656#comment-14968656 ] Sijie Guo commented on BOOKKEEPER-867: -- the failed tests aren't related to this patch. the patch

[jira] [Commented] (BOOKKEEPER-841) Bookie should calculate ledgers map writing a new entry log file

2015-10-28 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979815#comment-14979815 ] Sijie Guo commented on BOOKKEEPER-841: -- Ping [~mmerli] > Bookie should calculate ledgers map

[jira] [Updated] (BOOKKEEPER-877) Script for generating patch for reviews

2015-11-12 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-877: - Attachment: BOOKKEEPER-877_2015-11-12_00:52:03.patch > Script for generating patch for

[jira] [Commented] (BOOKKEEPER-877) Script for generating patch for reviews

2015-11-12 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001860#comment-15001860 ] Sijie Guo commented on BOOKKEEPER-877: -- Updated reviewboard

[jira] [Commented] (BOOKKEEPER-438) Move ledger id generation out of LedgerManager

2015-11-12 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001916#comment-15001916 ] Sijie Guo commented on BOOKKEEPER-438: -- port the change from master to branch 4.3:

[jira] [Updated] (BOOKKEEPER-881) upgrade surefire plugin to 2.19

2015-11-12 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-881: - Attachment: BOOKKEEPER-881.patch attach a patch to upgrade the surefire version to 2.19 >

[jira] [Commented] (BOOKKEEPER-877) Script for generating patch for reviews

2015-11-12 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001853#comment-15001853 ] Sijie Guo commented on BOOKKEEPER-877: -- documented at

[jira] [Updated] (BOOKKEEPER-877) Script for generating patch for reviews

2015-11-12 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-877: - Attachment: BOOKKEEPER-877_2015-11-12_00:28:08.patch > Script for generating patch for

[jira] [Commented] (BOOKKEEPER-877) Script for generating patch for reviews

2015-11-12 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001837#comment-15001837 ] Sijie Guo commented on BOOKKEEPER-877: -- Updated reviewboard

[jira] [Updated] (BOOKKEEPER-877) Script for generating patch for reviews

2015-11-12 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-877: - Attachment: BOOKKEEPER-877_2015-11-12_00:26:23.patch > Script for generating patch for

[jira] [Commented] (BOOKKEEPER-438) Move ledger id generation out of LedgerManager

2015-11-12 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001914#comment-15001914 ] Sijie Guo commented on BOOKKEEPER-438: -- Created reviewboard

[jira] [Updated] (BOOKKEEPER-878) verify switching FlatLedgerManager to HierarchicalLedgerManager

2015-11-05 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-878: - Description: after BOOKKEEPER-438 is in, it is possible to switch FlatLedgerManager to

[jira] [Reopened] (BOOKKEEPER-438) Move ledger id generation out of LedgerManager

2015-11-06 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo reopened BOOKKEEPER-438: -- > Move ledger id generation out of LedgerManager >

[jira] [Commented] (BOOKKEEPER-588) SSL support

2015-11-06 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994139#comment-14994139 ] Sijie Guo commented on BOOKKEEPER-588: -- [~ikelly] do you think if you have time to regenerate the

[jira] [Commented] (BOOKKEEPER-438) Move ledger id generation out of LedgerManager

2015-11-06 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994143#comment-14994143 ] Sijie Guo commented on BOOKKEEPER-438: -- re-open this issue to port the change to 4.3.2 > Move

[jira] [Updated] (BOOKKEEPER-877) Script for generating patch for reviews

2015-11-04 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-877: - Attachment: BOOKKEEPER-877.patch > Script for generating patch for reviews >

[jira] [Commented] (BOOKKEEPER-876) meet some thread related issue in pre-commit test

2015-10-15 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959040#comment-14959040 ] Sijie Guo commented on BOOKKEEPER-876: -- the jenkins keeps 50 builds for 30 days. but it seems

[jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

2015-10-15 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14960128#comment-14960128 ] Sijie Guo commented on BOOKKEEPER-867: -- [~jujjuri] could you generate the patch with

[jira] [Commented] (BOOKKEEPER-867) New Client API to allow applications pass-in EntryId.

2015-10-15 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14960130#comment-14960130 ] Sijie Guo commented on BOOKKEEPER-867: -- the patch looks good to me. +1 > New Client API to allow

[jira] [Commented] (BOOKKEEPER-865) provide a simple way to compress the content in each Entry of EntryLogger

2015-10-15 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14960170#comment-14960170 ] Sijie Guo commented on BOOKKEEPER-865: -- compressing an single entry might not help a lot. I think

  1   2   3   4   5   >