zhaijack opened a new pull request #424: Issue 414: use a clone of baseconf in new ServerConfiguration(baseConf) URL: https://github.com/apache/bookkeeper/pull/424 Descriptions of the changes in this PR: This PR fix Issue #414 , and in the comments of that issue contains the anysis of the bug. Main changes: - Privde a clone of baseConf while do loadconf(baseConf), so make baseConf and newConf work independently. - Remove 'loadConf(Configuration otherConf) ', since Configuration is an interface in common-configs and not have a clone method. --- Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [X] Make sure the PR title is formatted like: `<Issue # or BOOKKEEPER-#>: Description of pull request` `e.g. Issue 123: Description ...` `e.g. BOOKKEEPER-1234: Description ...` - [ ] Make sure tests pass via `mvn clean apache-rat:check install findbugs:check`. - [X] Replace `<Issue # or BOOKKEEPER-#>` in the title with the actual Issue/JIRA number. --- ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
