+1,
- verified both packages checksum ( asc and sha1 all good)
- the source package build and test all run successfully.
- in binary package, bin/bookkeeper and command localbookie runs well.
On Tue, Apr 3, 2018 at 9:20 PM, Enrico Olivelli wrote:
> +1 (binding)
>
> -
+1 (binding)
- Run manually basic tests with local bookie (on Fedora, with jdk8)
- Packaged bookkeeper-server.jar into real application (with known java9
issues with BK) and run cleanly on jdk10
- Verified artifacts and signatures on staging repository
Enrico
2018-04-03 15:17 GMT+02:00 Ivan
+1 lgtm
RAT, FINDBUGS & TESTS:
Runs cleanly. I had -Dsurefire.rerunFailingTestsCount=2 set, but I
don't think anything even flaked.
Minor issue: Vertx http tests expect 8080 to be free
SHA1 & SIGs:
Good.
LICENSE & NOTICE:
Nothing changed since 4.6.1, so looks good.
Minor: Copyright in
Hi everyone,
Please review and vote on the release candidate #2 for the version 4.6.2,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)
The complete staging area is available for your review, which includes:
* Release notes [1]
* The