Re: [DISCUSS] Deprecate FlatLedgerManager

2018-02-02 Thread Sijie Guo
Sent out a PR for this: https://github.com/apache/bookkeeper/pull/1115 Please take a look. - Sijie On Thu, Feb 1, 2018 at 2:50 PM, Sijie Guo wrote: > > On Thu, Feb 1, 2018 at 2:22 PM Enrico Olivelli > wrote: > >> Il gio 1 feb 2018, 22:43 Ivan Kelly ha scritto: >> >> > > well I don't think it

Re: [DISCUSS] Deprecate FlatLedgerManager

2018-02-01 Thread Sijie Guo
On Thu, Feb 1, 2018 at 2:22 PM Enrico Olivelli wrote: > Il gio 1 feb 2018, 22:43 Ivan Kelly ha scritto: > > > > well I don't think it is an easy effort to upgrade from flat ledger > > manager > > > to hierarchical ledger manager. There was a huge long discussion about > > this > > > migration 2-

Re: [DISCUSS] Deprecate FlatLedgerManager

2018-02-01 Thread Sijie Guo
The major concern was about id generation. Yes if you take the cluster down, you can do it easily. But it is not really useful then. So my take is not to support it at all. It is not worth spending time and energy on it. Sijie On Thu, Feb 1, 2018 at 1:43 PM Ivan Kelly wrote: > > well I don't t

Re: [DISCUSS] Deprecate FlatLedgerManager

2018-02-01 Thread Enrico Olivelli
Il gio 1 feb 2018, 22:43 Ivan Kelly ha scritto: > > well I don't think it is an easy effort to upgrade from flat ledger > manager > > to hierarchical ledger manager. There was a huge long discussion about > this > > migration 2-3 years ago. > I remember one of my first questions as an user was a

Re: [DISCUSS] Deprecate FlatLedgerManager

2018-02-01 Thread Ivan Kelly
> well I don't think it is an easy effort to upgrade from flat ledger manager > to hierarchical ledger manager. There was a huge long discussion about this > migration 2-3 years ago. Do you recall where the discussion was? JIRA or ML? Superficially it seems like a simple operation if the cluster i

Re: [DISCUSS] Deprecate FlatLedgerManager

2018-02-01 Thread Sijie Guo
On Thu, Feb 1, 2018 at 12:20 PM, Ivan Kelly wrote: > +1 > > Flat is an vestigial. Prereq to removal is a tool for upgrading ledger > metadata. > well I don't think it is an easy effort to upgrade from flat ledger manager to hierarchical ledger manager. There was a huge long discussion about this

Re: [DISCUSS] Deprecate FlatLedgerManager

2018-02-01 Thread Venkateswara Rao Jujjuri
+1 On Thu, Feb 1, 2018 at 12:20 PM, Ivan Kelly wrote: > +1 > > Flat is an vestigial. Prereq to removal is a tool for upgrading ledger > metadata. > > -Ivan > > On Thu, Feb 1, 2018 at 8:14 PM, Sijie Guo wrote: > > Hi all, > > > > `FlatLedgerManager` is not useful at production and most of the >

Re: [DISCUSS] Deprecate FlatLedgerManager

2018-02-01 Thread Ivan Kelly
+1 Flat is an vestigial. Prereq to removal is a tool for upgrading ledger metadata. -Ivan On Thu, Feb 1, 2018 at 8:14 PM, Sijie Guo wrote: > Hi all, > > `FlatLedgerManager` is not useful at production and most of the production > environment I knew don't use `FlatLedgerManager`. But the default