[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/285#discussion_r77509799 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/http/executor/apacheclient/HttpExecutorImpl.java --- @@ -0,0 +1,113 @@ +/* + *

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/285#discussion_r77512748 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/http/executor/apacheclient/HttpResponseWrapper.java --- @@ -0,0 +1,109 @@ +/*

[GitHub] brooklyn-server pull request #319: Clean up duplicated code in JcloudsLocati...

Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/319#discussion_r77519756 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/NetworkingEffectors.java --- @@ -65,38 +64,28 @@

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/285#discussion_r77501984 --- Diff: core/src/main/java/org/apache/brooklyn/util/http/executor/HttpExecutorFactoryImpl.java --- @@ -0,0 +1,75 @@ +/* + * Licensed to

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/285#discussion_r77506454 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/http/executor/HttpRequest.java --- @@ -0,0 +1,130 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #319: Clean up duplicated code in JcloudsLocati...

Github user duncangrant commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/319#discussion_r77517736 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/NetworkingEffectors.java --- @@ -65,38 +64,28 @@

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/285#discussion_r77500841 --- Diff: core/src/main/java/org/apache/brooklyn/location/byon/ByonLocationResolver.java --- @@ -108,6 +109,7 @@ protected ConfigBag

[GitHub] brooklyn-server issue #319: Clean up duplicated code in JcloudsLocationCusto...

Github user duncangrant commented on the issue: https://github.com/apache/brooklyn-server/pull/319 Why are you using the SharedLocationSecurityGroupCustomizer in NetworkingEffectors? The SharedLocationSecurityGroupCustomizer is intended as a cut-down

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/285#discussion_r77500324 --- Diff: core/src/main/java/org/apache/brooklyn/feed/http/HttpFeed.java --- @@ -331,52 +366,62 @@ protected void preStart() { }

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/285#discussion_r77501296 --- Diff: core/src/main/java/org/apache/brooklyn/util/http/executor/HttpExecutorFactoryImpl.java --- @@ -0,0 +1,75 @@ +/* + * Licensed to

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/285#discussion_r77511829 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/http/executor/apacheclient/HttpExecutorImpl.java --- @@ -0,0 +1,113 @@ +/* + *

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/285#discussion_r77511724 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/http/executor/apacheclient/HttpExecutorImpl.java --- @@ -0,0 +1,106 @@ +/* + *

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/285#discussion_r77499318 --- Diff: core/src/main/java/org/apache/brooklyn/core/location/AbstractLocation.java --- @@ -718,6 +719,35 @@ public boolean removeChild(Location

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/285#discussion_r77500994 --- Diff: core/src/main/java/org/apache/brooklyn/util/http/executor/HttpExecutorFactory.java --- @@ -0,0 +1,29 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #319: Clean up duplicated code in JcloudsLocati...

GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-server/pull/319 Clean up duplicated code in JcloudsLocationCustomizers Unite the code from https://github.com/apache/brooklyn-server/pull/276 and https://github.com/apache/brooklyn-server/pull/292

[GitHub] brooklyn-server pull request #319: Clean up duplicated code in JcloudsLocati...

Github user duncangrant commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/319#discussion_r77518183 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java --- @@

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

Github user ygy closed the pull request at: https://github.com/apache/brooklyn-server/pull/285 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-server pull request #319: Clean up duplicated code in JcloudsLocati...

Github user duncangrant commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/319#discussion_r77522771 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/InboundPortsJcloudsLocationCustomizer.java --- @@

[GitHub] brooklyn-server pull request #319: Clean up duplicated code in JcloudsLocati...

Github user duncangrant commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/319#discussion_r77539548 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java --- @@

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/285#discussion_r77546852 --- Diff: core/src/main/java/org/apache/brooklyn/feed/http/HttpFeed.java --- @@ -407,14 +410,26 @@ private HttpToolResponse

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

GitHub user ygy reopened a pull request: https://github.com/apache/brooklyn-server/pull/285 Adding HttpExecutor to be used for interchangeable implementations You can merge this pull request into a Git repository by running: $ git pull https://github.com/ygy/brooklyn-server

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

GitHub user ygy reopened a pull request: https://github.com/apache/brooklyn-server/pull/285 Adding HttpExecutor to be used for interchangeable implementations You can merge this pull request into a Git repository by running: $ git pull https://github.com/ygy/brooklyn-server

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

Github user ygy closed the pull request at: https://github.com/apache/brooklyn-server/pull/285 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-server issue #285: Adding HttpExecutor to be used for interchangeab...

Github user ygy commented on the issue: https://github.com/apache/brooklyn-server/pull/285 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/285#discussion_r77537414 --- Diff: core/src/main/java/org/apache/brooklyn/core/location/AbstractLocation.java --- @@ -718,6 +719,35 @@ public boolean removeChild(Location

[GitHub] brooklyn-server issue #125: [BROOKLYN-343] A test to illustrate a failing ca...

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/125 Marked it as Broken. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Created] (BROOKLYN-344) An entity can't be a member of 2 shared security groups

Duncan Grant created BROOKLYN-344: - Summary: An entity can't be a member of 2 shared security groups Key: BROOKLYN-344 URL: https://issues.apache.org/jira/browse/BROOKLYN-344 Project: Brooklyn

[GitHub] brooklyn-server pull request #125: [BROOKLYN-343] A test to illustrate a fai...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/125 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (BROOKLYN-343) Cross-referencing catalog items fails

[ https://issues.apache.org/jira/browse/BROOKLYN-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15465162#comment-15465162 ] ASF GitHub Bot commented on BROOKLYN-343: - Github user neykov commented on the issue:

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/285#discussion_r77535388 --- Diff: core/src/main/java/org/apache/brooklyn/feed/http/HttpFeed.java --- @@ -331,52 +366,55 @@ protected void preStart() { }

[GitHub] brooklyn-server issue #285: Adding HttpExecutor to be used for interchangeab...

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/285 Almost there, only concerned about the content length being available on responses. I'd like to see tests covering the extensions config key in jclouds and byon locations - can be done

[GitHub] brooklyn-server issue #319: Clean up duplicated code in JcloudsLocationCusto...

Github user duncangrant commented on the issue: https://github.com/apache/brooklyn-server/pull/319 How do I test this? I tried: `location: aws-central-centos7 services: - type: org.apache.brooklyn.entity.software.base.EmptySoftwareProcess

[GitHub] brooklyn-server pull request #319: Clean up duplicated code in JcloudsLocati...

Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/319#discussion_r77530894 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java --- @@ -72,9

[jira] [Commented] (BROOKLYN-343) Cross-referencing catalog items fails

[ https://issues.apache.org/jira/browse/BROOKLYN-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15465166#comment-15465166 ] ASF GitHub Bot commented on BROOKLYN-343: - Github user asfgit closed the pull request at:

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/285#discussion_r77536131 --- Diff: core/src/test/java/org/apache/brooklyn/util/http/executor/HttpExecutorImplTest.java --- @@ -0,0 +1,210 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #119: Add method HttpFeed.Builder#credentials(C...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/119#discussion_r77529695 --- Diff: core/src/main/java/org/apache/brooklyn/feed/http/HttpFeed.java --- @@ -197,6 +197,10 @@ public Builder credentials(String username, String

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/285#discussion_r77535728 --- Diff: core/src/main/java/org/apache/brooklyn/util/http/executor/HttpExecutorFactoryImpl.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to

[jira] [Created] (BROOKLYN-343) Cross-referencing catalog items fails

Svetoslav Neykov created BROOKLYN-343: - Summary: Cross-referencing catalog items fails Key: BROOKLYN-343 URL: https://issues.apache.org/jira/browse/BROOKLYN-343 Project: Brooklyn Issue

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/285#discussion_r77535007 --- Diff: core/src/main/java/org/apache/brooklyn/feed/http/HttpFeed.java --- @@ -331,52 +366,55 @@ protected void preStart() { }

Build failed in Jenkins: brooklyn-master-build #393

See -- [...truncated 29896 lines...] [INFO] Brooklyn CM Ansible SKIPPED [INFO] Brooklyn CM Integration Root ... SKIPPED [INFO] Brooklyn Network

[jira] [Updated] (BROOKLYN-344) An entity can't be a member of 2 shared security groups

[ https://issues.apache.org/jira/browse/BROOKLYN-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Grant updated BROOKLYN-344: -- Description: This yaml fails: {noformat} location: jclouds:aws-ec2:us-east-1: imageId:

[GitHub] brooklyn-server issue #319: Clean up duplicated code in JcloudsLocationCusto...

Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/319 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] brooklyn-server pull request #285: Adding HttpExecutor to be used for interc...

Github user ygy closed the pull request at: https://github.com/apache/brooklyn-server/pull/285 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature