[GitHub] brooklyn-server pull request #348: Fix SharedLocationSecurityGroupCustomizer...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/348 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #349: Fix or disable integration tests

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/349 This only touches tests, so merging now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] brooklyn-server pull request #349: Fix or disable integration tests

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/349 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-client issue #28: Updated resteasy version

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-client/pull/28 @Graeme-Miller Can you explain why we're upgrading to resteasy `3.0.14.Final`? There is a `3.0.19.Final` available - why not upgrade to that? --- TL;DR we don't bundle

Build failed in Jenkins: brooklyn-master-windows #297

See -- [...truncated 30451 lines...] Failed tests: VanillaSoftwareProcessTest.testSkipInstallation:156 postCustomizeCommand not matched by any commands in ExecCmd[: [export

[GitHub] brooklyn-server pull request #350: Fixes for JcloudsLocation

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/350 Fixes for JcloudsLocation See individual commits for details. Copied below for your convenience: ``` commit aba3f0980d7adfa1d7e9bf601c2ecbf1329a5a9e Author: Aled Sage

[GitHub] brooklyn-server pull request #331: Fix some memory leaks and better memory u...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/331#discussion_r80221038 --- Diff: camp/camp-base/src/main/java/org/apache/brooklyn/camp/spi/pdp/AssemblyTemplateConstructor.java --- @@ -40,15 +40,22 @@ public

[GitHub] brooklyn-server pull request #331: Fix some memory leaks and better memory u...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/331#discussion_r80223403 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/javalang/MemoryUsageTracker.java --- @@ -68,5 +87,76 @@ public long getBytesUsed() {

[GitHub] brooklyn-server pull request #331: Fix some memory leaks and better memory u...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/331#discussion_r80226051 --- Diff: utils/common/src/test/java/org/apache/brooklyn/util/javalang/MemoryUsageTrackerTest.java --- @@ -81,7 +81,39 @@ private long

[GitHub] brooklyn-server pull request #331: Fix some memory leaks and better memory u...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/331#discussion_r80222098 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/EntitiesYamlTest.java --- @@ -1067,4 +1069,35 @@ protected String

Re: Pattern for allowing SSH from one host to others

Alex, sounds good. Sam, I agree that in general it would also be useful to have a sensor that polls just once (or polls repeatedly until successful, such as the first non-zero exit code). Another thing that would be useful (in variants of this situation) is a

[GitHub] brooklyn-server pull request #331: Fix some memory leaks and better memory u...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/331#discussion_r80220422 --- Diff: camp/camp-base/src/main/java/org/apache/brooklyn/camp/spi/collection/BasicResourceLookup.java --- @@ -43,6 +47,11 @@ public synchronized

[GitHub] brooklyn-server pull request #338: Not for merge, work in progress - testCat...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/338#discussion_r80220390 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/AbstractManagementContext.java --- @@ -128,20 +128,18 @@ private static

[GitHub] brooklyn-server pull request #331: Fix some memory leaks and better memory u...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/331#discussion_r80221440 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/BrooklynCampPlatform.java --- @@ -61,6 +63,11 @@ public

[GitHub] brooklyn-server pull request #331: Fix some memory leaks and better memory u...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/331#discussion_r80223669 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/BrooklynGarbageCollector.java --- @@ -196,7 +210,13 @@ public void

[GitHub] brooklyn-server pull request #331: Fix some memory leaks and better memory u...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/331#discussion_r80225179 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/javalang/MemoryUsageTracker.java --- @@ -68,5 +87,76 @@ public long getBytesUsed() {

[GitHub] brooklyn-server pull request #342: Load usage listeners from bundles

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/342 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #342: Load usage listeners from bundles

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/342 LGTM, thanks for fixing `JCloudsLocation` as well. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] brooklyn-server pull request #331: Fix some memory leaks and better memory u...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/331#discussion_r80221679 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/BrooklynCampPlatform.java --- @@ -61,6 +63,11 @@ public

[GitHub] brooklyn-server pull request #346: Fix LocalUsageManagerTest

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/346 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #346: Fix LocalUsageManagerTest

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/346 Merging now as it's causing a compilation error for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] brooklyn-server pull request #347: Add more tests to TemplateProcessorTest

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/347 Add more tests to TemplateProcessorTest Only adds tests, so pretty trivial and safe to merge once jenkins confirms it works. You can merge this pull request into a Git repository by

[GitHub] brooklyn-server pull request #345: Fixed compilation issue in LocalUsageMana...

GitHub user Graeme-Miller opened a pull request: https://github.com/apache/brooklyn-server/pull/345 Fixed compilation issue in LocalUsageManagerTest You can merge this pull request into a Git repository by running: $ git pull https://github.com/Graeme-Miller/brooklyn-server

[GitHub] brooklyn-server pull request #345: Fixed compilation issue in LocalUsageMana...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/345 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (BROOKLYN-349) NPE using yaml DSL in entity's "provisioning.properties"

[ https://issues.apache.org/jira/browse/BROOKLYN-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516474#comment-15516474 ] ASF GitHub Bot commented on BROOKLYN-349: - Github user aledsage commented on the issue:

[GitHub] brooklyn-server issue #341: BROOKLYN-349: fix DSL resolution in location

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/341 @ahgittin I've rebased this against master (now that #340 is merged), and confirmed `JcloudsRebindStubTest` still passes. Can you review please? --- If your project is set up for

[GitHub] brooklyn-server issue #331: Fix some memory leaks and better memory usage lo...

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/331 The idea behind `MemoryUsageTracker. forceClearSoftReferences()` makes sense, but feels a little scary! The code looks fine though. It will never be enabled in production, only when

[GitHub] brooklyn-server issue #344: JmxService tests marked as integration

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/344 Marking tests integration is same as deleting them right now so I'd be wary of such changes (integration tests don't get run, let alone on regular basis). I was able to reproduce this by

[GitHub] brooklyn-server issue #346: Fix LocalUsageManagerTest

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/346 Already fixed in https://github.com/apache/brooklyn-server/pull/345 @aledsage --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] brooklyn-server pull request #346: Fix LocalUsageManagerTest

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/346 Fix LocalUsageManagerTest `shouldSkipOnBoxBaseDirResolution` return type was changed from boolean to Boolean in super-class. You can merge this pull request into a Git repository by

[GitHub] brooklyn-server issue #323: Minor tweaks to utils and new TypeRegistry proce...

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/323 @ahgittin (cc @neykov) I haven't looked thoroughly enough at the `BrooklynTypeRegistry` and `RegisteredType` before, to give a proper review of this. It would be useful for me

[GitHub] brooklyn-server issue #346: Fix LocalUsageManagerTest

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/346 @neykov ah, thanks! Unfortunately I only spotted your comment after merging this PR. Bizarrely, git has allowed both PRs to be merged without complaining about a conflict, and without

Jenkins build is back to normal : brooklyn-master-build #420

See

[GitHub] brooklyn-server issue #348: Fix SharedLocationSecurityGroupCustomizer.udpPor...

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/348 @duncangrant or @bostko - can you review this trivial one-line fix please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

Build failed in Jenkins: brooklyn-master-windows #295

See -- [...truncated 48715 lines...] [INFO] Brooklyn Dist Karaf Features ... SKIPPED [INFO] Brooklyn Karaf Distribution SKIPPED [INFO] Brooklyn Karaf

[GitHub] brooklyn-server pull request #348: Fix SharedLocationSecurityGroupCustomizer...

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/348 Fix SharedLocationSecurityGroupCustomizer.udpPortRanges Previously it was ImmutableList so could not be used from YAML; changed to a normal List. You can merge this pull request into

[GitHub] brooklyn-server pull request #349: Fix or disable integration tests

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/349 Fix or disable integration tests See individual commits for further description (copy-pasted here for your convenience): ``` commit 384de14a710e1bbbccebd83a0f61ab158f29f116

Build failed in Jenkins: brooklyn-master-windows #296

See -- [...truncated 49469 lines...] [INFO] hello-world-sql-webapp Maven Webapp ... SKIPPED [INFO] Brooklyn Simple Web Cluster Example ... SKIPPED [INFO] Brooklyn Global

[GitHub] brooklyn-server issue #348: Fix SharedLocationSecurityGroupCustomizer.udpPor...

Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/348 Looks good. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and