Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/521#discussion_r100394340
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/DslDeferredFunctionCall.java
---
@@ -62,7 +62,7 @@ public
GitHub user Graeme-Miller opened a pull request:
https://github.com/apache/brooklyn-server/pull/554
Ensured the \n character is escaped when escaping a string for bash
You can merge this pull request into a Git repository by running:
$ git pull
Github user grkvlt commented on the issue:
https://github.com/apache/brooklyn-server/pull/546
@aledsage the use case in mind was to sequentially number across multiple
clusters (i.e a fabric spread around several locations)
---
If your project is set up for it, you can reply to this
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-docs/pull/148
Adds doc for urlEncode DSL
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-docs doc-for-urlEncode
Alternatively you
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/148#discussion_r100338415
--- Diff: guide/yaml/yaml-reference.md ---
@@ -213,6 +213,9 @@ concise DSL defined here:
`$brooklyn:root()`.
*
GitHub user mikezaccardo opened a pull request:
https://github.com/apache/brooklyn-server/pull/555
Add DurationPredicates
Adds `DurationPredicates` which contain `Predicate`s for common `Duration`
comparison operations.
You can merge this pull request into a Git repository by
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/551
@neykov agreed - I stayed well clear of `URLEncoder` originally for that
reason, and tried to use guava's
[
https://issues.apache.org/jira/browse/BROOKLYN-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859726#comment-15859726
]
ASF GitHub Bot commented on BROOKLYN-421:
-
Github user aledsage commented on the issue:
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/554
@Graeme-Miller That's one of the scenarios where adding a new line will
lead to unexpected results.
doing
```
export
Github user drigodwin commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/148#discussion_r100338476
--- Diff: guide/yaml/yaml-reference.md ---
@@ -213,6 +213,9 @@ concise DSL defined here:
`$brooklyn:root()`.
*
[
https://issues.apache.org/jira/browse/BROOKLYN-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859535#comment-15859535
]
ASF GitHub Bot commented on BROOKLYN-408:
-
GitHub user tbouron opened a pull request:
Github user drigodwin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/554#discussion_r100288570
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/text/StringEscapes.java ---
@@ -131,6 +131,8 @@ private static void
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-ui/pull/41
[BROOKLYN-408] Add CSRF header on the swagger page
Since Brooklyn checks for CSRF header for every POST/PUT requests, the
relevant methods didn't work anymore on the swagger UI page.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/554
FYI I tried this:
```
tee file1 <<-EOF
line1
line2
EOF
MYVAR=`cat file1`
echo $MYVAR
# shows "line1 line2" - note the special char shown as space
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/554
`\n` Doesn't behave as expected in most bash operations. It will just be
treated as the verbatim text.
It could lead to weird errors later one so I'd says it's better to fail
early if
Github user googlielmo commented on the issue:
https://github.com/apache/brooklyn-server/pull/516
Rebased on master (not squashed)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Graeme-Miller commented on the issue:
https://github.com/apache/brooklyn-server/pull/554
@aledsage has pointed out a way to get around the problem I am having, so I
no longer need this PR. However, I think it might still be useful
@neykov, the use case here is
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/521#discussion_r100310679
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/DslDeferredFunctionCall.java
---
@@ -99,48 +99,81 @@ public
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/521#discussion_r100310271
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/DslDeferredFunctionCall.java
---
@@ -80,14 +80,14 @@ public
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/521#discussion_r100310194
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/DslDeferredFunctionCall.java
---
@@ -62,7 +62,7 @@ public
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/551
I think it only escapes illegal characters, not reserved ones, so
`q1=my=my-value` won't be changed - it assumes you know what you are
doing. Let's see...
This passes:
```
[
https://issues.apache.org/jira/browse/BROOKLYN-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859866#comment-15859866
]
ASF GitHub Bot commented on BROOKLYN-421:
-
Github user geomacy commented on the issue:
[
https://issues.apache.org/jira/browse/BROOKLYN-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859869#comment-15859869
]
ASF GitHub Bot commented on BROOKLYN-421:
-
Github user geomacy commented on the issue:
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/551
I hesitate to suggest this but one "creative" use of URI could be to do the
encoding along the lines of the above, e.g.
```
@Test
public void testURLEncode() throws
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/551
I'm not really suggesting we do this by the way, just musing; it's too
creative by half for me!I still stick with my point above agreeing that
it's best to expose a URL builder DSL - by
[
https://issues.apache.org/jira/browse/BROOKLYN-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859878#comment-15859878
]
ASF GitHub Bot commented on BROOKLYN-421:
-
Github user geomacy commented on the issue:
Github user grkvlt commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/555#discussion_r100346521
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/time/DurationPredicates.java
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/BROOKLYN-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859766#comment-15859766
]
ASF GitHub Bot commented on BROOKLYN-421:
-
Github user neykov commented on the issue:
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/551
I guess
[yes](https://github.com/mikaelhg/urlbuilder/blob/a0aeee72abd503ae22a0803e7cd625aaf846085f/src/test/java/io/mikael/urlbuilder/SimpleUrlTest.java#L30-L44)
- the colon is not escaped
Github user grkvlt commented on the issue:
https://github.com/apache/brooklyn-server/pull/555
@mikezaccardo remember we need tests for these too!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
[
https://issues.apache.org/jira/browse/BROOKLYN-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859810#comment-15859810
]
ASF GitHub Bot commented on BROOKLYN-421:
-
Github user geomacy commented on the issue:
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/551
+1 to the idea of exposing the builder, which makes it unambiguous as to
how to interpret each bit. I think if you do that then you can get away
without the external library and just use
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/551
@geomacy It's not completely clear for me. If one of the query values
contains a `&` how does the escaping work with the `URI` constructor? For
example `q1=my=my-value`.
---
If your
[
https://issues.apache.org/jira/browse/BROOKLYN-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859832#comment-15859832
]
ASF GitHub Bot commented on BROOKLYN-421:
-
Github user neykov commented on the issue:
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/521#discussion_r100361187
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/DslDeferredFunctionCall.java
---
@@ -99,48 +99,81 @@ public
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/521
@aledsage Did you try the blueprint I posted above? I couldn't make it
work, I'm guessing I missed something obvious
---
If your project is set up for it, you can reply to this email and
36 matches
Mail list logo
