[GitHub] brooklyn-library issue #34: Fix sed command that update the MySQL configurat...

2016-06-15 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-library/pull/34 @aledsage I encountered issues in all environments, any cloud. Even though the password is changed at the MySQL level, it never updates the `mymysql.cnf` file, probably because of absence

[GitHub] brooklyn-library pull request #34: Fix sed command that update the MySQL con...

2016-06-15 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/34#discussion_r67155972 --- Diff: software/database/src/main/java/org/apache/brooklyn/entity/database/mysql/MySqlNodeEffectors.java --- @@ -75,7 +75,7 @@ public Void call

[GitHub] incubator-brooklyn pull request: Generate config/effector descript...

2016-01-29 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1176#issuecomment-176809380 @bostko Didn't notice that. Let's not reintroduce a slow process then. However, I quite like the @iyovcheva's idea of generate the `JS

[GitHub] incubator-brooklyn pull request: Generate config/effector descript...

2016-01-27 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1176#discussion_r50992238 --- Diff: brooklyn-server/server-cli/src/main/java/org/apache/brooklyn/cli/ItemLister.java --- @@ -98,88 +115,150 @@ public Void call() throws

[GitHub] brooklyn-docs pull request: Add mention of location wizard into th...

2016-03-18 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-docs/pull/30 Add mention of location wizard into the documentation Related to https://github.com/apache/brooklyn-ui/pull/17 You can merge this pull request into a Git repository by running: $ git

[GitHub] brooklyn-ui pull request: Fix typo

2016-03-18 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/19 Fix typo You can merge this pull request into a Git repository by running: $ git pull https://github.com/tbouron/brooklyn-ui master Alternatively you can review and apply these changes

[GitHub] brooklyn-docs pull request: Add mention of location wizard into th...

2016-03-19 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-docs/pull/30#issuecomment-197415838 To be merged **after** https://github.com/apache/brooklyn-ui/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] brooklyn-dist pull request: Add UI library reference for licensing...

2016-03-19 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-dist/pull/22 Add UI library reference for licensing purposes To be merged **after** https://github.com/apache/brooklyn-ui/pull/17 You can merge this pull request into a Git repository by running

[GitHub] brooklyn-ui pull request: Location wizard

2016-03-19 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/17 Location wizard Add a location wizard: ![wizard](https://cloud.githubusercontent.com/assets/2082759/13812320/77100e60-eb73-11e5-9587-fbe901d599e3.png) This will be display

[GitHub] brooklyn-ui pull request: Location wizard

2016-03-19 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/17#issuecomment-197405281 Related PR: https://github.com/apache/brooklyn-server/pull/62 => To be merge atfer this one. --- If your project is set up for it, you can reply to this em

[GitHub] brooklyn-ui pull request: Location wizard

2016-03-19 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/17#issuecomment-198286661 @ahgittin Pushed latest changes. Hopefully it includes everything now. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] brooklyn-ui pull request: Location wizard

2016-03-19 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/17#issuecomment-197965666 @ahgittin autocomplete => the screenshot I have taken is one Chrome... Would be better if other people could test it then. --- If your project is set

[GitHub] brooklyn-ui pull request: Hotfix: Removing contains method from th...

2016-04-07 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/25#issuecomment-206855774 > The code causing the problem is called only when loggerEnabled is true. Suggest disabling logging instead. Even though, not removing the `conta

[GitHub] brooklyn-ui pull request: Hotfix: Removing contains method from th...

2016-04-07 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/25#issuecomment-206866563 > My point is that with loggerEnabled=false the Array prototype will not be patched with contains, so no need to delete it. My bad, I get what

[GitHub] brooklyn-ui pull request: Hotfix: Removing contains method from th...

2016-04-07 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/25 Hotfix: Removing contains method from the Array prototype This avoids breaking other parts of the UI You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] brooklyn-ui pull request: Hotfix: Skip the creation of the contain...

2016-04-07 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/25#issuecomment-206872102 @neykov Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-ui pull request: BROOKLYN-244: Fix blueprint composer loa...

2016-04-06 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/23 BROOKLYN-244: Fix blueprint composer loading issue This load straight away CodeMirror when launching the composer for the composer tab, removing the requirement on loading the full list

[GitHub] brooklyn-server pull request: pull displayName from flags in Locat...

2016-04-11 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-server/pull/111#issuecomment-208343949 Tested, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-ui pull request: Update editor placeholder

2016-04-06 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/24 Update editor placeholder The text now makes it clear that users can use drag & drop to add text files' content into the editor ![brooklyn js rest client](h

[GitHub] brooklyn-ui pull request: BROOKLYN-244: Fix blueprint composer loa...

2016-04-06 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/23#issuecomment-206419817 Great, thank @aledsage! If it gets into 0.9.0, you might also want #24 --- If your project is set up for it, you can reply to this email and have your

[GitHub] brooklyn-ui pull request: Update editor placeholder

2016-04-06 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/24#issuecomment-206447871 The drag & drop feature is provided by CodeMirror. I'm not sure it can be customised, I'll need to check that. That being said, the content of the

[GitHub] brooklyn-ui pull request: Update editor placeholder

2016-04-06 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/24#issuecomment-206456324 We will probably have to cheat as the textarea is hidden by CodeMirror. AFAIK, we can still bound to those events but from the CodeMirror container rather than

[GitHub] brooklyn-docs pull request: Add mention of location wizard into th...

2016-03-19 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/30#discussion_r56475766 --- Diff: guide/ops/locations/index.md --- @@ -17,7 +17,8 @@ Brooklyn supports a wide range of locations: specifying already-existing hosts

[GitHub] brooklyn-ui pull request: Location wizard

2016-03-19 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/17#issuecomment-197946011 > maybe it's a huge time delay or my machine. for me it only popped up once and then vanished. other times i couldn't get anything to s

[GitHub] brooklyn-ui pull request: Improve catalog locations info and edita...

2016-03-19 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/18#issuecomment-198308800 The code looks good but - I cannot edit any locations I manually added. - properties don't show up for locations I manually added. It that normal

[GitHub] brooklyn-ui pull request: Improve catalog locations info and edita...

2016-03-19 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/18#issuecomment-198309051 Oh wait, do I need to run the server with https://github.com/apache/brooklyn-server/pull/70? --- If your project is set up for it, you can reply to this email

[GitHub] brooklyn-ui pull request: Location wizard

2016-03-19 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/17#issuecomment-197866956 Added the reference to `easy-autocomplete`, see my last commit --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] brooklyn-ui pull request: Location wizard

2016-03-19 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/17#issuecomment-197925582 Technical: - What is the issue with the autocomplete? Works ok after at least one character for me. Cosmetic: - Will change for all words in initial

[GitHub] brooklyn-ui pull request: Show error message on top of the YAML ed...

2016-03-23 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/21#discussion_r57142670 --- Diff: src/main/webapp/assets/tpl/editor/page.html --- @@ -47,12 +47,12 @@ Blueprint Composer

[GitHub] brooklyn-ui pull request: Show error message on top of the YAML ed...

2016-03-24 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/21#discussion_r57298808 --- Diff: src/main/webapp/assets/tpl/editor/page.html --- @@ -47,12 +47,12 @@ Blueprint Composer

[GitHub] brooklyn-ui pull request: Move jQuery code inside a closure manage...

2016-03-20 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/20 Move jQuery code inside a closure managed by require This is mainly to prevent javascript errors with jQuery not available when running Brooklyn from `BrooklynJavascriptGuiLauncher` You can

[GitHub] brooklyn-ui pull request: Update style of editor's error message

2016-03-30 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/22 Update style of editor's error message Follow up of my comment on #21 You can merge this pull request into a Git repository by running: $ git pull https://github.com/tbouron/brooklyn-ui

[GitHub] brooklyn-library pull request: Allow creating roles for PostgreSQL

2016-05-05 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/33#discussion_r62216594 --- Diff: software/database/src/main/java/org/apache/brooklyn/entity/database/postgresql/PostgreSqlSshDriver.java --- @@ -328,9 +340,39 @@ private

[GitHub] brooklyn-library pull request: Allow creating roles for PostgreSQL

2016-05-05 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/33#discussion_r62215974 --- Diff: software/database/src/main/java/org/apache/brooklyn/entity/database/postgresql/PostgreSqlNode.java --- @@ -90,6 +95,17

[GitHub] brooklyn-library pull request: Allow creating roles for PostgreSQL

2016-05-05 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/33#discussion_r62216578 --- Diff: software/database/src/main/java/org/apache/brooklyn/entity/database/postgresql/PostgreSqlSshDriver.java --- @@ -328,9 +340,39 @@ private

[GitHub] brooklyn-docs pull request: Update server-cli-reference.md

2016-05-05 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-docs/pull/54 Update server-cli-reference.md Fix a small typo within the `nohup` command You can merge this pull request into a Git repository by running: $ git pull https://github.com/tbouron

[GitHub] brooklyn-library pull request: Allow creating roles for PostgreSQL

2016-05-06 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/33#discussion_r62295255 --- Diff: software/database/src/main/java/org/apache/brooklyn/entity/database/postgresql/PostgreSqlSshDriver.java --- @@ -328,9 +340,39 @@ private

[GitHub] brooklyn-library pull request: Allow creating roles for PostgreSQL

2016-05-06 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/33#discussion_r62302857 --- Diff: software/database/src/main/java/org/apache/brooklyn/entity/database/postgresql/PostgreSqlSshDriver.java --- @@ -328,9 +340,39 @@ private

[GitHub] brooklyn-docs pull request: Update the tests documentation

2016-05-06 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-docs/pull/55 Update the tests documentation It explicitly says that the target for a test can be omitted if wrapped into a TestCase that already defines the target. Here is how it looks like

[GitHub] brooklyn-docs pull request: Update the tests documentation

2016-05-09 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/55#discussion_r62547620 --- Diff: guide/yaml/test/test-entities.md --- @@ -89,6 +93,10 @@ The `TestEffector` entity invokes the specified effector on a target entity

[GitHub] brooklyn-ui pull request: Show config values when jumping from App...

2016-05-25 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/27#discussion_r64540792 --- Diff: src/main/webapp/assets/js/view/application-add-wizard.js --- @@ -303,6 +303,7 @@ define([ }, previewStep:function

[GitHub] brooklyn-ui pull request: BROOKLYN-270: Location wizard generates ...

2016-05-25 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/28 BROOKLYN-270: Location wizard generates valid YAML for multiline fields This update the field `privateKeyFile` to `privateKeyData`. It also checks if a configuration key contains line

[GitHub] brooklyn-ui pull request: BROOKLYN-275: Location wizard generates ...

2016-05-25 Thread tbouron
Github user tbouron closed the pull request at: https://github.com/apache/brooklyn-ui/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-ui pull request: BROOKLYN-275: Location wizard generates ...

2016-05-25 Thread tbouron
Github user tbouron closed the pull request at: https://github.com/apache/brooklyn-ui/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-ui pull request: BROOKLYN-275: Location wizard generates ...

2016-05-25 Thread tbouron
GitHub user tbouron reopened a pull request: https://github.com/apache/brooklyn-ui/pull/28 BROOKLYN-275: Location wizard generates valid YAML for multiline fields This update the field `privateKeyFile` to `privateKeyData`. It also checks if a configuration key contains line

[GitHub] brooklyn-ui pull request: BROOKLYN-275: Location wizard generates ...

2016-05-25 Thread tbouron
GitHub user tbouron reopened a pull request: https://github.com/apache/brooklyn-ui/pull/28 BROOKLYN-275: Location wizard generates valid YAML for multiline fields This update the field `privateKeyFile` to `privateKeyData`. It also checks if a configuration key contains line

[GitHub] brooklyn-server issue #144: Allows for multiple deserialization class rename...

2017-02-07 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/144 Hey @nakomis, overloading the class deserialisation has been addressed in #492 but for **karaf edition** only. Do you also need it for the classic edition? In this case, could you rebase

[GitHub] brooklyn-server pull request #535: Add jclouds AzureComputeRateLimitModule t...

2017-01-25 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-server/pull/535 Add jclouds AzureComputeRateLimitModule to support provisioning retry for Azure ARM You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] brooklyn-server issue #535: Add jclouds AzureComputeRateLimitModule to suppo...

2017-01-25 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/535 @aledsage done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] brooklyn-docs pull request #147: Added known issues section to azure arm

2017-01-27 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/147#discussion_r98206142 --- Diff: guide/ops/locations/_azure-ARM.md --- @@ -94,3 +94,9 @@ The loginUser can be anything, as long as it's specified

[GitHub] brooklyn-ui pull request #42: Use the "itemType" to redirect the user to the...

2017-02-21 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/42 Use the "itemType" to redirect the user to the right page after a catalog import As for today, when a user submit catalog item(s), the UI redirects to the catalog page, not to

[GitHub] brooklyn-server issue #559: Activity api include background

2017-02-15 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/559 Thanks @ahgittin! Tested works great, LGTM. PS: Jenkins failure looks unrelated: ``` testCleanedCopiedPersistedState

[GitHub] brooklyn-server issue #558: BROOKLYN-433: regex/obj config key constraint in...

2017-02-13 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/558 @aledsage In that case, LGTM 👍 Would be great to follow up after this PR is merged to make the REST API return more information about the constraint (and modify the UI to react

[GitHub] brooklyn-ui pull request #41: [BROOKLYN-408] Add CSRF header on the swagger ...

2017-02-09 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/41 [BROOKLYN-408] Add CSRF header on the swagger page Since Brooklyn checks for CSRF header for every POST/PUT requests, the relevant methods didn't work anymore on the swagger UI page

[GitHub] brooklyn-server pull request #521: fix unexpected AddChildrenEffector behavi...

2017-02-09 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/521#discussion_r100310679 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/DslDeferredFunctionCall.java --- @@ -99,48 +99,81 @@ public

[GitHub] brooklyn-server pull request #521: fix unexpected AddChildrenEffector behavi...

2017-02-09 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/521#discussion_r100310271 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/DslDeferredFunctionCall.java --- @@ -80,14 +80,14 @@ public

[GitHub] brooklyn-server pull request #521: fix unexpected AddChildrenEffector behavi...

2017-02-09 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/521#discussion_r100310194 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/DslDeferredFunctionCall.java --- @@ -62,7 +62,7 @@ public

[GitHub] brooklyn-server issue #521: fix unexpected AddChildrenEffector behaviour and...

2017-02-09 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/521 @aledsage Did you try the blueprint I posted above? I couldn't make it work, I'm guessing I missed something obvious --- If your project is set up for it, you can reply to this email

[GitHub] brooklyn-server pull request #561: better presentation for sensor publishing...

2017-02-16 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/561#discussion_r101533579 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalSubscriptionManager.java --- @@ -111,7 +115,7 @@ public long

[GitHub] brooklyn-server pull request #561: better presentation for sensor publishing...

2017-02-16 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/561#discussion_r101534376 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalSubscriptionManager.java --- @@ -237,42 +212,85 @@ public synchronized

[GitHub] brooklyn-server pull request #561: better presentation for sensor publishing...

2017-02-16 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/561#discussion_r101534679 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalSubscriptionManager.java --- @@ -237,42 +212,85 @@ public synchronized

[GitHub] brooklyn-server pull request #561: better presentation for sensor publishing...

2017-02-16 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/561#discussion_r101535119 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalSubscriptionManager.java --- @@ -237,42 +212,85 @@ public synchronized

[GitHub] brooklyn-server issue #561: better presentation for sensor publishing tasks

2017-02-16 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/561 Also great to have a `SENSOR` tag, this will allows us to do filtering more easily. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] brooklyn-server issue #562: Provide a scratchpad area per management context

2017-02-16 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/562 @neykov Agree, having this warning within the docs seems to be the way to go. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] brooklyn-docs issue #150: Add deprecated functionality which can't be commun...

2017-02-16 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-docs/pull/150 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] brooklyn-library pull request #34: Fix sed command that update the MySQL con...

2017-02-15 Thread tbouron
Github user tbouron closed the pull request at: https://github.com/apache/brooklyn-library/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] brooklyn-library issue #34: Fix sed command that update the MySQL configurat...

2017-02-15 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-library/pull/34 Close in favor or #76 (my PR wasn't really working anyway) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] brooklyn-server issue #558: BROOKLYN-433: regex/obj config key constraint in...

2017-02-13 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/558 @neykov Depends how that is currently implemented: are we doing this validation client or server side? Although in this particular case, doing this validation client side would require

[GitHub] brooklyn-server issue #525: openstack-swift support

2017-01-18 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/525 @aledsage Jenkins is happy now 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-server pull request #525: openstack-swift support

2017-01-18 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/525#discussion_r96591689 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/core/mgmt/persist/jclouds/JcloudsBlobStoreBasedObjectStore.java --- @@ -36,6 +36,7

[GitHub] brooklyn-server pull request #519: Add experimental CORS server support

2017-01-18 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/519#discussion_r96604796 --- Diff: rest/rest-server/src/test/java/org/apache/brooklyn/rest/CorsFilterLauncherTest.java --- @@ -0,0 +1,168 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #519: Add experimental CORS server support

2017-01-18 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/519#discussion_r96604513 --- Diff: rest/rest-server/src/test/java/org/apache/brooklyn/rest/CorsFilterLauncherTest.java --- @@ -0,0 +1,168 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #519: Add experimental CORS server support

2017-01-18 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/519#discussion_r96604766 --- Diff: rest/rest-server/src/test/java/org/apache/brooklyn/rest/CorsFilterLauncherTest.java --- @@ -0,0 +1,168 @@ +/* + * Licensed

[GitHub] brooklyn-docs issue #138: Use full configkey name in docs rather than the sh...

2017-01-19 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-docs/pull/138 This follow [the proposal of deprecating the `@SetFromFlag` annotation](http://mail-archives.apache.org/mod_mbox/brooklyn-dev/201611.mbox/browser) --- If your project is set up for it, you

[GitHub] brooklyn-library pull request #86: Fix non valid CSS rule for example WAR

2017-01-17 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-library/pull/86 Fix non valid CSS rule for example WAR Signed-off-by: Thomas Bouron <thomas.bou...@cloudsoftcorp.com> You can merge this pull request into a Git repository by running: $ gi

[GitHub] brooklyn-docs pull request #138: Use full configkey name in docs rather than...

2017-01-17 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-docs/pull/138 Use full configkey name in docs rather than the shorter version Signed-off-by: Thomas Bouron <thomas.bou...@cloudsoftcorp.com> You can merge this pull request into a Git repo

[GitHub] brooklyn-server pull request #519: Add experimental CORS server support

2017-01-18 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/519#discussion_r96644208 --- Diff: rest/rest-server/src/test/java/org/apache/brooklyn/rest/CorsFilterLauncherTest.java --- @@ -0,0 +1,168 @@ +/* + * Licensed

[GitHub] brooklyn-ui issue #32: Make absolute paths relative

2016-08-16 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/32 @m4rkmckenna Cannot see the changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-server issue #567: Add catalog "itemType" to the CatalogItemSummary...

2017-02-27 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/567 @drigodwin Tests pass on Jenkins now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-server issue #567: Add catalog "itemType" to the CatalogItemSummary...

2017-02-27 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/567 @drigodwin Tried 2 times locally, the tests pass. I'll trigger another jenkins build to make sure it was not a false-positive --- If your project is set up for it, you can reply

[GitHub] brooklyn-server issue #358: Allow REST API to return the config key's constr...

2016-09-29 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/358 @neykov Comment addressed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-server issue #354: Config keys and parameters can now be marked as ...

2016-09-29 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/354 Close this in favor of #358 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-server pull request #354: Config keys and parameters can now be mar...

2016-09-29 Thread tbouron
Github user tbouron closed the pull request at: https://github.com/apache/brooklyn-server/pull/354 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] brooklyn-library issue #65: Implements new constraint API

2016-09-29 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-library/pull/65 Not valid anymore as https://github.com/apache/brooklyn-server/pull/358 does not change the internal API anymore --- If your project is set up for it, you can reply to this email and have

[GitHub] brooklyn-library pull request #65: Implements new constraint API

2016-09-29 Thread tbouron
Github user tbouron closed the pull request at: https://github.com/apache/brooklyn-library/pull/65 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] brooklyn-server pull request #358: Allow REST API to return the pinned confi...

2016-09-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81173978 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/SpecParameterParsingTest.java --- @@ -66,19 +66,20 @@ public

[GitHub] brooklyn-server pull request #358: Allow REST API to return the pinned confi...

2016-09-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81181965 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/SpecParameterParsingTest.java --- @@ -66,19 +66,20 @@ public

[GitHub] brooklyn-server pull request #358: Allow REST API to return the pinned confi...

2016-09-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81188720 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigKey.java --- @@ -184,7 +192,7 @@ public String getDescription

[GitHub] brooklyn-server pull request #358: Allow REST API to return the pinned confi...

2016-09-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r8119 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/EntityConfigSummary.java --- @@ -18,43 +18,82 @@ */ package

[GitHub] brooklyn-server issue #358: Allow REST API to return the pinned config key a...

2016-09-30 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/358 @neykov You can do it from the [Github UI directly](https://help.github.com/articles/merging-a-pull-request/#merging-a-pull-request-using-the-github-web-interface) ;) --- If your project

[GitHub] brooklyn-server issue #358: Allow REST API to return the pinned config key a...

2016-09-30 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/358 @neykov Comments addressed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-docs pull request #112: Add documentation about pinned field for Br...

2016-09-27 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-docs/pull/112 Add documentation about pinned field for Brooklyn parameters This depends on https://github.com/apache/brooklyn-server/pull/354 You can merge this pull request into a Git repository

[GitHub] brooklyn-server pull request #354: Config keys and parameters can now be mar...

2016-09-27 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-server/pull/354 Config keys and parameters can now be marked as "pinned" The new behaviour is as follow: - By default, config keys and parameters are `pinned = false` - A blueprint c

[GitHub] brooklyn-ui pull request #34: Use new pinned and constraints flag returned b...

2016-09-28 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/34 Use new pinned and constraints flag returned by the REST API This allows the UI to work out which parameters need to be displayed on the app wizard, following this convention

[GitHub] brooklyn-server pull request #358: Allow REST API to return the config key's...

2016-09-28 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-server/pull/358 Allow REST API to return the config key's constraints for catalog apps Based on https://github.com/apache/brooklyn-server/pull/354 (needs to be merged first) This changes

[GitHub] brooklyn-library issue #65: Implements new constraint API

2016-09-28 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-library/pull/65 Failure expected, needs https://github.com/apache/brooklyn-server/pull/354 and https://github.com/apache/brooklyn-server/pull/358 --- If your project is set up for it, you can reply

[GitHub] brooklyn-server issue #358: Allow REST API to return the config key's constr...

2016-09-28 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/358 FYI, I tested before pushing. I also just retested locally and all tests pass. Not sure what is going on here --- If your project is set up for it, you can reply to this email and have

[GitHub] brooklyn-ui pull request #34: Use new pinned and constraints flag returned b...

2016-09-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/34#discussion_r81367055 --- Diff: src/main/webapp/assets/js/view/application-add-wizard.js --- @@ -680,10 +680,12 @@ define([ this.$('.required-config

[GitHub] brooklyn-ui pull request #34: Use new pinned and constraints flag returned b...

2016-09-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/34#discussion_r81367589 --- Diff: src/main/webapp/assets/js/view/application-add-wizard.js --- @@ -680,10 +680,12 @@ define([ this.$('.required-config

[GitHub] brooklyn-ui pull request #34: Use new pinned and constraints flag returned b...

2016-09-30 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/34#discussion_r81368420 --- Diff: src/main/webapp/assets/js/view/application-add-wizard.js --- @@ -680,10 +680,12 @@ define([ this.$('.required-config

  1   2   3   4   5   6   7   >