[GitHub] [brooklyn-server] iuliana merged pull request #1408: Added support for command containers in workflow steps, containers ...

2023-08-29 Thread via GitHub
iuliana merged PR #1408: URL: https://github.com/apache/brooklyn-server/pull/1408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-server] iuliana opened a new pull request, #1410: Added arguments splitting using QuotedStringTokenizer

2023-08-31 Thread via GitHub
iuliana opened a new pull request, #1410: URL: https://github.com/apache/brooklyn-server/pull/1410 As the title says. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [brooklyn-server] iuliana merged pull request #1410: Added arguments splitting using QuotedStringTokenizer

2023-08-31 Thread via GitHub
iuliana merged PR #1410: URL: https://github.com/apache/brooklyn-server/pull/1410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-server] dependabot[bot] opened a new pull request, #1411: Bump org.eclipse.jetty:jetty-http from 9.4.49.v20220914 to 9.4.52.v20230823

2023-09-14 Thread via GitHub
dependabot[bot] opened a new pull request, #1411: URL: https://github.com/apache/brooklyn-server/pull/1411 Bumps [org.eclipse.jetty:jetty-http](https://github.com/eclipse/jetty.project) from 9.4.49.v20220914 to 9.4.52.v20230823. Release notes Sourced from

[GitHub] [brooklyn-server] iuliana opened a new pull request, #1409: Removed forgotten comment

2023-08-30 Thread via GitHub
iuliana opened a new pull request, #1409: URL: https://github.com/apache/brooklyn-server/pull/1409 As the title says. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [brooklyn-server] iuliana merged pull request #1409: Removed forgotten comment

2023-08-30 Thread via GitHub
iuliana merged PR #1409: URL: https://github.com/apache/brooklyn-server/pull/1409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-client] jcabrerizo merged pull request #101: add arm and arm64 as available architectures

2023-09-28 Thread via GitHub
jcabrerizo merged PR #101: URL: https://github.com/apache/brooklyn-client/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-client] jcabrerizo opened a new pull request, #101: add arm and arm64 as available architectures

2023-09-28 Thread via GitHub
jcabrerizo opened a new pull request, #101: URL: https://github.com/apache/brooklyn-client/pull/101 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [brooklyn-server] ahgittin merged pull request #1412: Allow to forward some to the headers when a SecurityProviderDeniedAut…

2023-09-27 Thread via GitHub
ahgittin merged PR #1412: URL: https://github.com/apache/brooklyn-server/pull/1412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-client] ahgittin merged pull request #100: prints, if present, the content of the header X_BROOKLYN_UNAUTHORIZED_MESSAGE

2023-09-27 Thread via GitHub
ahgittin merged PR #100: URL: https://github.com/apache/brooklyn-client/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-server] jcabrerizo opened a new pull request, #1412: Allow to forward some to the headers when a SecurityProviderDeniedAut…

2023-09-26 Thread via GitHub
jcabrerizo opened a new pull request, #1412: URL: https://github.com/apache/brooklyn-server/pull/1412 Adds support for forwarding a new http header `X_BROOKLYN_UNAUTHORIZED_MESSAGE` for adding a helper message on the CLI -- This is an automated message from the Apache Git Service. To

[GitHub] [brooklyn-client] jcabrerizo opened a new pull request, #100: prints, if present, the content of the header X_BROOKLYN_UNAUTHORIZED_MESSAGE

2023-09-26 Thread via GitHub
jcabrerizo opened a new pull request, #100: URL: https://github.com/apache/brooklyn-client/pull/100 Requires https://github.com/apache/brooklyn-server/pull/1412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] Bump postcss, autoprefixer, css-loader and postcss-loader in /ui-modules/login [brooklyn-ui]

2023-10-03 Thread via GitHub
dependabot[bot] opened a new pull request, #382: URL: https://github.com/apache/brooklyn-ui/pull/382 Bumps [postcss](https://github.com/postcss/postcss) to 8.4.31 and updates ancestor dependencies [postcss](https://github.com/postcss/postcss),

[GitHub] [brooklyn-server] iuliana opened a new pull request, #1408: Added support for command containers in workflow steps, containers ...

2023-08-29 Thread via GitHub
iuliana opened a new pull request, #1408: URL: https://github.com/apache/brooklyn-server/pull/1408 That are run as a command and only require arguments. (e.g. `amazon/aws-cli`, `hashicorp/terraform`). Steps examples: ``` - step : "container amazon/aws-cli" args:

[GitHub] [brooklyn-server] duncangrant commented on a diff in pull request #1408: Added support for command containers in workflow steps, containers ...

2023-08-29 Thread via GitHub
duncangrant commented on code in PR #1408: URL: https://github.com/apache/brooklyn-server/pull/1408#discussion_r1309002530 ## camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/WorkflowYamlTest.java: ## @@ -798,6 +800,41 @@ public void testLockReleasedOnCancel()

[GitHub] [brooklyn-server] iuliana commented on a diff in pull request #1408: Added support for command containers in workflow steps, containers ...

2023-08-29 Thread via GitHub
iuliana commented on code in PR #1408: URL: https://github.com/apache/brooklyn-server/pull/1408#discussion_r1309007774 ## camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/WorkflowYamlTest.java: ## @@ -798,6 +800,41 @@ public void testLockReleasedOnCancel()

[GitHub] [brooklyn-ui] ahgittin commented on a diff in pull request #370: fix for missing version in 'View in Catalog' link

2023-01-25 Thread via GitHub
ahgittin commented on code in PR #370: URL: https://github.com/apache/brooklyn-ui/pull/370#discussion_r1086550577 ## ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.directive.js: ## @@ -208,12 +208,14 @@ export function

[GitHub] [brooklyn-ui] ahgittin commented on pull request #370: fix for missing version in 'View in Catalog' link

2023-01-25 Thread via GitHub
ahgittin commented on PR #370: URL: https://github.com/apache/brooklyn-ui/pull/370#issuecomment-1403717667 :+1: even better -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [brooklyn-ui] asfgit merged pull request #370: fix for missing version in 'View in Catalog' link

2023-01-25 Thread via GitHub
asfgit merged PR #370: URL: https://github.com/apache/brooklyn-ui/pull/370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-server] ahgittin opened a new pull request, #1377: don't remove the location from an entity on stop until it is confirmed released

2023-01-27 Thread via GitHub
ahgittin opened a new pull request, #1377: URL: https://github.com/apache/brooklyn-server/pull/1377 previously there was a window where a location instance might be removed from the parent before the provisioner releases it, and if the provisioner fails in that window the reference to the

[GitHub] [brooklyn-server] asfgit merged pull request #1377: don't remove the location from an entity on stop until it is confirmed released

2023-01-27 Thread via GitHub
asfgit merged PR #1377: URL: https://github.com/apache/brooklyn-server/pull/1377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn] asfgit merged pull request #57: Tell docker build where to find openssl libraries

2023-01-31 Thread via GitHub
asfgit merged PR #57: URL: https://github.com/apache/brooklyn/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn] kemitix opened a new pull request, #57: Tell docker build where to find openssl libraries

2023-01-31 Thread via GitHub
kemitix opened a new pull request, #57: URL: https://github.com/apache/brooklyn/pull/57 Adds and environment variable to the Dockerfile to allow PhantonJS to fidn the openssl libraries. PhantomJS was failing to start while building `Brooklyn UI :: Modules - UI Utils` due to not

[GitHub] [brooklyn] ahgittin commented on pull request #57: Tell docker build where to find openssl libraries

2023-01-31 Thread via GitHub
ahgittin commented on PR #57: URL: https://github.com/apache/brooklyn/pull/57#issuecomment-1410231226 nice - hopefully gets the build healthy again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [brooklyn-client] dependabot[bot] opened a new pull request, #96: Bump golang.org/x/crypto from 0.0.0-20210220033148-5ea612d1eb83 to 0.1.0 in /cli

2023-03-06 Thread via GitHub
dependabot[bot] opened a new pull request, #96: URL: https://github.com/apache/brooklyn-client/pull/96 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.0.0-20210220033148-5ea612d1eb83 to 0.1.0. Commits See full diff in

[GitHub] [brooklyn-client] duncangrant merged pull request #97: Issue with sslcheck flag

2023-03-10 Thread via GitHub
duncangrant merged PR #97: URL: https://github.com/apache/brooklyn-client/pull/97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-client] duncangrant opened a new pull request, #97: Issue with sslcheck flag

2023-03-10 Thread via GitHub
duncangrant opened a new pull request, #97: URL: https://github.com/apache/brooklyn-client/pull/97 There was a global flag and a command flag and both are not supported so now there's only a command flag Also updated to latest go, which had some knock-on effects. -- This is an

[GitHub] [brooklyn-client] duncangrant commented on pull request #97: Issue with sslcheck flag

2023-03-10 Thread via GitHub
duncangrant commented on PR #97: URL: https://github.com/apache/brooklyn-client/pull/97#issuecomment-1464080227 I've built this locally using go build and it fixes the flag issue however I can't get the docker build to work locally so I don't know how this will work in CI. It passes

[GitHub] [brooklyn-client] dependabot[bot] commented on pull request #96: Bump golang.org/x/crypto from 0.0.0-20210220033148-5ea612d1eb83 to 0.1.0 in /cli

2023-03-10 Thread via GitHub
dependabot[bot] commented on PR #96: URL: https://github.com/apache/brooklyn-client/pull/96#issuecomment-1464092670 Looks like golang.org/x/crypto is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [brooklyn-client] dependabot[bot] closed pull request #96: Bump golang.org/x/crypto from 0.0.0-20210220033148-5ea612d1eb83 to 0.1.0 in /cli

2023-03-10 Thread via GitHub
dependabot[bot] closed pull request #96: Bump golang.org/x/crypto from 0.0.0-20210220033148-5ea612d1eb83 to 0.1.0 in /cli URL: https://github.com/apache/brooklyn-client/pull/96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [brooklyn-client] duncangrant commented on a diff in pull request #97: Issue with sslcheck flag

2023-03-10 Thread via GitHub
duncangrant commented on code in PR #97: URL: https://github.com/apache/brooklyn-client/pull/97#discussion_r1132601887 ## cli/app/app.go: ## @@ -52,10 +52,10 @@ func NewApp(baseName string, cmdRunner command_runner.Runner, metadatas ...comma app.Version =

[GitHub] [brooklyn-server] dependabot[bot] opened a new pull request, #1383: Bump json-smart from 2.4.7 to 2.4.9

2023-03-23 Thread via GitHub
dependabot[bot] opened a new pull request, #1383: URL: https://github.com/apache/brooklyn-server/pull/1383 Bumps [json-smart](https://github.com/netplex/json-smart-v2) from 2.4.7 to 2.4.9. Release notes Sourced from https://github.com/netplex/json-smart-v2/releases;>json-smart's

[GitHub] [brooklyn-ui] ahgittin commented on pull request #373: Improves filter layout

2023-03-22 Thread via GitHub
ahgittin commented on PR #373: URL: https://github.com/apache/brooklyn-ui/pull/373#issuecomment-1479434425 looks much nicer! good stuff. merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [brooklyn-docs] frogfather opened a new pull request, #376: change enricherType to type

2023-03-22 Thread via GitHub
frogfather opened a new pull request, #376: URL: https://github.com/apache/brooklyn-docs/pull/376 Blueprint used old syntax enricher type which isn't supported in the UI. Changed to type. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [brooklyn-docs] duncangrant merged pull request #376: change enricherType to type

2023-03-22 Thread via GitHub
duncangrant merged PR #376: URL: https://github.com/apache/brooklyn-docs/pull/376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-docs] frogfather commented on pull request #376: change enricherType to type

2023-03-22 Thread via GitHub
frogfather commented on PR #376: URL: https://github.com/apache/brooklyn-docs/pull/376#issuecomment-1479403425 Tested locally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [brooklyn-ui] asfgit merged pull request #373: Improves filter layout

2023-03-22 Thread via GitHub
asfgit merged PR #373: URL: https://github.com/apache/brooklyn-ui/pull/373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-ui] nakomis commented on pull request #373: Improves filter layout

2023-03-22 Thread via GitHub
nakomis commented on PR #373: URL: https://github.com/apache/brooklyn-ui/pull/373#issuecomment-1479421208 Primarily changes from (non-standard) multi-select radio buttons to checkboxes and improves readability and display of highlights. Example before and after screenshots attached

[GitHub] [brooklyn-server] dependabot[bot] opened a new pull request, #1381: Bump snakeyaml from 1.33 to 2.0

2023-03-22 Thread via GitHub
dependabot[bot] opened a new pull request, #1381: URL: https://github.com/apache/brooklyn-server/pull/1381 Bumps [snakeyaml](https://bitbucket.org/snakeyaml/snakeyaml) from 1.33 to 2.0. Commits

[GitHub] [brooklyn-server] dependabot[bot] opened a new pull request, #1382: Bump testng from 7.3.0 to 7.7.0

2023-03-22 Thread via GitHub
dependabot[bot] opened a new pull request, #1382: URL: https://github.com/apache/brooklyn-server/pull/1382 Bumps [testng](https://github.com/cbeust/testng) from 7.3.0 to 7.7.0. Release notes Sourced from https://github.com/cbeust/testng/releases;>testng's releases. TestNG

[GitHub] [brooklyn-server] duncangrant merged pull request #1380: Removes final from WorkflowPolicy

2023-02-20 Thread via GitHub
duncangrant merged PR #1380: URL: https://github.com/apache/brooklyn-server/pull/1380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-docs] duncangrant merged pull request #374: Fixes typo in workflow variables docs

2023-03-02 Thread via GitHub
duncangrant merged PR #374: URL: https://github.com/apache/brooklyn-docs/pull/374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-server] nakomis commented on pull request #1379: Makes WorkflowSensor public and extensible

2023-02-16 Thread via GitHub
nakomis commented on PR #1379: URL: https://github.com/apache/brooklyn-server/pull/1379#issuecomment-1432827388 Removes `final` designation from `WorkflowSensor` allowing downstream projects to extend it. `WorkflowPollCallable` params are made visible to allow comparison of workflowsensors

[GitHub] [brooklyn-server] duncangrant merged pull request #1379: Makes WorkflowSensor public and extensible

2023-02-16 Thread via GitHub
duncangrant merged PR #1379: URL: https://github.com/apache/brooklyn-server/pull/1379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-server] nakomis opened a new pull request, #1380: Removes final from WorkflowPolicy

2023-02-17 Thread via GitHub
nakomis opened a new pull request, #1380: URL: https://github.com/apache/brooklyn-server/pull/1380 Removes `final` designator from WorkflowPolicy to allow extension in downstream -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [brooklyn-ui] dependabot[bot] opened a new pull request, #372: Bump minimist, webpack, extract-text-webpack-plugin and karma in /ui-modules/login

2023-02-28 Thread via GitHub
dependabot[bot] opened a new pull request, #372: URL: https://github.com/apache/brooklyn-ui/pull/372 Bumps [minimist](https://github.com/minimistjs/minimist) to 1.2.8 and updates ancestor dependencies [minimist](https://github.com/minimistjs/minimist),

[GitHub] [brooklyn-ui] frogfather opened a new pull request, #377: Brooklyn UI avoid entity name wrap pt 184904842

2023-04-12 Thread via GitHub
frogfather opened a new pull request, #377: URL: https://github.com/apache/brooklyn-ui/pull/377 Changes overflow behaviour on entity name to ellipsis instead of overflow Adds a tooltip showing the full name on hover

[GitHub] [brooklyn-ui] ahgittin commented on pull request #377: Brooklyn UI avoid entity name wrap

2023-04-12 Thread via GitHub
ahgittin commented on PR #377: URL: https://github.com/apache/brooklyn-ui/pull/377#issuecomment-1505527456 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [brooklyn-ui] iuliana merged pull request #377: Brooklyn UI avoid entity name wrap

2023-04-17 Thread via GitHub
iuliana merged PR #377: URL: https://github.com/apache/brooklyn-ui/pull/377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-server] jcabrerizo opened a new pull request, #1389: Activities tab rest optimization

2023-04-17 Thread via GitHub
jcabrerizo opened a new pull request, #1389: URL: https://github.com/apache/brooklyn-server/pull/1389 It avoids to return the `task-summary` and the `output` of each step inside a workflow. The automatic refresh of the view was pulling those, sometimes, huge objects few times per minute

[GitHub] [brooklyn-server] iuliana opened a new pull request, #1388: Added new step type for setting entity name

2023-04-17 Thread via GitHub
iuliana opened a new pull request, #1388: URL: https://github.com/apache/brooklyn-server/pull/1388 Added a new step type. Added to the catalog as `set-entity-name`. Sample usage (shorthand): ``` name: test-set-entity-name-step location: localhost services: - type: server

[GitHub] [brooklyn-server] iuliana merged pull request #1388: Added new step type for setting entity name

2023-04-17 Thread via GitHub
iuliana merged PR #1388: URL: https://github.com/apache/brooklyn-server/pull/1388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-ui] jathanasiou opened a new pull request, #378: wrapping long step id text

2023-04-13 Thread via GitHub
jathanasiou opened a new pull request, #378: URL: https://github.com/apache/brooklyn-ui/pull/378 This should fix issues with displaying long IDs for workflow steps without them escaping the panel:

[GitHub] [brooklyn-server] jathanasiou opened a new pull request, #1393: Fix/sum operator coercion

2023-04-20 Thread via GitHub
jathanasiou opened a new pull request, #1393: URL: https://github.com/apache/brooklyn-server/pull/1393 # WIP Currently the `sum` workflow transform only works with lists of numbers eg `[ 2, 3 ] | sum` yields `5`. This is meant to enable coercion from strings such that `["2",

[GitHub] [brooklyn-server] duncangrant commented on pull request #1392: Adds Workflow Replace Transform

2023-04-20 Thread via GitHub
duncangrant commented on PR #1392: URL: https://github.com/apache/brooklyn-server/pull/1392#issuecomment-1515824056 @nakomis Please can you add a description to this pull request so that it's clear what it's for. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [brooklyn-server] duncangrant merged pull request #1392: Adds Workflow Replace Transform

2023-04-20 Thread via GitHub
duncangrant merged PR #1392: URL: https://github.com/apache/brooklyn-server/pull/1392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-server] frogfather opened a new pull request, #1394: Workflow entity child and member access pt 184904864

2023-04-20 Thread via GitHub
frogfather opened a new pull request, #1394: URL: https://github.com/apache/brooklyn-server/pull/1394 Improves access to child entities in workflow allowing children to be accessed as ${entity.children[n]} in addition to the current syntax $brooklyn:child("id") -- This is an automated

[GitHub] [brooklyn-server] iuliana commented on pull request #1393: Fix/sum operator coercion

2023-04-20 Thread via GitHub
iuliana commented on PR #1393: URL: https://github.com/apache/brooklyn-server/pull/1393#issuecomment-1516272535 @jathanasiou You forgot to add the Apace License in the new Java file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [brooklyn-server] dependabot[bot] opened a new pull request, #1391: Bump jetty-server from 9.4.49.v20220914 to 10.0.14

2023-04-18 Thread via GitHub
dependabot[bot] opened a new pull request, #1391: URL: https://github.com/apache/brooklyn-server/pull/1391 Bumps [jetty-server](https://github.com/eclipse/jetty.project) from 9.4.49.v20220914 to 10.0.14. Release notes Sourced from

[GitHub] [brooklyn-server] iuliana merged pull request #1390: adding logging category and level to workflow logs

2023-04-19 Thread via GitHub
iuliana merged PR #1390: URL: https://github.com/apache/brooklyn-server/pull/1390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-server] ahgittin commented on pull request #1389: Activities tab rest optimization

2023-04-24 Thread via GitHub
ahgittin commented on PR #1389: URL: https://github.com/apache/brooklyn-server/pull/1389#issuecomment-1519854466 @jcabrerizo this is effective but a few things seem wrong to me: (1) `Sanitizer.suppress` methods are to _replace_ sensitive fields eg password with a hashcode so they are

[GitHub] [brooklyn-server] duncangrant merged pull request #1394: Workflow entity child and member access pt 184904864

2023-04-24 Thread via GitHub
duncangrant merged PR #1394: URL: https://github.com/apache/brooklyn-server/pull/1394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-server] duncangrant commented on pull request #1394: Workflow entity child and member access pt 184904864

2023-04-24 Thread via GitHub
duncangrant commented on PR #1394: URL: https://github.com/apache/brooklyn-server/pull/1394#issuecomment-1520372550 This looks good to me. Thanks @frogfather . It does look like there are a couple of tests that are failing intermittently. I've copied these below and will see if I can

[GitHub] [brooklyn-server] iuliana commented on a diff in pull request #1390: adding logging category and level to workflow logs

2023-04-18 Thread via GitHub
iuliana commented on code in PR #1390: URL: https://github.com/apache/brooklyn-server/pull/1390#discussion_r1170064428 ## core/src/main/java/org/apache/brooklyn/core/workflow/steps/flow/LogWorkflowStep.java: ## @@ -26,12 +26,16 @@ import org.slf4j.Logger; import

[GitHub] [brooklyn-server] lukiwlosek commented on a diff in pull request #1390: adding logging category and level to workflow logs

2023-04-18 Thread via GitHub
lukiwlosek commented on code in PR #1390: URL: https://github.com/apache/brooklyn-server/pull/1390#discussion_r1170065579 ## core/src/main/java/org/apache/brooklyn/core/workflow/steps/flow/LogWorkflowStep.java: ## @@ -26,12 +26,16 @@ import org.slf4j.Logger; import

[GitHub] [incubator-brooklyn] dependabot[bot] opened a new pull request, #1205: Bump commons-beanutils from 1.9.1 to 1.9.4 in /brooklyn-server/camp/camp-brooklyn

2023-04-15 Thread via GitHub
dependabot[bot] opened a new pull request, #1205: URL: https://github.com/apache/incubator-brooklyn/pull/1205 Bumps commons-beanutils from 1.9.1 to 1.9.4. [![Dependabot compatibility

[GitHub] [brooklyn-ui] duncangrant merged pull request #378: wrapping long step id text

2023-04-14 Thread via GitHub
duncangrant merged PR #378: URL: https://github.com/apache/brooklyn-ui/pull/378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-server] duncangrant commented on a diff in pull request #1390: adding logging category and level to workflow logs

2023-04-18 Thread via GitHub
duncangrant commented on code in PR #1390: URL: https://github.com/apache/brooklyn-server/pull/1390#discussion_r1170037508 ## core/src/main/java/org/apache/brooklyn/core/workflow/steps/flow/LogWorkflowStep.java: ## @@ -26,12 +26,16 @@ import org.slf4j.Logger; import

[GitHub] [brooklyn-server] ahgittin commented on pull request #1394: Workflow entity child and member access pt 184904864

2023-05-01 Thread via GitHub
ahgittin commented on PR #1394: URL: https://github.com/apache/brooklyn-server/pull/1394#issuecomment-1529648319 there is no need for `children` to be a field; made a minor code cleanup in `3543694192880438b9cb03153472749a36dc1712` also: `members` was not handled, and the proposed

[GitHub] [brooklyn-library] dependabot[bot] opened a new pull request, #192: Bump cassandra-all from 1.2.2 to 3.0.26 in /sandbox/cassandra-multicloud-snitch

2023-04-16 Thread via GitHub
dependabot[bot] opened a new pull request, #192: URL: https://github.com/apache/brooklyn-library/pull/192 Bumps cassandra-all from 1.2.2 to 3.0.26. [![Dependabot compatibility

[GitHub] [brooklyn-server] jcabrerizo opened a new pull request, #1384: mitigate CVE-2023-1370

2023-03-27 Thread via GitHub
jcabrerizo opened a new pull request, #1384: URL: https://github.com/apache/brooklyn-server/pull/1384 see: https://security.snyk.io/vuln/SNYK-JAVA-NETMINIDEV-3369748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [brooklyn-server] kemitix commented on pull request #1384: mitigate CVE-2023-1370

2023-03-27 Thread via GitHub
kemitix commented on PR #1384: URL: https://github.com/apache/brooklyn-server/pull/1384#issuecomment-1484889402 test this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [brooklyn-server] kemitix opened a new pull request, #1385: Mitigate CVE 2023 1370

2023-03-27 Thread via GitHub
kemitix opened a new pull request, #1385: URL: https://github.com/apache/brooklyn-server/pull/1385 Builds on #1384 to test Jenkins is working again after Apache INFRA reinstalling the pipeline-github plugin. Merge #1384 in favour of this, unless you really want the comment about the

[GitHub] [brooklyn-ui] nakomis opened a new pull request, #374: Tidies layout of new-policy screen

2023-04-03 Thread via GitHub
nakomis opened a new pull request, #374: URL: https://github.com/apache/brooklyn-ui/pull/374 Tidies the new policy layout screen to remove the excess padding and align the buttons correctly Before:

[GitHub] [brooklyn-ui] ahgittin merged pull request #374: Tidies layout of new-policy screen

2023-04-03 Thread via GitHub
ahgittin merged PR #374: URL: https://github.com/apache/brooklyn-ui/pull/374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-server] zan-mateusz opened a new pull request, #1386: fix for the test failing in different timezone

2023-04-03 Thread via GitHub
zan-mateusz opened a new pull request, #1386: URL: https://github.com/apache/brooklyn-server/pull/1386 Problem with test and one of the assertions in a different timezone. `Assert.assertEquals(Time.makeDateStampStringZ(instant), "20200101-1200Z");` - that is the problematic one -

[GitHub] [brooklyn-server] ahgittin merged pull request #1386: fix for the test failing in different timezone

2023-04-03 Thread via GitHub
ahgittin merged PR #1386: URL: https://github.com/apache/brooklyn-server/pull/1386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-ui] iuliana merged pull request #375: Adjuct filtering

2023-04-06 Thread via GitHub
iuliana merged PR #375: URL: https://github.com/apache/brooklyn-ui/pull/375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-ui] iuliana merged pull request #376: Added check that parsedPlan.services exists before checking its length

2023-04-11 Thread via GitHub
iuliana merged PR #376: URL: https://github.com/apache/brooklyn-ui/pull/376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-ui] iuliana opened a new pull request, #376: Added check that parsedPlan.services exists before checking its length

2023-04-11 Thread via GitHub
iuliana opened a new pull request, #376: URL: https://github.com/apache/brooklyn-ui/pull/376 Added check that parsedPlan.services exists before checking its length, which would be causing an issue for extensions that fo not have a `parsedPlan.services` -- This is an automated message

[GitHub] [brooklyn-docs] dependabot[bot] commented on pull request #371: Bump nokogiri from 1.13.8 to 1.13.10

2023-04-12 Thread via GitHub
dependabot[bot] commented on PR #371: URL: https://github.com/apache/brooklyn-docs/pull/371#issuecomment-1504722528 Superseded by #377. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [brooklyn-docs] dependabot[bot] opened a new pull request, #377: Bump nokogiri from 1.13.8 to 1.14.3

2023-04-12 Thread via GitHub
dependabot[bot] opened a new pull request, #377: URL: https://github.com/apache/brooklyn-docs/pull/377 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.8 to 1.14.3. Release notes Sourced from https://github.com/sparklemotion/nokogiri/releases;>nokogiri's

[GitHub] [brooklyn-docs] dependabot[bot] closed pull request #371: Bump nokogiri from 1.13.8 to 1.13.10

2023-04-12 Thread via GitHub
dependabot[bot] closed pull request #371: Bump nokogiri from 1.13.8 to 1.13.10 URL: https://github.com/apache/brooklyn-docs/pull/371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [brooklyn-server] iuliana merged pull request #1387: Swagger fix

2023-04-10 Thread via GitHub
iuliana merged PR #1387: URL: https://github.com/apache/brooklyn-server/pull/1387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-server] jcabrerizo merged pull request #1385: Mitigate CVE 2023 1370

2023-03-27 Thread via GitHub
jcabrerizo merged PR #1385: URL: https://github.com/apache/brooklyn-server/pull/1385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-server] kemitix commented on pull request #1385: Mitigate CVE 2023 1370

2023-03-27 Thread via GitHub
kemitix commented on PR #1385: URL: https://github.com/apache/brooklyn-server/pull/1385#issuecomment-1485076699 Can't push commits ATM, but the fix is: ```diff diff --git a/pom.xml b/pom.xml index 4c2a42e180..bbb86ad9d2 100644 --- a/pom.xml +++ b/pom.xml @@ -205,7 +205,7 @@

[GitHub] [brooklyn-server] dependabot[bot] commented on pull request #1383: Bump json-smart from 2.4.7 to 2.4.9

2023-03-27 Thread via GitHub
dependabot[bot] commented on PR #1383: URL: https://github.com/apache/brooklyn-server/pull/1383#issuecomment-1485162681 Looks like net.minidev:json-smart is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [brooklyn-server] dependabot[bot] closed pull request #1383: Bump json-smart from 2.4.7 to 2.4.9

2023-03-27 Thread via GitHub
dependabot[bot] closed pull request #1383: Bump json-smart from 2.4.7 to 2.4.9 URL: https://github.com/apache/brooklyn-server/pull/1383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [brooklyn-server] jcabrerizo merged pull request #1384: mitigate CVE-2023-1370

2023-03-27 Thread via GitHub
jcabrerizo merged PR #1384: URL: https://github.com/apache/brooklyn-server/pull/1384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-ui] jathanasiou opened a new pull request, #375: Adjuct filtering

2023-04-04 Thread via GitHub
jathanasiou opened a new pull request, #375: URL: https://github.com/apache/brooklyn-ui/pull/375 Adjusted filtering for policies/adjunct entries so that the Management tab consistent with the others. Small changes to "Add" button.

[GitHub] [brooklyn-docs] frogfather opened a new pull request, #375: Correct workflow variables and expressions example

2023-03-21 Thread via GitHub
frogfather opened a new pull request, #375: URL: https://github.com/apache/brooklyn-docs/pull/375 Adds a missing -step: to the 5th line of the example -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [brooklyn-docs] duncangrant merged pull request #375: Correct workflow variables and expressions example

2023-03-21 Thread via GitHub
duncangrant merged PR #375: URL: https://github.com/apache/brooklyn-docs/pull/375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-docs] frogfather commented on pull request #375: Correct workflow variables and expressions example

2023-03-21 Thread via GitHub
frogfather commented on PR #375: URL: https://github.com/apache/brooklyn-docs/pull/375#issuecomment-1478079239 Tested by pasting example code into workflow via UI admin ``` name: Workflow via UI admin steps: - log Starting workflow ${workflow.name} - let integer x = 1

[GitHub] [brooklyn-docs] asfgit merged pull request #373: Adds docs for new catalog metadata iconUrl field

2023-02-09 Thread via GitHub
asfgit merged PR #373: URL: https://github.com/apache/brooklyn-docs/pull/373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-server] asfgit merged pull request #1378: Adds iconUrl to bundles

2023-02-09 Thread via GitHub
asfgit merged PR #1378: URL: https://github.com/apache/brooklyn-server/pull/1378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brooklyn-docs] nakomis commented on pull request #373: Adds docs for new catalog metadata iconUrl field

2023-02-03 Thread via GitHub
nakomis commented on PR #373: URL: https://github.com/apache/brooklyn-docs/pull/373#issuecomment-1416252980 To be merged after https://github.com/apache/brooklyn-docs/pull/373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [brooklyn-server] nakomis commented on pull request #1378: Adds iconUrl to bundles

2023-02-03 Thread via GitHub
nakomis commented on PR #1378: URL: https://github.com/apache/brooklyn-server/pull/1378#issuecomment-1416253391 See also https://github.com/apache/brooklyn-docs/pull/373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [brooklyn-server] iuliana opened a new pull request, #1387: Swagger fix

2023-04-10 Thread via GitHub
iuliana opened a new pull request, #1387: URL: https://github.com/apache/brooklyn-server/pull/1387 Some transitive types schemas generated by swagger are incorrect, this does not make the swagger schema invalid, but it does prevent Swagger from generating a proper HTML REST API page. This

[GitHub] [brooklyn-server] jcabrerizo commented on pull request #1389: Activities tab rest optimization

2023-04-28 Thread via GitHub
jcabrerizo commented on PR #1389: URL: https://github.com/apache/brooklyn-server/pull/1389#issuecomment-1527332992 @ahgittin I didn't find a better way to move out the output without modifying so much the `fromTasks` logic. My feeling is this a correct balance: it removes any value from a

[GitHub] [brooklyn-server] dependabot[bot] opened a new pull request, #1403: Bump guava from 27.1-jre to 32.0.0-jre

2023-06-14 Thread via GitHub
dependabot[bot] opened a new pull request, #1403: URL: https://github.com/apache/brooklyn-server/pull/1403 Bumps [guava](https://github.com/google/guava) from 27.1-jre to 32.0.0-jre. Release notes Sourced from https://github.com/google/guava/releases;>guava's releases.

  1   2   3   >