[GitHub] [brooklyn-client] geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package

2019-09-11 Thread GitBox
geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package URL: https://github.com/apache/brooklyn-client/pull/78#issuecomment-530572409 @duncangrant happy enough to merge? This is an

[GitHub] [brooklyn-client] geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package

2019-09-11 Thread GitBox
geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package URL: https://github.com/apache/brooklyn-client/pull/78#issuecomment-530570721 retest this please This is an automated message from

[GitHub] [brooklyn-client] geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package

2019-09-11 Thread GitBox
geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package URL: https://github.com/apache/brooklyn-client/pull/78#issuecomment-530570653 ```ERROR: Maven Home /home/jenkins/tools/maven/apache-maven-3.3.3 doesnt exist``` what is going on?

[GitHub] [brooklyn-client] geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package

2019-09-11 Thread GitBox
geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package URL: https://github.com/apache/brooklyn-client/pull/78#issuecomment-530570404 retest this please This is an automated message from

[GitHub] [brooklyn-client] geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package

2019-09-11 Thread GitBox
geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package URL: https://github.com/apache/brooklyn-client/pull/78#issuecomment-530570148 retest this please This is an automated message from

[GitHub] [brooklyn-client] geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package

2019-09-11 Thread GitBox
geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package URL: https://github.com/apache/brooklyn-client/pull/78#issuecomment-530525974 retest this please This is an automated message from

[GitHub] [brooklyn-client] geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package

2019-09-09 Thread GitBox
geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package URL: https://github.com/apache/brooklyn-client/pull/78#issuecomment-529355686 retest this please This is an automated message from

[GitHub] [brooklyn-client] geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package

2019-09-04 Thread GitBox
geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package URL: https://github.com/apache/brooklyn-client/pull/78#issuecomment-528111370 @duncangrant @johnmccabe changes made can you have a look again. `matryer/is` looks nice by the way

[GitHub] [brooklyn-client] geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package

2019-09-03 Thread GitBox
geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package URL: https://github.com/apache/brooklyn-client/pull/78#issuecomment-527654061 Thanks @johnmccabe will update accordingly This is an

[GitHub] [brooklyn-client] geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package

2019-09-03 Thread GitBox
geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package URL: https://github.com/apache/brooklyn-client/pull/78#issuecomment-527632083 duplication removed This is an automated message from

[GitHub] [brooklyn-client] geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package

2019-09-03 Thread GitBox
geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package URL: https://github.com/apache/brooklyn-client/pull/78#issuecomment-527616482 > This looks good to me and I'd be happy to merge. The one section that I'm a bit uncomfortable reviewing is the

[GitHub] [brooklyn-client] geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package

2019-08-14 Thread GitBox
geomacy commented on issue #78: BROOKLYN-586 update br to replace obsolete jsonpath package URL: https://github.com/apache/brooklyn-client/pull/78#issuecomment-521429453 Have updated the code to use Kubernetes jsonpath package as suggested by @johnmccabe. Also added some more tests,