[GitHub] aledsage commented on issue #1037: tidy string/primitive coercion

2019-02-11 Thread GitBox
aledsage commented on issue #1037: tidy string/primitive coercion URL: https://github.com/apache/brooklyn-server/pull/1037#issuecomment-462274678 Other than failing unit test, LGTM. Happy for this to be merged once that is fixed @ahgittin

[GitHub] aledsage commented on issue #1037: tidy string/primitive coercion

2019-02-11 Thread GitBox
aledsage commented on issue #1037: tidy string/primitive coercion URL: https://github.com/apache/brooklyn-server/pull/1037#issuecomment-462272662 @ahgittin test failure looks related to changes (`TypeCoercionsTest.testCoercePrimitiveFailures`): ``` java.lang.AssertionError: Error