[GitHub] aledsage commented on issue #1037: tidy string/primitive coercion

2019-02-11 Thread GitBox 
aledsage commented on issue #1037: tidy string/primitive coercion
URL: https://github.com/apache/brooklyn-server/pull/1037#issuecomment-462274678
 
 
   Other than failing unit test, LGTM. Happy for this to be merged once that is 
fixed @ahgittin 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] aledsage commented on issue #1037: tidy string/primitive coercion

2019-02-11 Thread GitBox 
aledsage commented on issue #1037: tidy string/primitive coercion
URL: https://github.com/apache/brooklyn-server/pull/1037#issuecomment-462272662
 
 
   @ahgittin test failure looks related to changes 
(`TypeCoercionsTest.testCoercePrimitiveFailures`):
   ```
   java.lang.AssertionError: Error from type coercion of maybe to boolean 
failed with wrong exception; expected match of 
Predicates.and(containsLiteral("String"),containsLiteral("boolean"),containsLiteral("maybe"))
 but got: org.apache.brooklyn.util.javalang.coerce.ClassCoercionException: 
Cannot coerce type String to java.lang.Boolean (maybe): adapting failed
at 
org.apache.brooklyn.util.javalang.coerce.TypeCoercionsTest.assertCoercionFailsWithErrorMatching(TypeCoercionsTest.java:154)
at 
org.apache.brooklyn.util.javalang.coerce.TypeCoercionsTest.testCoercePrimitiveFailures(TypeCoercionsTest.java:140)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services