Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/341
+1 for merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/341
Tested by @duncangrant (for his use-case with kubernetes in clocker, which
also motivated his https://github.com/apache/brooklyn-server/pull/361). Merging
now.
---
If your project is set
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/341
@neykov can you review these additional commits please? Do you agree that
we should merge this, and not @grkvlt 's #279?
When refactoring the tests to remove duplication, I
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/341
The changes make sense. I think they will work even if the DSL is set on
the location object, nothing specific to `provisioning.properties` here. Worth
a test case to confirm?
The
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/341
@ahgittin I've rebased this against master (now that #340 is merged), and
confirmed `JcloudsRebindStubTest` still passes.
Can you review please?
---
If your project is set up for
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/341
Can we merge #340 and then look at this? It gives clearer methods for
dealing with semantics of copying resolved / unresolved semantics, and it moves
`Location`'s config to be treated
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/341
See #279 for an alternative fix (though no test - we could copy the test
from here into that PR).
We'll only want one of this PR or #279 to be merged, I think. @grkvlt
@ahgittin
