[GitHub] brooklyn-server issue #561: better presentation for sensor publishing tasks

2017-02-16 Thread tbouron
Github user tbouron commented on the issue:

https://github.com/apache/brooklyn-server/pull/561
  
Also great to have a `SENSOR` tag, this will allows us to do filtering more 
easily.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server issue #561: better presentation for sensor publishing tasks

2017-02-16 Thread ahgittin
Github user ahgittin commented on the issue:

https://github.com/apache/brooklyn-server/pull/561
  
noticed when working on #559 .  related to but not implementing ML 
discussion at this time around whether `entities/xxx/activities` API should 
default/optionally `includeBackground`.  when listing bg tasks this gets rid of 
the annoying blank ones in the list; now you see:


![image](https://cloud.githubusercontent.com/assets/496540/23017978/4041d4d4-f434-11e6-8229-1d7ba7d202b0.png)

and clicking through you can see:


![image](https://cloud.githubusercontent.com/assets/496540/23018012/5f748fae-f434-11e6-8d23-2fcb2b7f5f79.png)


Note the addition of the `SENSOR` tag.  This could be used in UI's to 
filter sensor publication tasks /cc @tbouron .

Also note that if entity `child` publishes a sensor, eg in the course of 
`start`, and someone else, say `parent` is subscribed to it, the event does 
_not_ currently show up when you ask for `child`'s background tasks (because it 
runs with the `parent` as the context entity) nor the `start` task's subtasks 
(as we don't normally want to execute it as an in-queue subtask).  Thus that 
event will _not_ show up even if you `includeBackground` on the `start` task; 
it will only show up if you query `parent` entity's tasks (with 
`includeBackground` if we change the default for that endpoint as discussed on 
ML).  However it will still report the `child.start` as his "submitted by".  If 
that is a problem we should add an index on `submittedBy` for tasks so we can 
properly and efficiently get `includeBackground` tasks submitted by a task even 
across entity boundaries.  However ATM I think it is a minor but liveable 
quirk.  (In any case it isn't being introduced here, it is just becoming clea
 rer because other things are being clarified.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---