[GitHub] brooklyn-server issue #672: Bundle uninstall and snapshot

2017-06-21 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/672 Results of ML discussion summarised in https://github.com/apache/brooklyn-docs/pull/198 , with PR to follow on this project implementing that (which will be referenced there) --- If your

[GitHub] brooklyn-server issue #672: Bundle uninstall and snapshot

2017-06-19 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/672 Thanks @geomacy @neykov -- good points. Will research and take to ML. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] brooklyn-server issue #672: Bundle uninstall and snapshot

2017-06-19 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/672 I'm not sold on the idea, but that could be because I spend too much time in Java land. OSGi style versioning feels niche - not widely known/used. It's more restrictive. We'll still need

[GitHub] brooklyn-server issue #672: Bundle uninstall and snapshot

2017-06-19 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/672 @ahgittin re. the version numbers; suggest we take this to the mailing list to disuss, but my feeling is that people are used to using Maven versions and it's convenient to regard those as

[GitHub] brooklyn-server issue #672: Bundle uninstall and snapshot

2017-06-16 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/672 @neykov @geomacy I've been working in this area for a different reason - if people use `v1` as a version a few minor things break. wdyt about using OSGi versions everywhere,

[GitHub] brooklyn-server issue #672: Bundle uninstall and snapshot

2017-06-15 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/672 P.S. I can have a look at implementing those changes, unless anyone else is particularly keen to do so? --- If your project is set up for it, you can reply to this email and have your

[GitHub] brooklyn-server issue #672: Bundle uninstall and snapshot

2017-06-15 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/672 I've been catching up on some of the merged PRs and noticed the following. When doing `br catalog add .` with the following `catalog.bom` in the folder: ``` brooklyn.catalog:

[GitHub] brooklyn-server issue #672: Bundle uninstall and snapshot

2017-06-07 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/672 Thanks @geomacy for the super-quick follow-up fix in #719. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] brooklyn-server issue #672: Bundle uninstall and snapshot

2017-06-06 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/672 Thanks @geomacy. Merged https://github.com/apache/brooklyn-client/pull/53 following @Graeme-Miller 's review there but as I'm a go newbie (g00b ?) appreciate any comments you have there.

[GitHub] brooklyn-server issue #672: Bundle uninstall and snapshot

2017-06-06 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/672 Tests all look good, I added test672a.zip to catalog ``` [geoff:] master(+0/-889)* ± br catalog add test672a.zip myTestEnt:0.12.0.SNAPSHOT myOtherTest:0.12.0.SNAPSHOT

[GitHub] brooklyn-server issue #672: Bundle uninstall and snapshot

2017-05-27 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/672 Test files attached (both cause the problem described above. [test672a.zip](https://github.com/apache/brooklyn-server/files/1033430/test672a.zip)

[GitHub] brooklyn-server issue #672: Bundle uninstall and snapshot

2017-05-26 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/672 Test files attached (both cause the problem described above. [test672a.zip](https://github.com/apache/brooklyn-server/files/1032231/test672a.zip)

[GitHub] brooklyn-server issue #672: Bundle uninstall and snapshot

2017-05-26 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/672 I have **finally** got round to doing a test on this, sorry to have taken so long. I will attach a couple of zip files here for test purposes, each being a separate -SNAPSHOT

[GitHub] brooklyn-server issue #672: Bundle uninstall and snapshot

2017-05-09 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/672 @ahgittin have made a start to this but not got all the way through it yet; looks great; I like the tests `testClassAccessAfterUninstall` and friends --- If your project is set up for it,

[GitHub] brooklyn-server issue #672: Bundle uninstall and snapshot

2017-05-08 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/672 Failure due to deadlock described and fixed in #671 . Tests pass locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.