[GitHub] brooklyn-server pull request #344: JmxService tests marked as integration

[aledsage]

Github user aledsage closed the pull request at:

https://github.com/apache/brooklyn-server/pull/344


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #344: JmxService tests marked as integration

[aledsage]

GitHub user aledsage opened a pull request:

https://github.com/apache/brooklyn-server/pull/344

JmxService tests marked as integration

These tests expect a specific port to be available, which may not be true
in a shared jenkins environment. Therefore marking them as "Integration".

Also moves newJmxServiceRetrying into JmxService.

---
Longer term, we could rewrite the JmxService tests in one of two ways (but 
I suggest we don't tackle those right now):
1. First (and simplest), we could use the `newJmxServiceRetrying` so that 
it tries different ports until one starts. We'd need to rewrite the test so 
that the entity didn't hard-code an expected port. We'd first start the 
`JmxService`, and then set the config/attribute on the entity.

2. We could try to pass in port `0` to the `JmxService` so that it 
allocates any available port. That looks a bit harder (the port is passed 
inside the `JMXServiceURL`. A very quick try at missing the port out from that 
led to other issues with `connectorServer.start()` (and with needing to get the 
real address that includes the port only after having started the 
connectorServer).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aledsage/brooklyn-server 
mark-JmxService-tests-as-integration

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-server/pull/344.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #344


commit 14b1c0251335d915d6f4813cce14643d9e9ab103
Author: Aled Sage 
Date:   2016-09-22T19:57:08Z

JmxService tests marked as integration

They expect a specific port to be available, which may not be true
in a shared jenkins environment.

Moves newJmxServiceRetrying into JmxService.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---